yearn/veyfi issues and pull requests

#50 - fix: gauge make sure addresses are not zero

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#49 - fix: possible overflow fixes#41

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#49 - fix: possible overflow fixes#41

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#48 - Voter.sol: redundant for loop in poke.

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#48 - Voter.sol: redundant for loop in poke.

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#47 - Gauge.sol: updateRewardManager vs setRewardManager

Issue - State: closed - Opened by anticlimactic over 2 years ago - 2 comments

#47 - Gauge.sol: updateRewardManager vs setRewardManager

Issue - State: closed - Opened by anticlimactic over 2 years ago - 2 comments

#46 - Question GaugeFactory.sol gauges are not exclusive to yearn vaults?

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#46 - Question GaugeFactory.sol gauges are not exclusive to yearn vaults?

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#45 - Question Gauge.sol and GaugeFactory.sol can create multiple gauges for same stakingToken (vault)?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#45 - Question Gauge.sol and GaugeFactory.sol can create multiple gauges for same stakingToken (vault)?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#44 - Gauge.sol rewardManager can add a bad extraRewards that locks user vault shares

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#44 - Gauge.sol rewardManager can add a bad extraRewards that locks user vault shares

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#43 - Gauge.sol can unintentionally create a gauge with 0x0 rewards and later be exposed to initialize being open for takeover

Issue - State: closed - Opened by storming0x over 2 years ago
Labels: code review

#43 - Gauge.sol can unintentionally create a gauge with 0x0 rewards and later be exposed to initialize being open for takeover

Issue - State: closed - Opened by storming0x over 2 years ago
Labels: code review

#42 - Gauge.sol inconsistent prefix naming

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#42 - Gauge.sol inconsistent prefix naming

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#41 - Gauge.sol possible overflow revert on

Issue - State: closed - Opened by storming0x over 2 years ago
Labels: code review

#41 - Gauge.sol possible overflow revert on

Issue - State: closed - Opened by storming0x over 2 years ago
Labels: code review

#40 - Gauge.sol can accept 0x0 address as rewardManager

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#40 - Gauge.sol can accept 0x0 address as rewardManager

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#39 - test: add ExtraReward.sol tests

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#39 - test: add ExtraReward.sol tests

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#38 - chore: remove unused imports

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#38 - chore: remove unused imports

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#37 - loss rewards appear to be calculated incorrectly in ExtraRewards.sol

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#37 - loss rewards appear to be calculated incorrectly in ExtraRewards.sol

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#36 - chore: fix typos in docs + code

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#36 - chore: fix typos in docs + code

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#35 - test: added Gauge.sol tests

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#35 - test: added Gauge.sol tests

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#34 - reward can potentially be zero in _getREward

Issue - State: closed - Opened by storming0x over 2 years ago - 4 comments

#34 - reward can potentially be zero in _getREward

Issue - State: closed - Opened by storming0x over 2 years ago - 4 comments

#33 - question: VeYFIRewards around _getReward internal method and design

Issue - State: closed - Opened by storming0x over 2 years ago - 4 comments
Labels: code review

#33 - question: VeYFIRewards around _getReward internal method and design

Issue - State: closed - Opened by storming0x over 2 years ago - 4 comments
Labels: code review

#32 - chore: fix typos in Gauge.sol

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#32 - chore: fix typos in Gauge.sol

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#31 - feat: add removeExtraReward function to Gauge

Pull Request - State: closed - Opened by anticlimactic over 2 years ago

#30 - feat: unlock for all mechanism

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#29 - Document penalty mechanism

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: code review

#28 - contract might try to donate zero penalty

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: code review

#27 - This method actually only works if the lock hasnt expired?

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: code review

#26 - Potentially this method can accept address zero essentially locking withdraws and bricking several important interactions with the contract.

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: code review

#25 - Potentially this method can accept address zero essentially locking withdraws and bricking several important interactions with the contract.

Issue - State: closed - Opened by pandadefi almost 3 years ago - 3 comments
Labels: code review

#24 - Can you clarify here the reasoning between changing the balanceOf implementation w binary search and the original curve's implementation?

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: code review

#23 - Any benefit on using latest vyper version compared to curve's 0.2.4 existing one?

Issue - State: closed - Opened by pandadefi almost 3 years ago - 3 comments
Labels: code review

#22 - Would remove underscore prefix to keep consistency with Curve's style.

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: code review

#21 - Code Review

Issue - State: closed - Opened by storming0x almost 3 years ago - 15 comments
Labels: code review

#20 - chore: bump ganache version

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#19 - Fix typo

Pull Request - State: closed - Opened by phillip055 almost 3 years ago - 2 comments

#18 - Cleanup and doc extra reward

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#17 - feat: remove vault from rewards

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#16 - Remove vault from rewards

Issue - State: closed - Opened by pandadefi almost 3 years ago

#15 - Add a `removeExtraReward` function to Gauge

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: good first issue

#14 - feat: add events to vote

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#13 - feat: vote delegation

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#12 - Add vote delegation

Issue - State: closed - Opened by pandadefi almost 3 years ago
Labels: enhancement

#11 - feat: add sweep

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#10 - Increase coverage

Issue - State: closed - Opened by pandadefi almost 3 years ago - 2 comments
Labels: good first issue

#9 - feat: add early veYfi exit

Pull Request - State: closed - Opened by pandadefi almost 3 years ago

#8 - Add boost mechanism to ExtraReward contract

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: enhancement, good first issue

#7 - Remove votes when veYFI balance is zero

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment
Labels: good first issue

#6 - Add a gauge registry

Issue - State: closed - Opened by pandadefi almost 3 years ago - 1 comment

#5 - Add back variables to immutable

Issue - State: closed - Opened by pandadefi almost 3 years ago
Labels: wontfix

#4 - Add a sweep function to claim airdroped tokens

Issue - State: closed - Opened by pandadefi almost 3 years ago
Labels: good first issue

#3 - Add events to Voter

Issue - State: closed - Opened by pandadefi almost 3 years ago
Labels: enhancement, good first issue

#2 - Add early veYfi exit

Issue - State: closed - Opened by pandadefi almost 3 years ago - 2 comments
Labels: help wanted

#1 - Vote-locked YFI

Issue - State: closed - Opened by pandadefi almost 3 years ago

GitHub / yearn/veyfi issues and pull requests