yearn/veyfi issues and pull requests

#100 - feat: add migration to ve

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#100 - feat: add migration to ve

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#99 - move to offchain voting

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#99 - move to offchain voting

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#98 - chore: refactor to ape

Pull Request - State: closed - Opened by fubuloubu over 2 years ago - 1 comment

#98 - chore: refactor to ape

Pull Request - State: closed - Opened by fubuloubu over 2 years ago - 1 comment

#97 - chore: remove .gitattributes file

Pull Request - State: closed - Opened by fubuloubu over 2 years ago

#97 - chore: remove .gitattributes file

Pull Request - State: closed - Opened by fubuloubu over 2 years ago

#96 - chore: add event to unlock

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#96 - chore: add event to unlock

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#95 - chore: add event to ve init

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#95 - chore: add event to ve init

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#94 - chore: add event to _notifyRewardAmount

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#94 - chore: add event to _notifyRewardAmount

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#93 - chore: add event to sweep

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#93 - chore: add event to sweep

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#92 - chore: add event to updateReward

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#92 - chore: add event to updateReward

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#91 - chore: add deleted rewards on clearExtraRewards

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#91 - chore: add deleted rewards on clearExtraRewards

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#90 - Add event to gauge initialize

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#90 - Add event to gauge initialize

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#89 - chore: change revert messages

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#89 - chore: change revert messages

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#88 - Question: Should All @nonreentrant Have Different Key Names?

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review

#88 - Question: Should All @nonreentrant Have Different Key Names?

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review

#87 - VotingEscrow.increase_unlock_time: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 2 comments
Labels: code review, subgraph

#87 - VotingEscrow.increase_unlock_time: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 2 comments
Labels: code review, subgraph

#86 - VotingEscrow.increment_amount: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#86 - VotingEscrow.increment_amount: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#85 - VotingEscrow.create_lock/create_lock_for: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#85 - VotingEscrow.create_lock/create_lock_for: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#84 - VotingEscrow.lock: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#84 - VotingEscrow.lock: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#83 - VotingEscrow.set_reward_pool: event

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#83 - VotingEscrow.set_reward_pool: event

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#82 - VotingEscrow.init: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#82 - VotingEscrow.init: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#81 - BaseGauge.queueNewRewards: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#81 - BaseGauge.queueNewRewards: events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#80 - BaseGauge._notifyRewardAmount: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#80 - BaseGauge._notifyRewardAmount: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#79 - BaseGauge.sweep: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#79 - BaseGauge.sweep: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#78 - VeYfiRewards.rewardCheckpoint: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#78 - VeYfiRewards.rewardCheckpoint: events

Issue - State: closed - Opened by rareweasel over 2 years ago
Labels: code review, subgraph

#77 - Voter._vote: Gas consumption

Issue - State: closed - Opened by rareweasel over 2 years ago - 5 comments
Labels: code review, subgraph

#77 - Voter._vote: Gas consumption

Issue - State: closed - Opened by rareweasel over 2 years ago - 5 comments
Labels: code review, subgraph

#76 - Gauge.clearExtraRewards: Event

Issue - State: closed - Opened by rareweasel over 2 years ago - 2 comments
Labels: code review, subgraph

#75 - Gauge.removeExtraReward: Modify require

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review

#75 - Gauge.removeExtraReward: Modify require

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review

#74 - Gauge.initialize: Change error messages

Issue - State: closed - Opened by rareweasel over 2 years ago - 5 comments
Labels: code review

#74 - Gauge.initialize: Change error messages

Issue - State: closed - Opened by rareweasel over 2 years ago - 5 comments
Labels: code review

#73 - GaugeFactory.createGauge / Gauge.initialize: Events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#73 - GaugeFactory.createGauge / Gauge.initialize: Events

Issue - State: closed - Opened by rareweasel over 2 years ago - 1 comment
Labels: code review, subgraph

#72 - fix: load array length in memory for loops

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#72 - fix: load array length in memory for loops

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#71 - Load array length in memory before looping

Issue - State: closed - Opened by 0xbok over 2 years ago - 3 comments

#71 - Load array length in memory before looping

Issue - State: closed - Opened by 0xbok over 2 years ago - 3 comments

#70 - feat: ease lock creation for vesting

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#70 - feat: ease lock creation for vesting

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#69 - Use approve instead of safeApprove

Issue - State: closed - Opened by pandadefi over 2 years ago
Labels: good first issue

#69 - Use approve instead of safeApprove

Issue - State: closed - Opened by pandadefi over 2 years ago
Labels: good first issue

#68 - feat: prevent rewards to be distributed forever

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#68 - feat: prevent rewards to be distributed forever

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#67 - chore: remove override keyword

Pull Request - State: closed - Opened by 0xbok over 2 years ago - 1 comment

#67 - chore: remove override keyword

Pull Request - State: closed - Opened by 0xbok over 2 years ago - 1 comment

#66 - Gaugle.sol remove `updateReward` modifier and use `_updateReward` directly.

Issue - State: closed - Opened by 0xbok over 2 years ago - 1 comment

#66 - Gaugle.sol remove `updateReward` modifier and use `_updateReward` directly.

Issue - State: closed - Opened by 0xbok over 2 years ago - 1 comment

#65 - Gauge.sol change `queueNewRewards()` to not return

Issue - State: closed - Opened by 0xbok over 2 years ago - 1 comment

#65 - Gauge.sol change `queueNewRewards()` to not return

Issue - State: closed - Opened by 0xbok over 2 years ago - 1 comment

#64 - feat: max number of delegation a user can get

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#64 - feat: max number of delegation a user can get

Pull Request - State: closed - Opened by pandadefi over 2 years ago

#63 - Voter.sol if enough accounts delegate to a single address, changing delegates may run out of gas

Issue - State: closed - Opened by storming0x over 2 years ago - 9 comments
Labels: code review

#63 - Voter.sol if enough accounts delegate to a single address, changing delegates may run out of gas

Issue - State: closed - Opened by storming0x over 2 years ago - 9 comments
Labels: code review

#62 - Voter.sol question about weights and how they work?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#62 - Voter.sol question about weights and how they work?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#61 - Voter.sol how are the vote results executed and distributed to gauges in rewards?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#61 - Voter.sol how are the vote results executed and distributed to gauges in rewards?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#60 - Voter.sol is this missing an update gauge method?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#60 - Voter.sol is this missing an update gauge method?

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#59 - Voter.sol inconsistent argument prefix naming

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#59 - Voter.sol inconsistent argument prefix naming

Issue - State: closed - Opened by storming0x over 2 years ago - 2 comments
Labels: code review

#58 - Voter.sol missing doc on argument

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#58 - Voter.sol missing doc on argument

Issue - State: closed - Opened by storming0x over 2 years ago - 1 comment
Labels: code review

#57 - Voter.sol is gov argument intended to be different from gov field

Issue - State: closed - Opened by storming0x over 2 years ago - 3 comments
Labels: code review

#57 - Voter.sol is gov argument intended to be different from gov field

Issue - State: closed - Opened by storming0x over 2 years ago - 3 comments
Labels: code review

#56 - test_voting_escrow.py doesn't use account fixtures

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#56 - test_voting_escrow.py doesn't use account fixtures

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#55 - Voter can delegate to themselves in Voter.sol

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#55 - Voter can delegate to themselves in Voter.sol

Issue - State: closed - Opened by anticlimactic over 2 years ago - 1 comment

#54 - test: add Voter.sol tests

Pull Request - State: closed - Opened by anticlimactic over 2 years ago - 3 comments

#54 - test: add Voter.sol tests

Pull Request - State: closed - Opened by anticlimactic over 2 years ago - 3 comments

#53 - chore: remove internal functions

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#53 - chore: remove internal functions

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#52 - fix: naming

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#52 - fix: naming

Pull Request - State: closed - Opened by 0xbok over 2 years ago

#51 - Some public functions call internal function with the same signature

Issue - State: closed - Opened by 0xbok over 2 years ago - 2 comments

#51 - Some public functions call internal function with the same signature

Issue - State: closed - Opened by 0xbok over 2 years ago - 2 comments

#50 - fix: gauge make sure addresses are not zero

Pull Request - State: closed - Opened by pandadefi over 2 years ago

GitHub / yearn/veyfi issues and pull requests