tokamak-network/gem-nft-contract issues and pull requests

#87 - Add a mined gem Id to the GemMiningClaimed event

Issue - State: open - Opened by jusdy 3 months ago
Labels: type: help wanted

#87 - Add a mined gem Id to the GemMiningClaimed event

Issue - State: open - Opened by jusdy 3 months ago
Labels: type: help wanted

#86 - Code review2 applied

Pull Request - State: closed - Opened by mehdi-defiesta 3 months ago

#85 - Code review2 applied

Pull Request - State: closed - Opened by mehdi-defiesta 3 months ago

#85 - Code review2 applied

Pull Request - State: closed - Opened by mehdi-defiesta 3 months ago

#82 - redeployment

Pull Request - State: closed - Opened by mehdi-defiesta 3 months ago

#81 - Code review2 applied

Pull Request - State: closed - Opened by mehdi-defiesta 3 months ago

#80 - Code review2 applied

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#79 - [Code review: Contract Bugs]: Different storage structures used by proxy and logic (L1WrappedStakedTON)

Issue - State: closed - Opened by Zena-park 4 months ago - 1 comment
Labels: severity: LOW, codeReivew: gem-nft

#78 - [Code review: Contract Bugs]: Duplicate Event

Issue - State: closed - Opened by Zena-park 4 months ago - 1 comment
Labels: severity: LOW, codeReivew: gem-nft

#77 - [Code review: Contract Bugs]: A wrong return value of getTotalClaimableAmountByUser function

Issue - State: closed - Opened by Zena-park 4 months ago - 3 comments
Labels: severity: LOW, codeReivew: gem-nft

#76 - [Code review: Contract Bugs]: Users cannot claim withdrawal in some cases when DepositManager processRequest from lowIndex to highIndex

Issue - State: closed - Opened by nguyenzung 4 months ago - 28 comments
Labels: severity: MEDIUM, codeReivew: gem-nft

#75 - [Code review: Contract Bugs]: Inconsistency logic when handling TON and WTON

Issue - State: closed - Opened by nguyenzung 4 months ago - 2 comments
Labels: won't fix, codeReivew: gem-nft

#74 - Code review2

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#73 - Add the cooldownDueDate value on GemMiningClaimed value

Issue - State: closed - Opened by jusdy 4 months ago - 1 comment
Labels: type: suggestion

#72 - Wrong assigned CooldownDueDate value on forgeToken function

Issue - State: closed - Opened by jusdy 4 months ago - 1 comment
Labels: type: suggestion

#71 - Fix the variable name of Gem structure

Issue - State: closed - Opened by jusdy 4 months ago - 1 comment
Labels: type: suggestion

#70 - Update the Created event with the miningTry value

Issue - State: closed - Opened by jusdy 4 months ago - 1 comment
Labels: type: suggestion

#69 - Code review2

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#68 - optimised storage slots used by loops

Pull Request - State: closed - Opened by demis1997 4 months ago - 1 comment

#67 - optimizations

Pull Request - State: closed - Opened by demis1997 4 months ago

#66 - Code review2

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#65 - Code review2

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#64 - Code release apply

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#63 - Code release duplication

Pull Request - State: closed - Opened by mehdi-defiesta 4 months ago

#62 - gem-nft code Review in progress

Issue - State: closed - Opened by zzooppii 5 months ago

#61 - [Code review: Contract Bugs]: Using the same event name for different functions

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#60 - [Code review: Contract Bugs]: The '_distributeFees' function's gas fees issue

Issue - State: closed - Opened by Zena-park 5 months ago - 3 comments
Labels: severity: LOW, codeReivew: gem-nft

#59 - [Code review: Contract Bugs]: Recommend to add event on 'cancelMining'

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#58 - [Code review: Contract Bugs]: Duplicate code within a safeTransferFrom function

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#57 - [Code review: Contract Bugs]: Duplicate code within a transferFrom function

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#56 - [Code review: Contract Bugs]: Recommended to inherit ERC721Enumerable.

Issue - State: closed - Opened by Zena-park 5 months ago - 3 comments
Labels: codeReivew: gem-nft

#55 - [Code review: Contract Bugs]: Delete unused storage

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#54 - [Code review: Contract Bugs]: Unable to view storage value

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#53 - [Code review: Contract Bugs]: No need to run transfer transaction when randomPackFees is 0

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: codeReivew: gem-nft

#52 - [Code review: Contract Bugs]: (Question) Isn't it possible to do ZERO randomPackFees?

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: codeReivew: gem-nft

#51 - [Code review: Contract Bugs]: Recommend to require the exact amount of Ether randomPackFees.

Issue - State: closed - Opened by Zena-park 5 months ago - 19 comments
Labels: codeReivew: gem-nft

#50 - [Code review: Contract Bugs]: Exception handling when seller and buyer are the same

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#49 - [Code review: Contract Bugs]: Remove duplicate code

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#48 - [Code review: Contract Bugs]: The setApprovalForAll function can be used to reduce gas costs

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#47 - [Code review: Contract Bugs]: Incorrect token contract when claiming withdrawal tokens

Issue - State: closed - Opened by nguyenzung 5 months ago - 2 comments
Labels: won't fix, codeReivew: gem-nft

#46 - [Code review: Contract Bugs]: Check the calculation for deposit amount

Issue - State: closed - Opened by nguyenzung 5 months ago - 2 comments
Labels: won't fix, codeReivew: gem-nft

#45 - [Code review: Contract Bugs]: stakingIndex should have decimals

Issue - State: closed - Opened by nguyenzung 5 months ago - 2 comments
Labels: won't fix, codeReivew: gem-nft

#44 - [Code review: Contract Bugs]: (Question) What are the L2 specs?

Issue - State: closed - Opened by Zena-park 5 months ago - 4 comments
Labels: codeReivew: gem-nft

#43 - [Code review: Contract Bugs]: Duplicate code can be reused using modifier or function

Issue - State: closed - Opened by Zena-park 5 months ago - 6 comments
Labels: codeReivew: gem-nft, severity: GAS

#42 - [Code review: Contract Bugs]: Recommend upgradeable treasury

Issue - State: closed - Opened by Zena-park 5 months ago - 5 comments
Labels: severity: LOW, codeReivew: gem-nft

#41 - [Code review: Contract Bugs]: (Question) Information stored in 'tokenURL' page

Issue - State: closed - Opened by Zena-park 5 months ago - 5 comments
Labels: codeReivew: gem-nft

#40 - [Code review: Contract Bugs]: Optimize gas with tightly packing in 'structure'

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: codeReivew: gem-nft, severity: GAS

#39 - [Code review: Contract Bugs]: L1WrappedStakedTON and L1WrappedStakedTONProxy have different memory designs.

Issue - State: closed - Opened by Zena-park 5 months ago - 10 comments
Labels: severity: MEDIUM, codeReivew: gem-nft

#38 - [Code review: Contract Bugs]: need the view total claimable(withdrawal) amount function

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#37 - [Code review: Contract Bugs]: updateSeigniorage() function error

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#36 - [Code review: Contract Bugs]: Recommend to check the use of TON when depositing to depositManager

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: LOW, codeReivew: gem-nft

#35 - [Code review: Contract Bugs]: all possible WithdrawalRequests at once on 'claimWithdrawal'

Issue - State: closed - Opened by Zena-park 5 months ago - 4 comments
Labels: severity: LOW, codeReivew: gem-nft

#34 - [Code review: Contract Bugs]: Ownership verification required in 'requestWithdrawalTo'

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: severity: MEDIUM, codeReivew: gem-nft

#33 - [Code review: Contract Bugs]: Recommend to claim with TON

Issue - State: closed - Opened by Zena-park 5 months ago - 4 comments
Labels: severity: LOW, codeReivew: gem-nft

#32 - [Code review: Contract Bugs]: Recommend adding onApprove function in L1WrappedStakedTON.sol

Issue - State: closed - Opened by Zena-park 5 months ago - 13 comments
Labels: severity: LOW, codeReivew: gem-nft

#31 - [Code review: Contract Bugs]: Recommended use of modifier

Issue - State: closed - Opened by Zena-park 5 months ago - 2 comments
Labels: codeReivew: gem-nft, severity: GAS

#30 - [Code review: Contract Bugs]: L1WrappedStakedTONFactory creates a contract that cannot be upgraded

Issue - State: closed - Opened by Zena-park 5 months ago - 5 comments
Labels: severity: LOW, codeReivew: gem-nft

#29 - Airdrop

Pull Request - State: closed - Opened by mehdi-defiesta 5 months ago

#28 - [Gem-nft-contact - Contract Bugs]: Test template

Issue - State: closed - Opened by zzooppii 5 months ago

#27 - Usage of both constructor and initialize function

Issue - State: closed - Opened by demis1997 5 months ago - 2 comments
Labels: won't fix

#26 - Reentrancy Vulnerability: TransferFrom missing checks

Issue - State: closed - Opened by demis1997 5 months ago - 1 comment
Labels: won't fix, codeReivew: gem-nft

#25 - For loop gas optimization and readability optimization

Issue - State: closed - Opened by demis1997 5 months ago - 1 comment
Labels: codeReivew: gem-nft, severity: GAS

#24 - Remove usage of "&&" in your requires and/or replace with custom errors

Issue - State: closed - Opened by demis1997 5 months ago - 3 comments
Labels: codeReivew: gem-nft, severity: GAS

#23 - Inconsistent commenting (does not follow natspec commenting format) and use of require statements

Issue - State: closed - Opened by demis1997 5 months ago - 3 comments
Labels: codeReivew: gem-nft, severity: GAS

#22 - Different Solidity Versions and use of requires

Issue - State: closed - Opened by demis1997 5 months ago - 8 comments
Labels: codeReivew: gem-nft, severity: GAS

#21 - proxy randompack marketplace swapper

Pull Request - State: closed - Opened by mehdi-defiesta 5 months ago