pinterest/thriftcheck issues and pull requests

#85 - Bump golangci/golangci-lint-action from 4 to 5

Pull Request - State: closed - Opened by dependabot[bot] 9 months ago
Labels: dependencies, github_actions

#84 - Bump go.uber.org/thriftrw from 1.31.0 to 1.32.0

Pull Request - State: closed - Opened by dependabot[bot] 10 months ago
Labels: dependencies, go

#83 - Document the thriftcheck command

Pull Request - State: closed - Opened by jparise 12 months ago

#82 - Add Go 1.22 to the testing matrix

Pull Request - State: closed - Opened by jparise 12 months ago

#81 - Bump golangci/golangci-lint-action from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] 12 months ago
Labels: dependencies, github_actions

#80 - Bump actions/cache from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago
Labels: dependencies, github_actions

#79 - Bump github/codeql-action from 2 to 3

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 1 comment
Labels: dependencies, github_actions

#78 - Enable strict configuration parsing

Pull Request - State: closed - Opened by jparise about 1 year ago
Labels: enhancement

#77 - Replace deprecated ioutil usage with equivalents

Pull Request - State: closed - Opened by jparise about 1 year ago

#76 - Bump github.com/kkyr/fig from 0.3.2 to 0.4.0

Pull Request - State: open - Opened by dependabot[bot] about 1 year ago - 1 comment
Labels: dependencies, go

#75 - Bump actions/setup-go from 4 to 5

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago
Labels: dependencies, github_actions

#74 - Upgrade to testify 1.8.4

Pull Request - State: closed - Opened by jparise over 1 year ago

#73 - Add Go 1.21 to the testing matrix

Pull Request - State: closed - Opened by jparise over 1 year ago

#72 - [Suggestion] Switch to tagged versions for releases

Issue - State: closed - Opened by bananacocodrilo over 1 year ago - 1 comment

#71 - Bump goreleaser/goreleaser-action from 4 to 5

Pull Request - State: closed - Opened by dependabot[bot] over 1 year ago
Labels: dependencies, github_actions

#70 - Bump actions/checkout from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] over 1 year ago
Labels: dependencies, github_actions

#69 - Bump github.com/kkyr/fig from 0.3.1 to 0.3.2

Pull Request - State: closed - Opened by dependabot[bot] over 1 year ago
Labels: dependencies, go

#68 - Test against Go version 1.19 and 1.20

Pull Request - State: closed - Opened by jparise over 1 year ago

#67 - Bump go.uber.org/thriftrw from 1.30.0 to 1.31.0

Pull Request - State: closed - Opened by dependabot[bot] over 1 year ago
Labels: dependencies, go

#66 - Bump go.uber.org/thriftrw from 1.29.2 to 1.30.0

Pull Request - State: closed - Opened by dependabot[bot] almost 2 years ago
Labels: dependencies, go

#65 - Bump actions/setup-go from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] almost 2 years ago
Labels: dependencies, github_actions

#64 - Only recursively expand .thrift files

Pull Request - State: closed - Opened by jparise almost 2 years ago - 2 comments

#63 - 🚩 add support for using a folder as a parameter.

Pull Request - State: closed - Opened by Tiny-Box almost 2 years ago - 1 comment
Labels: enhancement

#62 - Suggest adding support for a folder as a check parameter.

Issue - State: closed - Opened by Tiny-Box almost 2 years ago - 3 comments
Labels: enhancement

#61 - 🚩 add struct field comment check

Pull Request - State: closed - Opened by Tiny-Box almost 2 years ago
Labels: enhancement

#60 - Suggest adding a check for comments in the Thrift files.

Issue - State: closed - Opened by Tiny-Box almost 2 years ago - 3 comments
Labels: enhancement

#59 - Remove the 'ifshort' and 'wastedassign' linters

Pull Request - State: closed - Opened by jparise almost 2 years ago

#58 - Upgrade to testify version 1.8.1 (from 1.7.1)

Pull Request - State: closed - Opened by jparise almost 2 years ago
Labels: dependencies

#57 - Remove 'skip-go-installation'

Pull Request - State: closed - Opened by jparise almost 2 years ago
Labels: github_actions

#56 - Bump github.com/kkyr/fig from 0.3.0 to 0.3.1

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago
Labels: dependencies, go

#55 - Bump goreleaser/goreleaser-action from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 1 comment
Labels: dependencies, github_actions

#54 - Run `go mod tidy`

Pull Request - State: closed - Opened by jparise over 2 years ago

#53 - Upgrade module dependencies

Pull Request - State: closed - Opened by jparise over 2 years ago
Labels: dependencies

#52 - Bump goreleaser/goreleaser-action from 2 to 3

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago
Labels: dependencies, github_actions

#51 - Bump github/codeql-action from 1 to 2

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago
Labels: dependencies, github_actions

#50 - Only apply 'field.id.{negative,zero}' to explicit field IDs

Pull Request - State: closed - Opened by jparise almost 3 years ago
Labels: enhancement

#49 - Add a 'field.id.zero' check

Pull Request - State: closed - Opened by jparise almost 3 years ago
Labels: enhancement

#48 - Bump actions/setup-go from 2 to 3

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago
Labels: dependencies, github_actions

#47 - Bump actions/cache from 2 to 3

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago
Labels: dependencies, github_actions

#46 - Improve ResolveConstant error value

Pull Request - State: closed - Opened by jparise almost 3 years ago

#45 - Move completely to Go 1.18

Pull Request - State: closed - Opened by jparise almost 3 years ago

#44 - Add a 'constant.ref' check

Pull Request - State: closed - Opened by jparise almost 3 years ago
Labels: enhancement

#43 - Add Go version 1.18 to the testing matrix

Pull Request - State: closed - Opened by jparise almost 3 years ago

#42 - Update some indirect dependencies

Pull Request - State: closed - Opened by jparise almost 3 years ago
Labels: dependencies

#41 - Bump actions/checkout from 2 to 3

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago
Labels: dependencies, github_actions

#40 - Upgrade to golangci-lint-action v3

Pull Request - State: closed - Opened by jparise almost 3 years ago

#39 - Bump golangci/golangci-lint-action from 2 to 3.1.0

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies, github_actions

#38 - Bump actions/cache from 1 to 2.1.7

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies, github_actions

#37 - Add pre-commit hooks support

Pull Request - State: closed - Opened by jparise about 3 years ago
Labels: enhancement

#36 - Upgrade to thriftrw v1.29.2

Pull Request - State: closed - Opened by jparise about 3 years ago

#35 - Add a CodeQL security-scanning workflow

Pull Request - State: closed - Opened by jparise about 3 years ago

#34 - Teach ast.Resolve() about 'include' paths

Pull Request - State: closed - Opened by jparise about 3 years ago
Labels: bug

#33 - Only files (not directories) can be `include`ed

Pull Request - State: closed - Opened by jparise over 3 years ago

#32 - More closely match GCC-style error format

Pull Request - State: closed - Opened by jparise over 3 years ago

#31 - Fix include search path logic

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: bug

#30 - Fail immediately if there's a getopt parse error

Pull Request - State: closed - Opened by jparise over 3 years ago

#29 - Upgrade to Go version 1.17

Pull Request - State: closed - Opened by jparise over 3 years ago

#28 - Switch to ast.Annotations()

Pull Request - State: closed - Opened by jparise over 3 years ago

#27 - Add 'field.optional' and 'field.requiredness' checks

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#26 - Upgrade to kkyr/fig v0.3.0

Pull Request - State: closed - Opened by jparise over 3 years ago

#25 - Enable a few more linters

Pull Request - State: closed - Opened by jparise over 3 years ago

#24 - Use current directory to resolve includes

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: bug

#23 - Add column position support for remaining nodes

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#22 - Add a new 'names.reserved' check

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#21 - Reserved keywords

Issue - State: closed - Opened by jparise over 3 years ago
Labels: enhancement, good first issue

#20 - Support documented-based @nolint directives

Pull Request - State: closed - Opened by jparise over 3 years ago

#19 - List enabled/disabled status alongside check names

Pull Request - State: closed - Opened by jparise over 3 years ago

#18 - Use fnmatch()-style file path matching

Pull Request - State: closed - Opened by jparise over 3 years ago

#17 - Support ast.Position column numbers

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#16 - Switch to ast.Position (from idl.Position)

Pull Request - State: closed - Opened by jparise over 3 years ago

#15 - Use parsed idl.Info to determine node positions

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#14 - Report line numbers for parse errors

Pull Request - State: closed - Opened by jparise over 3 years ago

#13 - Comment-based `nolint` syntax

Issue - State: closed - Opened by jparise over 3 years ago - 1 comment
Labels: enhancement

#12 - Add a new int.64bit check

Pull Request - State: closed - Opened by jparise over 3 years ago - 1 comment
Labels: enhancement

#11 - Report parse errors are first-class error messages

Pull Request - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#10 - Standardize the checks unit test pattern

Pull Request - State: closed - Opened by jparise over 3 years ago

#9 - Use filepath.Match() to match keys in include.restricted

Pull Request - State: closed - Opened by jparise over 3 years ago

#8 - Use %q to consistently quote string values

Pull Request - State: closed - Opened by jparise over 3 years ago

#7 - Add a new 'include.restricted' check

Pull Request - State: closed - Opened by jparise over 3 years ago

#6 - Rename 'includes' to 'include.exists'

Pull Request - State: closed - Opened by jparise over 3 years ago

#5 - Implement String() for Checks

Pull Request - State: closed - Opened by jparise over 3 years ago

#4 - Introduce GoReleaser for building releases

Pull Request - State: closed - Opened by jparise over 3 years ago

#3 - Use golangci-lint for linting

Pull Request - State: closed - Opened by jparise over 3 years ago

#2 - Include column (offset) in locations

Issue - State: closed - Opened by jparise over 3 years ago
Labels: enhancement

#1 - Add GitHub Actions-based CI

Pull Request - State: closed - Opened by jparise over 3 years ago

GitHub / pinterest/thriftcheck issues and pull requests