ni/csharp-styleguide issues and pull requests

#99 - Mark the NI C# Analyzers package as a development dependency

Pull Request - State: closed - Opened by nick-beer 2 months ago

#98 - Update Threading and StyleCop analyzers to latest

Pull Request - State: closed - Opened by jonathanou 5 months ago

#97 - Publish NationalInstruments.Analyzers.Utilities as a dedicated nuget package

Issue - State: open - Opened by jonathanou 5 months ago

#96 - Update code analysis and xunit nuget versions

Pull Request - State: closed - Opened by jonathanou 7 months ago

#95 - Switch to Nuget Central Package Management

Pull Request - State: closed - Opened by jonathanou 7 months ago

#94 - Add a new analyzer for checking record equality implementations

Pull Request - State: closed - Opened by jonathanou 7 months ago - 2 comments

#93 - Appendix links in Readme don't work

Issue - State: closed - Opened by epetersoni 7 months ago - 1 comment

#92 - Update StyleCopAnalyzers to latest

Issue - State: open - Opened by pakdev 9 months ago

#91 - Replace SpellingAnalyzer with version from roslyn-analyzers

Pull Request - State: closed - Opened by pakdev 9 months ago

#90 - Fix markup when syntax is at extremes

Pull Request - State: closed - Opened by pakdev 9 months ago

#89 - Enable nullable and correct usages

Pull Request - State: closed - Opened by pakdev 9 months ago

#88 - Update to use the 8.0.0 analyzer

Pull Request - State: closed - Opened by jonathanou 10 months ago

#87 - Make sure '$(NETCoreSdkVersion)' is not empty before comparing.

Pull Request - State: closed - Opened by ryaoming 10 months ago - 1 comment

#86 - Only set AnalysisLevel if unset

Pull Request - State: closed - Opened by jonathanou 11 months ago

#85 - See if .NET 8 analyzers have fixed issues with CA1508

Issue - State: open - Opened by pakdev 11 months ago - 3 comments

#84 - Introduce new analysis mode

Pull Request - State: closed - Opened by jonathanou 11 months ago - 7 comments

#83 - Update net analyzer version

Pull Request - State: closed - Opened by jonathanou 12 months ago - 16 comments

#82 - Editorconfig version introduces new compiler/SA errors that must be suppressed

Issue - State: open - Opened by pakdev 12 months ago - 1 comment

#81 - The expression "[MSBuild]::VersionGreaterThanOrEquals('', 6.0)" cannot be evaluated

Issue - State: closed - Opened by pakdev 12 months ago - 1 comment

#80 - Add new global analyzer config file support

Pull Request - State: closed - Opened by jonathanou about 1 year ago - 8 comments

#79 - Resources

Pull Request - State: closed - Opened by pakdev about 1 year ago

#78 - Fix issue 77 and add tests

Pull Request - State: closed - Opened by pakdev over 1 year ago - 2 comments

#77 - FieldsCamelCasedWithUnderscoreCodeFixProvider is a large cause of GC pressure in the wild (up 1695 mb/second)

Issue - State: closed - Opened by davkean over 1 year ago - 3 comments

#76 - Add new analyzer for Disposable derivations, with 4 tests

Pull Request - State: closed - Opened by dmondrik almost 2 years ago - 1 comment

#75 - Remove 'true' from nuget push --no-symbols parameter

Pull Request - State: closed - Opened by yaqian256 about 2 years ago

#74 - Update to .NET 6

Pull Request - State: closed - Opened by yaqian256 about 2 years ago - 3 comments

#73 - Update dependencies in the nuget spec

Pull Request - State: closed - Opened by yaqian256 about 2 years ago - 2 comments

#72 - Update C.1.1 to clarify company name should be NationalInstruments

Pull Request - State: closed - Opened by rbell517 almost 3 years ago

#71 - Fix violations that occur with new analyzers

Pull Request - State: closed - Opened by pakdev about 3 years ago

#70 - Correct and simplify docs

Pull Request - State: closed - Opened by pakdev about 3 years ago

#69 - Non-standard spelling customization

Issue - State: closed - Opened by szb640 about 3 years ago - 6 comments

#68 - Improve DiagnosticDescriptor consistency

Pull Request - State: closed - Opened by pakdev about 3 years ago

#67 - Update analyzers and frameworks to latest versions

Pull Request - State: closed - Opened by pakdev about 3 years ago - 11 comments

#66 - Remove spelling analyzer and it's tests

Pull Request - State: closed - Opened by pakdev about 3 years ago

#65 - Fix for "NI1017 gives false positives involving array initializers"

Pull Request - State: closed - Opened by tsharma-ni over 3 years ago - 7 comments

#64 - C# 9 Top-Level Statements vs CA1812

Issue - State: open - Opened by Everest2020 over 3 years ago

#63 - Update URL within NI1006 error message

Pull Request - State: closed - Opened by jryckman over 3 years ago

#62 - SA1313 has conflict with C# record example

Issue - State: open - Opened by Everest2020 over 3 years ago

#61 - Update README.md

Pull Request - State: closed - Opened by dmondrik over 3 years ago

#60 - RCS1029 is deprecated

Pull Request - State: closed - Opened by Everest2020 over 3 years ago

#59 - Error CS0006 Metadata file could not be found when build

Issue - State: closed - Opened by Heloise-H over 3 years ago - 3 comments

#58 - Stop analyzing if rule NI1800 is suppress/None

Pull Request - State: closed - Opened by pakdev over 3 years ago

#57 - NI1800_ReadError errors when NI1800 is disabled

Issue - State: closed - Opened by brianehenry over 3 years ago - 1 comment

#56 - Avoid null exception when no namespace files exist

Pull Request - State: closed - Opened by pakdev over 3 years ago

#55 - Analyzers throwing NullReferenceException for Analyzer 'NationalInstruments.Analyzers.Correctness.ApprovedNamespaceAnalyzer'

Issue - State: closed - Opened by DelpireNI over 3 years ago

#54 - Fix #53 Target file was not updated to reflect change from lib folder to analyzers folder

Pull Request - State: closed - Opened by Everest2020 over 3 years ago

#53 - Target file was not updated to reflect change from lib folder to analyzers folder.

Issue - State: closed - Opened by DelpireNI over 3 years ago

#52 - Fix Issue #51 CodeAnalysis libraries are in lib folder rather than analyzer folder

Pull Request - State: closed - Opened by Everest2020 over 3 years ago

#51 - CodeAnalysis libraries are in lib folder rather than analyzer folder.

Issue - State: closed - Opened by DelpireNI over 3 years ago

#50 - Concurrent access to HashSet<T> corrupts state

Issue - State: closed - Opened by sharwell almost 4 years ago - 2 comments

#49 - Minor changes to ApprovedNamespacesAnalyzer

Pull Request - State: closed - Opened by rkudukoli almost 4 years ago

#48 - NI1006 error message contains link to nitalk document.

Issue - State: closed - Opened by gregr-ni almost 4 years ago

#47 - NI1017 fails to report errors in certain expressions.

Issue - State: open - Opened by gregr-ni almost 4 years ago - 1 comment
Labels: bug

#46 - NI1017 gives false positives involving array initializers.

Issue - State: closed - Opened by gregr-ni almost 4 years ago - 2 comments
Labels: bug

#45 - Test GitVersion

Pull Request - State: closed - Opened by Everest2020 almost 4 years ago

#44 - Staging changes to add approved namespaces analyzer

Pull Request - State: closed - Opened by rkudukoli almost 4 years ago

#43 - Update to work with VisualStudio2019 take 2

Pull Request - State: closed - Opened by gregr-ni almost 4 years ago

#42 - Fix typo in build

Pull Request - State: closed - Opened by gregr-ni almost 4 years ago

#41 - Update MS FxCopAnalyzers package to work on VS2019

Pull Request - State: closed - Opened by gregr-ni almost 4 years ago

#40 - Update NI.Tests.ruleset

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#39 - Update "Splitting long chains of dotted method/property invocations" convention in the readme

Pull Request - State: closed - Opened by tsharma-ni almost 4 years ago

#38 - Jryckman/update logo

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#37 - Jryckman/fix default niruleset

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#36 - Test

Issue - State: closed - Opened by pakdev almost 4 years ago

#35 - Update NI.ruleset

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#34 - Clean up test rulesets

Pull Request - State: closed - Opened by jryckman almost 4 years ago - 2 comments

#33 - Enforce "Do not use LINQ query syntax" using Roslyn

Pull Request - State: closed - Opened by Colin-Tompkins almost 4 years ago - 2 comments

#32 - Jryckman/update rulesetlogic

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#31 - Update NI.CSharp.Analyzers.targets

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#30 - Enforce "Split chains of dotted method invocations" using roslyn

Pull Request - State: closed - Opened by tsharma-ni almost 4 years ago - 2 comments

#29 - Jryckman/update configuration folder

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#28 - Remove property configuration

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#27 - Update readme on how to use the package

Pull Request - State: closed - Opened by tsharma-ni almost 4 years ago

#26 - Create manual-publish.yml

Pull Request - State: closed - Opened by Everest2020 almost 4 years ago - 3 comments

#25 - Update NI.CSharp.Analyzers.targets

Pull Request - State: closed - Opened by Everest2020 almost 4 years ago

#24 - Update Coding-Conventions.md

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#23 - Create initial nuspec and folder structure to build Nuget package

Pull Request - State: closed - Opened by Everest2020 almost 4 years ago

#22 - Update README.md

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#21 - Revert documentation back to raw markdown with no cleanup

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#20 - Added bracket prefixes

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#19 - Add Auto ID start tag

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#18 - Update CSharp-Coding-Conventions-Appendix.md

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#17 - Update coding conventions document to integrate with the layout script

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#16 - Cleanup rulesets by removing duplicate, unused or incorrect configurations

Pull Request - State: closed - Opened by jryckman almost 4 years ago

#15 - Fix bad link on coding conventions markdown file

Pull Request - State: closed - Opened by Everest2020 about 4 years ago

#14 - Remove rules that don't have implementation

Pull Request - State: closed - Opened by jryckman about 4 years ago

#13 - Add script to publish "clean" conventions document to github pages

Pull Request - State: closed - Opened by jryckman about 4 years ago

#12 - Create Coding-Conventions.md

Pull Request - State: closed - Opened by jryckman about 4 years ago

#11 - Delete unused files

Pull Request - State: closed - Opened by jryckman about 4 years ago

#10 - Remove unused properties in NI.Analysis.targets

Pull Request - State: closed - Opened by jryckman about 4 years ago

#9 - Remove unused properties in NI.Analysis.targets

Pull Request - State: closed - Opened by jryckman about 4 years ago - 1 comment

#8 - Added remaining rulesets, cleaned up stale configuration and analyzers and added documentation around banned methods

Pull Request - State: closed - Opened by jryckman about 4 years ago

#7 - Fix release build errors and copy files from wrapper package

Pull Request - State: closed - Opened by jryckman about 4 years ago

#6 - Setup CI for main branch

Pull Request - State: closed - Opened by Everest2020 about 4 years ago - 1 comment

#5 - Add existing analyzers from DCToolsStaging into this github repo

Pull Request - State: closed - Opened by jryckman about 4 years ago

#4 - Repo should have `main` branch

Issue - State: closed - Opened by alejandro5042 about 4 years ago - 2 comments

#3 - Create initial README.md to add to main page

Pull Request - State: closed - Opened by jryckman about 4 years ago

#2 - Create PULL Request template

Pull Request - State: closed - Opened by SukruthGrandhiNI about 4 years ago

#1 - Add codeowners to the review

Pull Request - State: closed - Opened by SukruthGrandhiNI about 4 years ago

GitHub / ni/csharp-styleguide issues and pull requests