ngneat/dialog issues and pull requests

#130 - fix: prevent dialog from closing when selecting a text from the dialog

Pull Request - State: closed - Opened by rg-lahcene 3 months ago - 3 comments

#129 - Releasing the selection in the backdrop closes the dialog

Issue - State: closed - Opened by rg-lahcene 3 months ago - 3 comments

#128 - Dialog not removing injected <style> from <head> when closed via closeButton, causing body overflow to remain hidden

Issue - State: open - Opened by devFrontdev 5 months ago - 1 comment

#127 - Using a non standalone component in dialog...

Issue - State: open - Opened by alpozgur 5 months ago

#126 - Please consider adding support for Angular 18

Issue - State: open - Opened by reals79 6 months ago - 2 comments

#125 - Migrate to Angular 16

Issue - State: closed - Opened by 14837-eng 7 months ago

#124 - fix: use component selector as default

Pull Request - State: closed - Opened by Tlepel 7 months ago - 1 comment

#123 - Certain dialogs don't open anymore since 5.0.0

Issue - State: closed - Opened by Tlepel 7 months ago - 13 comments

#122 - fix: allow nullable values again

Pull Request - State: closed - Opened by jacobg213 8 months ago - 1 comment

#121 - feat: overflow functionality

Pull Request - State: closed - Opened by vicky-polatov 10 months ago - 1 comment

#120 - fix: crypto does not work in http domain (specs)

Pull Request - State: open - Opened by nuriddin2468 10 months ago - 4 comments

#119 - dialog version 5.0.0 not working with latest typescript version (5.4.5)

Issue - State: closed - Opened by mrs-cp 10 months ago - 2 comments

#118 - Nested Dialog Error After Build

Issue - State: closed - Opened by dagistan-tuncbilek about 1 year ago - 8 comments

#117 - feat: 🎸 update to ng17

Pull Request - State: closed - Opened by NetanelBasal about 1 year ago - 1 comment

#116 - Create dialogs that don't block scrolling behind backdrop

Issue - State: closed - Opened by Tlepel about 1 year ago - 3 comments

#115 - feat: 🎸 allow updating the config via dialog ref

Pull Request - State: closed - Opened by shaharkazaz over 1 year ago - 1 comment

#114 - Migrate to nx workspace

Pull Request - State: closed - Opened by shaharkazaz over 1 year ago - 1 comment

#113 - fix: 🐛 ignore open dialogs instead of throwing an error

Pull Request - State: closed - Opened by shaharkazaz over 1 year ago - 1 comment

#112 - Body scroll blocking when component attached to container

Issue - State: open - Opened by Romko775 over 1 year ago - 1 comment
Labels: enhancement

#111 - build(deps-dev): bump socket.io-parser from 4.2.2 to 4.2.4

Pull Request - State: open - Opened by dependabot[bot] over 1 year ago - 1 comment
Labels: dependencies

#110 - Open dialog at non-zero drag offset

Issue - State: open - Opened by jemand771 over 1 year ago - 1 comment

#109 - feat(config): split up backdrop+escape enableClose

Pull Request - State: closed - Opened by jemand771 over 1 year ago - 1 comment

#108 - feat: add angular animations and dialog close transition

Pull Request - State: open - Opened by va-stefanek over 1 year ago - 5 comments

#107 - feat: allow to reset config once dialog has been opened

Pull Request - State: closed - Opened by va-stefanek over 1 year ago - 6 comments

#106 - feat: allow to define config in scope of the dialog component class

Pull Request - State: open - Opened by va-stefanek over 1 year ago - 11 comments

#105 - Improvements to keyboard-only dialog naivgation

Issue - State: open - Opened by jemand771 over 1 year ago - 1 comment
Labels: enhancement

#104 - How to make a modal's content scrollable, if there is more content

Issue - State: closed - Opened by zigax1 over 1 year ago - 2 comments

#103 - feat: configure min-width and max-width sizes

Pull Request - State: closed - Opened by Tlepel over 1 year ago - 1 comment

#102 - Unable to set minWidth or maxWidth

Issue - State: closed - Opened by Tlepel over 1 year ago - 1 comment

#101 - build(deps): bump socket.io-parser from 4.2.2 to 4.2.3

Pull Request - State: closed - Opened by dependabot[bot] over 1 year ago - 2 comments
Labels: dependencies

#100 - Passing data to modal component displays undefined

Issue - State: closed - Opened by zigax1 almost 2 years ago - 2 comments

#99 - docs: clarify DialogRef typings in readme

Pull Request - State: closed - Opened by milo526 almost 2 years ago - 1 comment

#98 - Documentation does not (clearly) state that ref property should be public

Issue - State: closed - Opened by milo526 almost 2 years ago - 1 comment

#97 - feat: 🎸 add option to only enable close for last opened dialog

Pull Request - State: closed - Opened by milo526 almost 2 years ago - 3 comments

#96 - Closing with escape closes all open modals

Issue - State: closed - Opened by milo526 almost 2 years ago - 1 comment
Labels: enhancement

#95 - chore: update test command in contributing.md

Pull Request - State: closed - Opened by milo526 almost 2 years ago - 1 comment

#93 - build(deps): bump minimist from 1.2.5 to 1.2.8

Pull Request - State: closed - Opened by dependabot[bot] almost 2 years ago - 2 comments
Labels: dependencies

#92 - fix(draggable): move target instead of handle

Pull Request - State: closed - Opened by jemand771 almost 2 years ago - 5 comments

#91 - feat: add aria role attribute to dialog component

Pull Request - State: closed - Opened by milo526 about 2 years ago - 1 comment

#90 - Add ARIA role specifier to dialogs

Issue - State: closed - Opened by milo526 about 2 years ago

#89 - Define dialog config on dialog class

Issue - State: open - Opened by milo526 about 2 years ago - 4 comments
Labels: enhancement

#88 - build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#87 - fix: expose return type of dialog ref

Pull Request - State: closed - Opened by milo526 about 2 years ago - 8 comments

#86 - Return type of open function does not contain result type in dialog ref

Issue - State: closed - Opened by milo526 about 2 years ago

#85 - build(deps): bump ua-parser-js from 0.7.31 to 0.7.33

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#84 - Dragging only moves handle, leaves dialog behind

Issue - State: closed - Opened by jemand771 about 2 years ago - 3 comments

#83 - build(deps): bump json5 from 2.2.1 to 2.2.3

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#82 - expose dialog open state from service

Pull Request - State: closed - Opened by shaharkazaz about 2 years ago - 1 comment

#81 - possibly undefined values inside dialog component leads to: error TS2769: No overload matches this call

Issue - State: closed - Opened by mrs-cp about 2 years ago - 7 comments

#80 - build(deps): bump decode-uri-component from 0.2.0 to 0.2.2

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#77 - Replacement for built-in dialogs

Issue - State: closed - Opened by Lonli-Lokli about 2 years ago - 1 comment

#76 - build(deps-dev): bump standard-version from 6.0.1 to 9.5.0

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#75 - build(deps): bump lodash and @commitlint/cli

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#74 - build(deps): bump minimatch from 3.0.4 to 3.0.8

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#73 - build(deps): bump minimist from 1.2.5 to 1.2.7

Pull Request - State: closed - Opened by dependabot[bot] about 2 years ago - 2 comments
Labels: dependencies

#72 - Provide DialogService only within DialogModule instead of providedIn root

Issue - State: closed - Opened by bbronswijk about 2 years ago - 5 comments

#71 - build(deps): bump loader-utils from 1.4.0 to 1.4.2

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 2 comments
Labels: dependencies

#70 - build(deps): bump socket.io-parser from 4.0.4 to 4.0.5

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 2 comments
Labels: dependencies

#69 - Customizing the drag handler

Issue - State: open - Opened by Langstra over 2 years ago - 8 comments
Labels: enhancement

#68 - build: fix the build script and add build test to ci

Pull Request - State: closed - Opened by Langstra over 2 years ago

#67 - Fix demo app and add feature to customize built-in dialog buttons texts

Pull Request - State: closed - Opened by Langstra over 2 years ago - 3 comments

#66 - How to close dialog on browser back navigation

Issue - State: open - Opened by snowfrogdev over 2 years ago - 4 comments
Labels: enhancement

#65 - fix: pass through offset parameters to resetDrag method

Pull Request - State: closed - Opened by Langstra over 2 years ago

#64 - fix(dialog-service): dialog invalid id

Pull Request - State: closed - Opened by mishahrokhola over 2 years ago

#63 - Invalid dialog id

Issue - State: closed - Opened by mishahrokhola over 2 years ago - 1 comment

#62 - Allow customization of confirm and cancel button texts

Issue - State: closed - Opened by ajsaraujo over 2 years ago - 4 comments

#61 - chore(deps): bump async from 2.6.3 to 2.6.4

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#60 - chore(deps): bump engine.io from 6.1.0 to 6.1.3

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#59 - chore(deps): bump trim-off-newlines from 1.0.1 to 1.0.3

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#58 - chore(deps): bump minimist from 1.2.5 to 1.2.6

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#57 - chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#56 - chore(deps): bump nanoid from 3.1.30 to 3.3.2

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#55 - feat: add dialog strict type inference #54

Pull Request - State: closed - Opened by riccardoperra almost 3 years ago - 12 comments

#54 - Strict modal typings

Issue - State: closed - Opened by riccardoperra almost 3 years ago - 3 comments
Labels: enhancement

#53 - chore(deps-dev): bump karma from 6.3.9 to 6.3.16

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#52 - chore(deps): bump follow-redirects from 1.14.5 to 1.14.8

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#51 - chore(deps): bump ajv from 6.12.0 to 6.12.6

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#50 - chore(deps-dev): bump karma from 6.3.9 to 6.3.14

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#49 - fix: 🐛 add protection for closing dismissed dialog

Pull Request - State: closed - Opened by gili-lumigo about 3 years ago

#48 - Unable to scroll dialog view

Issue - State: closed - Opened by priyanthabuddhika about 3 years ago - 3 comments

#47 - [FR] Able to change the default dialog buttons inner text

Issue - State: closed - Opened by hamonCordova about 3 years ago - 1 comment

#46 - chore(deps): bump y18n from 4.0.0 to 4.0.3

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#45 - chore(deps): bump glob-parent from 5.1.1 to 5.1.2

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#44 - chore(deps): bump handlebars from 4.7.6 to 4.7.7

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#43 - chore(deps): bump ini from 1.3.5 to 1.3.8

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#42 - chore(deps): bump path-parse from 1.0.6 to 1.0.7

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#41 - Change configurations after the dialog is opened

Issue - State: closed - Opened by hamonCordova over 3 years ago - 5 comments
Labels: enhancement

#40 - [FR] Transition on close

Issue - State: open - Opened by hamonCordova over 3 years ago - 1 comment
Labels: enhancement

#39 - Move more configuration options to the global configuration

Pull Request - State: closed - Opened by Langstra over 3 years ago

#38 - Add additional draggable config and methods to get and reset the drag offset

Pull Request - State: closed - Opened by Langstra over 3 years ago - 2 comments

#37 - More options in the forRoot

Issue - State: closed - Opened by Langstra over 3 years ago - 3 comments

#36 - Can not limit Draggable area.

Issue - State: closed - Opened by cskasun over 3 years ago - 6 comments

#35 - Clicking any button inside modal will close it

Issue - State: closed - Opened by dkzeb over 3 years ago - 4 comments

#34 - [FR] Option to disable backdrop close, but still allow closing via ESC (if not disabled)

Issue - State: closed - Opened by hidegh almost 4 years ago - 3 comments
Labels: enhancement, good first issue

#33 - [FR] Possibility to add additional classes (from code) to the ngneat-modal-content element to allow sizing via Bootstrap col-, col-[sm|md|lg|xl]- classes

Issue - State: open - Opened by hidegh almost 4 years ago - 3 comments
Labels: enhancement

GitHub / ngneat/dialog issues and pull requests