GitHub / moodlehq/moodle-cs issues and pull requests
#199 - InlineCommentSniff not correctly recognising type hints that should be allowed
Issue -
State: open - Opened by timhunt 3 months ago
#198 - Permit use of @deprecated on class variables
Issue -
State: open - Opened by FMCorz 4 months ago
#197 - Ignore enums in InlineCommentSniff
Pull Request -
State: closed - Opened by cameron1729 5 months ago
- 1 comment
#196 - Enums are not ignored by InlineCommentSniff
Issue -
State: closed - Opened by cameron1729 5 months ago
#195 - Anonymous classes should not contribute to artifact count.
Issue -
State: closed - Opened by cameron1729 5 months ago
- 1 comment
#194 - Add a rule about cache definition language string being required for any new cache
Issue -
State: open - Opened by aspark21 6 months ago
- 1 comment
#193 - Do not report errors in the one-line comments that start with "Mdlcode"
Issue -
State: open - Opened by marinaglancy 6 months ago
#192 - Verify version in `@deprecated` in doc block comment matches version in `\core\attribute\deprecated` annotation
Issue -
State: open - Opened by ziegenberg 6 months ago
#191 - Codechecker should verify Behat step deprecation
Issue -
State: open - Opened by ziegenberg 6 months ago
#190 - TestCaseProvider.dataProviderSyntaxMethodInvalidReturnType spits error for \Generator return type
Issue -
State: open - Opened by PhilippImhof 9 months ago
#189 - Fixes #188. @Transform PHPdoc should be allowed in Behat files
Pull Request -
State: closed - Opened by timhunt 9 months ago
- 1 comment
#188 - @Transform Behat keyword is incorrected reported
Issue -
State: closed - Opened by timhunt 9 months ago
#187 - `Inline doc block comments are not allowed` when using readonly as first property modifier
Issue -
State: open - Opened by matthewhilton 9 months ago
- 1 comment
#186 - Add test for multiline attributes for MissingDocblockSniff on methods outside of classes
Pull Request -
State: closed - Opened by ziegenberg 11 months ago
- 1 comment
#185 - Unable to pass checks with multiline attributes using MissingDocblockSniff for non-class methods
Issue -
State: closed - Opened by ziegenberg 11 months ago
- 3 comments
#184 - Make PHPStorm tag `@noinspection` valid
Pull Request -
State: open - Opened by daniil-berg 11 months ago
#183 - Detect that classes which extend moodleform* call parent:: in overridden functions
Issue -
State: open - Opened by jrchamp 11 months ago
#182 - ValidVariableNameSniff: freshen allowed globals
Pull Request -
State: open - Opened by jrchamp 11 months ago
- 1 comment
#181 - Allowed globals is incomplete?
Issue -
State: open - Opened by jrchamp 11 months ago
- 1 comment
#180 - Unit test "final" rule wrongly triggers for abstract classes
Issue -
State: closed - Opened by PhMemmel 12 months ago
- 2 comments
#179 - Bump to phpcs 3.10.2
Pull Request -
State: open - Opened by stronk7 about 1 year ago
- 1 comment
#178 - Incorrect fix for multi-line array
Issue -
State: open - Opened by andrewnicols about 1 year ago
- 1 comment
#177 - Fixes #176. Match blank boilerplate lines correctly.
Pull Request -
State: closed - Opened by micaherne about 1 year ago
- 3 comments
#176 - Inserted boilerplate gets broken if there is a CRLF line break after the opening tag
Issue -
State: closed - Opened by micaherne about 1 year ago
- 2 comments
#175 - Fixes #174. Insert boilerplate correctly where comment on first line.
Pull Request -
State: closed - Opened by micaherne about 1 year ago
- 3 comments
#174 - BoilerplateCommentSniff causes invalid code if first line has comment
Issue -
State: closed - Opened by micaherne about 1 year ago
- 3 comments
Labels: bug
#173 - Ensure we stop looking for file phpdoc block asap
Pull Request -
State: closed - Opened by stronk7 about 1 year ago
- 2 comments
#172 - Commenting.PackageSniff fix seems broken when first doc comment is an inline one
Issue -
State: closed - Opened by micaherne about 1 year ago
- 6 comments
Labels: bug
#171 - Ignore anonymous class docblocks if they have a parent
Pull Request -
State: closed - Opened by andrewnicols about 1 year ago
- 1 comment
#170 - Ignore invalid method names using the Override attribute
Pull Request -
State: closed - Opened by andrewnicols about 1 year ago
- 3 comments
Labels: enhancement
#169 - Allow extra consecutive header lines after the official boilerplate
Pull Request -
State: closed - Opened by stronk7 about 1 year ago
- 2 comments
#168 - Expected empty line after the boilerplate check breaks all workplace code
Issue -
State: closed - Opened by marinaglancy about 1 year ago
- 2 comments
#167 - Detect multiple @coversDefaultClass uses in a class
Pull Request -
State: closed - Opened by stronk7 about 1 year ago
- 1 comment
#166 - Make the TestCaseCovers sniff to detect multiple @coversDefaultClass cases
Issue -
State: closed - Opened by stronk7 about 1 year ago
- 1 comment
Labels: enhancement, good first issue
#165 - New sniff to detect correct setUp/tearDown parent calls
Pull Request -
State: closed - Opened by stronk7 about 1 year ago
- 3 comments
#164 - CodeChecker should be able to check for the rule about no string concatenation in lang files
Issue -
State: open - Opened by timhunt about 1 year ago
- 1 comment
Labels: enhancement
#163 - TestCaseProviderSniff does not detect data provider method "class::provider"
Issue -
State: open - Opened by ziegenberg about 1 year ago
- 1 comment
#162 - Bump to phpcs 3.10.1
Pull Request -
State: closed - Opened by stronk7 about 1 year ago
- 4 comments
#161 - Better integration tests, with correct exit status checks
Pull Request -
State: closed - Opened by stronk7 about 1 year ago
- 2 comments
#160 - Do not warn about missing docblocks when a method has the #[\Override] attribute
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 4 comments
#159 - Analyse if we should start checking (4.4 and up) for setAccessible() reflection uses
Issue -
State: open - Opened by stronk7 over 1 year ago
- 2 comments
#158 - Update BoilerplateCommentSniff and add fixes.
Pull Request -
State: closed - Opened by micaherne over 1 year ago
- 12 comments
#157 - Add new sniff to detect and remove constructor @return docs
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 6 comments
#156 - Make MissingDoclock code more specific (Fixes #154)
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 3 comments
#155 - Train moodle.Commenting.MissingDocblock.Missing to understand #[\Override]
Issue -
State: closed - Opened by timhunt over 1 year ago
- 6 comments
#154 - Make MissingDocblock names more specific
Issue -
State: closed - Opened by andrewnicols over 1 year ago
#153 - Rules about implements and opening brace do not accept PSR-12
Issue -
State: open - Opened by andrewnicols over 1 year ago
#152 - Towards better release procedure
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 3 comments
#151 - @var Sniff should detect presence of $varname
Issue -
State: open - Opened by andrewnicols over 1 year ago
#150 - "Missing member variable doc comment" in the constructor arguments that are class properties
Issue -
State: closed - Opened by marinaglancy over 1 year ago
- 2 comments
#149 - Warning: The string key "y" is not in the correct order, it should be before "x"
Issue -
State: closed - Opened by gjb2048 over 1 year ago
- 8 comments
#148 - Document the release process
Issue -
State: closed - Opened by andrewnicols over 1 year ago
- 9 comments
#147 - Object names may not be present for all objects
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#146 - Tags for file-specific paths should normalise pathnames
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#145 - Invalid docblock tag "@group".
Issue -
State: closed - Opened by gjb2048 over 1 year ago
- 7 comments
#144 - Properties should not be tested for regular constructors (Fixes #142)
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#143 - ERROR | Missing member variable doc comment (moodle.Commenting.VariableComment.Missing) reporting on constructor parameters.
Issue -
State: closed - Opened by gjb2048 over 1 year ago
- 1 comment
Labels: duplicate
#142 - Problem with moodle.Commenting.VariableComment and constructor methods
Issue -
State: closed - Opened by stronk7 over 1 year ago
Labels: bug
#141 - Make the TodoComment Sniff to require a complete regex (start, end delimiters)
Issue -
State: open - Opened by stronk7 over 1 year ago
Labels: bug, good first issue
#140 - Deprecated items do not need a description
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#139 - Review upper/lower class and file matching over code
Issue -
State: open - Opened by stronk7 over 1 year ago
#138 - Incorrect fixing of property names
Issue -
State: open - Opened by micaherne over 1 year ago
- 1 comment
#137 - Add sniff to detect use of /// comments.
Pull Request -
State: open - Opened by andrewnicols over 1 year ago
#136 - Analyse and implement some extra checks about phpdoc blocks spacing and tags groups
Issue -
State: open - Opened by stronk7 over 1 year ago
#135 - Remove all the MOODLE_INTERNAL fixture references
Issue -
State: open - Opened by stronk7 over 1 year ago
#134 - Add sniff to check for first line descriptions
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 5 comments
#133 - A file docblock must have at least one empty newline after it (#133)
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
Labels: bug
#132 - Fix docblocks before Multiline attributes
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 5 comments
Labels: bug
#131 - Add test for multiline attributes for MissingDocblockSniff
Pull Request -
State: closed - Opened by ziegenberg over 1 year ago
- 2 comments
#130 - Unable to pass checks with multiline attributes using MissingDocblockSniff
Issue -
State: closed - Opened by ziegenberg over 1 year ago
- 1 comment
#129 - Add sniff to detect missing docs for constants
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#128 - Line length ignore for docs
Pull Request -
State: open - Opened by andrewnicols over 1 year ago
- 3 comments
#127 - Move unit test method Missing Docblock to new code
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 3 comments
#126 - Type normalisation
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#125 - Add sniffs for file docblock @copyright and @license
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 2 comments
#124 - Introduce various doc tag sniffs
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 3 comments
#123 - PHPDoc types sniff
Pull Request -
State: open - Opened by james-cnz over 1 year ago
- 18 comments
#122 - For PRs, automatically set the author
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 1 comment
Labels: enhancement
#121 - Add sniff to cover correct use of @var
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 13 comments
#120 - Unable to pass checks with @param using constructor property promotion and readonly parameters
Issue -
State: closed - Opened by matthewhilton over 1 year ago
- 5 comments
#119 - Add sniff to detect missing docblocks
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 5 comments
#118 - Disable package checks whenever missing a target component
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 1 comment
Labels: bug
#117 - Define moodle-cs own standard, towards better coding
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 4 comments
Labels: enhancement
#116 - Category Sniffs should check the allowlevel2 and allowspread api data
Issue -
State: open - Opened by andrewnicols over 1 year ago
#115 - Remove bundled apis.json when min requirement >= 4.2
Issue -
State: open - Opened by andrewnicols over 1 year ago
Labels: task
#114 - Fix a bug detected in the AbstractSniff coverage
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#113 - Attributes should not be considered a side-effect
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 4 comments
#112 - Check category tag
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 3 comments
#111 - Lang string sorted please
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 8 comments
Labels: enhancement
#110 - Check package tags
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 5 comments
#109 - Bump squizlabs/php_codesniffer to 3.9.0
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 2 comments
Labels: task
#108 - Revert "Downgrade code to be PHP 7.0 compliant."
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 1 comment
Labels: enhancement
#107 - Revert #162 once PHP min supported version is raised to PHP 7.2
Issue -
State: closed - Opened by stronk7 over 3 years ago
#106 - Detect that setUpBeforeClass, setUp, tearDown, and tearDownAfterClass are always calling to parent
Issue -
State: closed - Opened by stronk7 over 1 year ago
- 2 comments
Labels: enhancement
#105 - Discard non-variables within double quoted strings
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 1 comment
Labels: bug
#104 - Check for correct whitespace in method declarations
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 4 comments
Labels: enhancement
#103 - Unit test classes should be declared as either final or abstract
Pull Request -
State: closed - Opened by andrewnicols over 1 year ago
- 8 comments
Labels: enhancement
#102 - New sniff: Non abstract test classes should be declared final
Issue -
State: closed - Opened by andrewnicols over 1 year ago
- 1 comment
#100 - Avoid PHP error with BoilerplateComment and empty files
Pull Request -
State: closed - Opened by stronk7 over 1 year ago
- 1 comment
Labels: bug
#99 - Detect various spacing issues in function declarations
Issue -
State: closed - Opened by stronk7 over 1 year ago