GitHub / maximelafarie/ngx-smart-modal issues and pull requests

#390 - fix: series of blocking issues

Pull Request - State: open - Opened by maximelafarie 12 months ago

#389 - Angular 18 & Standalone components

Issue - State: closed - Opened by LewBlu about 1 year ago - 1 comment

#388 - ERROR : The node to be removed is not a child of this node.

Issue - State: closed - Opened by MatthewDlr over 1 year ago - 8 comments

#387 - Circular dependency in DI detected for ApplicationRef after ngx-smart-modal and angular upgrade

Issue - State: open - Opened by Bierat1337 over 1 year ago - 2 comments

#386 - modalServiceCreate - target

Issue - State: open - Opened by AMZALE over 1 year ago - 1 comment

#385 - Standalone Support

Issue - State: closed - Opened by mattfiocca over 1 year ago - 1 comment

#384 - Extending modal.service

Issue - State: open - Opened by asgarihope over 1 year ago

#383 - Can't bind to 'autostart' since it isn't a known property of 'ngx-smart-modal'

Issue - State: open - Opened by prudnikov over 1 year ago - 4 comments

#382 - Property 'closable' is incompatible with index signature.

Issue - State: open - Opened by hakkikonu over 1 year ago - 4 comments

#381 - modal service create method parameters differ from documentation

Issue - State: open - Opened by mohsen-amani over 1 year ago

#380 - Fix/issue 379

Pull Request - State: closed - Opened by AntLer-24rus almost 2 years ago - 1 comment

#379 - modalService create<>() throws NG0902: This view is already attached to a ViewContainer!

Issue - State: closed - Opened by ArneSchoonvliet about 2 years ago - 10 comments
Labels: bug

#378 - Breaking change of modal getData()

Issue - State: open - Opened by la-we about 2 years ago - 12 comments
Labels: approved

#377 - Version 14 has been released! 🤘

Issue - State: closed - Opened by maximelafarie about 2 years ago

#376 - feat: angular-ivy-compliant refactoring

Pull Request - State: closed - Opened by maximelafarie about 2 years ago - 1 comment

#375 - Support for Angular 16 (Ivy compatibility without ngcc)

Issue - State: closed - Opened by Way about 2 years ago - 2 comments

#374 - Bump minimist, mkdirp, commitizen, karma and protractor

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#373 - Bump minimist, karma and rollup-plugin-license in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#372 - Bump http-cache-semantics and @angular/cli

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#371 - Bump json5 from 1.0.1 to 1.0.2

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#370 - Bump json5, @compodoc/compodoc, webpack, karma-webpack and source-map-loader in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#369 - Bump json5 and @angular-devkit/build-angular

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#368 - Bump express from 4.17.1 to 4.18.2

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#367 - Bump qs from 6.5.2 to 6.5.3

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#366 - Bump qs from 6.5.2 to 6.5.3 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#365 - Bump decode-uri-component from 0.2.0 to 0.2.2 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#364 - Bump decode-uri-component from 0.2.0 to 0.2.2

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#363 - Bump engine.io and karma

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#362 - Bump engine.io and karma in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#361 - Bump loader-utils and @angular-devkit/build-angular

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#360 - Bump loader-utils, karma-webpack and source-map-loader in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 2 years ago - 1 comment
Labels: dependencies

#359 - Bump socket.io-parser and karma

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#358 - Bump socket.io-parser and karma in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#357 - Cannot read properties of undefined (reading 'focus')

Issue - State: open - Opened by ginagr almost 3 years ago - 1 comment

#356 - Error: node_modules/ngx-smart-modal/src/modules/ngx-smart-modal.module.d.ts:12:24 - error TS2314

Issue - State: open - Opened by Laurens-makel almost 3 years ago

#355 - Bump jszip from 3.2.2 to 3.10.1

Pull Request - State: closed - Opened by dependabot[bot] almost 3 years ago - 1 comment
Labels: dependencies

#354 - Apply await to onAnyCloseEventFinished not working

Issue - State: open - Opened by JasmineLaiHua about 3 years ago

#353 - Bump @angular/core from 5.0.0 to 11.0.5 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#352 - Bump @angular/core from 8.0.3 to 11.0.5

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#351 - By some reason modal component mounts child component to the dom when modal is hidden

Issue - State: closed - Opened by Iuriy-Budnikov about 3 years ago

#350 - Action close modal doesn't destroy child components

Issue - State: closed - Opened by Iuriy-Budnikov about 3 years ago

#349 - How to render modal to the body?

Issue - State: closed - Opened by Iuriy-Budnikov about 3 years ago

#348 - Bump eventsource from 1.0.7 to 1.1.1

Pull Request - State: closed - Opened by dependabot[bot] about 3 years ago - 1 comment
Labels: dependencies

#347 - Bump async from 2.6.2 to 2.6.4

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#346 - Bump karma from 4.1.0 to 6.3.16

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#345 - Bump karma from 1.7.1 to 6.3.16 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#344 - Bump url-parse from 1.4.7 to 1.5.10

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#343 - Bump url-parse from 1.4.7 to 1.5.7

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#342 - Bump follow-redirects from 1.14.4 to 1.14.8 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#341 - Bump follow-redirects from 1.12.1 to 1.14.8

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#340 - Bump karma from 1.7.1 to 6.3.14 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#339 - Bump karma from 4.1.0 to 6.3.14

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#338 - Bump node-sass from 6.0.1 to 7.0.0 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#337 - export INgxSmartModalOptions

Issue - State: open - Opened by AsimNet over 3 years ago

#336 - Bump shelljs from 0.7.8 to 0.8.5 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 3 years ago - 1 comment
Labels: dependencies

#335 - Fixed ability to use @ Input() dynamic content.

Pull Request - State: closed - Opened by jwmcgettigan over 3 years ago

#334 - Fix failing build job

Pull Request - State: closed - Opened by maximelafarie almost 4 years ago

#333 - Bump url-parse from 1.4.7 to 1.5.3

Pull Request - State: closed - Opened by dependabot[bot] almost 4 years ago - 1 comment
Labels: dependencies

#332 - Bump tar from 4.4.8 to 4.4.19

Pull Request - State: closed - Opened by dependabot[bot] almost 4 years ago - 1 comment
Labels: dependencies

#331 - Bump path-parse from 1.0.6 to 1.0.7 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] almost 4 years ago - 1 comment
Labels: dependencies

#330 - Bump path-parse from 1.0.6 to 1.0.7

Pull Request - State: closed - Opened by dependabot[bot] almost 4 years ago - 1 comment
Labels: dependencies

#329 - Hi, it's is possible to open a modal and go to an anchor tag inside the modal? Thanks in advance.

Issue - State: open - Opened by zeroseisdesign almost 4 years ago

#328 - Bump tar from 4.4.8 to 4.4.15

Pull Request - State: closed - Opened by dependabot[bot] almost 4 years ago - 1 comment
Labels: dependencies

#327 - document.getElementsByTagName return 0 when component added inside ngx-smart-modal

Issue - State: closed - Opened by tsctrl about 4 years ago - 1 comment

#326 - Bump postcss from 7.0.18 to 7.0.36 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#325 - Bump dns-packet from 1.3.1 to 1.3.4

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#324 - Bump browserslist from 4.7.0 to 4.16.6 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#323 - Bump hosted-git-info from 2.8.4 to 2.8.9 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#322 - Bump hosted-git-info from 2.7.1 to 2.8.9

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#321 - Bump url-parse from 1.4.7 to 1.5.1

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#320 - Bump handlebars from 4.2.0 to 4.7.7 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#319 - Bump handlebars from 4.7.6 to 4.7.7

Pull Request - State: closed - Opened by dependabot[bot] about 4 years ago - 1 comment
Labels: dependencies

#318 - Bump ssri from 6.0.1 to 6.0.2

Pull Request - State: closed - Opened by dependabot[bot] over 4 years ago - 1 comment
Labels: dependencies

#317 - Migration for Angular 11

Pull Request - State: closed - Opened by ricardosobrado over 4 years ago - 2 comments

#316 - Add dialog-open class to <html> tag as well

Pull Request - State: closed - Opened by vibonacci over 4 years ago

#315 - Bump y18n from 3.2.1 to 3.2.2 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 4 years ago - 1 comment
Labels: dependencies

#314 - Bump y18n from 4.0.0 to 4.0.1

Pull Request - State: closed - Opened by dependabot[bot] over 4 years ago - 1 comment
Labels: dependencies

#313 - Bump elliptic from 6.5.3 to 6.5.4

Pull Request - State: closed - Opened by dependabot[bot] over 4 years ago - 1 comment
Labels: dependencies

#312 - Bump elliptic from 6.5.1 to 6.5.4 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 4 years ago - 1 comment
Labels: dependencies

#311 - URLs in NPM page are broken

Issue - State: open - Opened by ajsaraujo over 4 years ago - 4 comments

#310 - 🔥 NEWS, INFO AND FUTURE OF NGXSM 🚨

Issue - State: closed - Opened by maximelafarie over 4 years ago - 12 comments

#309 - Broken scrollbar after closing multiple opened modals

Issue - State: open - Opened by robertsine over 4 years ago - 1 comment
Labels: bug, approved, emergency: high, effort1: easy (hours)

#308 - getModalData should return observable

Issue - State: closed - Opened by kpogorze over 4 years ago - 1 comment
Labels: enhancement, approved, flag: breaking changes, emergency: medium, effort2: medium (days)

#307 - ngx-smart-modal not work angular universal

Issue - State: closed - Opened by jhimelymendoza over 4 years ago - 2 comments
Labels: help wanted

#306 - Bump ini from 1.3.5 to 1.3.7 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] over 4 years ago - 1 comment
Labels: dependencies

#305 - unfortunately, component is not working with angular 10+ and i'm waiting for the update to be able upgrade to angular 11.

Issue - State: open - Opened by FahimeRiahi over 4 years ago - 7 comments

#304 - Travis build fix

Pull Request - State: closed - Opened by alexsherekin over 4 years ago

#303 - Modal destruction 277

Pull Request - State: closed - Opened by alexsherekin over 4 years ago - 2 comments

#302 - Create method doesn't works if component's template uses pipes

Issue - State: closed - Opened by Alessio92 over 4 years ago

#301 - Angular 10 Ivy Issue

Issue - State: open - Opened by hypertextdevelopers almost 5 years ago - 2 comments
Labels: bug, help wanted, effort0: not known (need info), Need reproduction

#300 - Scrollbar bugfix

Pull Request - State: closed - Opened by AntonPolyakin almost 5 years ago

#299 - Bump http-proxy from 1.18.0 to 1.18.1 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] almost 5 years ago - 1 comment
Labels: dependencies

#298 - Bump handlebars from 4.2.0 to 4.7.6 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] almost 5 years ago - 1 comment
Labels: dependencies

#297 - Bump node-sass from 4.12.0 to 4.13.1 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] almost 5 years ago - 1 comment
Labels: dependencies

#296 - Check for nsmDialog in component before accessing length

Pull Request - State: closed - Opened by BuZZ-T almost 5 years ago - 1 comment

#295 - Fix/wording and vulnerabilities

Pull Request - State: closed - Opened by maximelafarie about 5 years ago
Labels: emergency: high

#294 - Documentation page showing 404 on Github Pages

Issue - State: closed - Opened by mike-incipia about 5 years ago - 3 comments
Labels: bug, approved, emergency: high

#293 - Bump elliptic from 6.5.1 to 6.5.3 in /src/ngx-smart-modal

Pull Request - State: closed - Opened by dependabot[bot] about 5 years ago - 1 comment
Labels: dependencies

#292 - Fixed some dependencies vulnerabilities and fixed some wordings

Pull Request - State: closed - Opened by maximelafarie about 5 years ago - 2 comments

#291 - Remove [dismissable]="false" from HTML

Pull Request - State: closed - Opened by jhthompson about 5 years ago - 1 comment