lukso-network/lsp-smart-contracts issues and pull requests

#586 - fix: typo in filename of exported `constant.js`

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#585 - perf: replace function `extractIndexFromMap(...)` and `BytesLib.slice` with explicit conversion

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#585 - perf: replace function `extractIndexFromMap(...)` and `BytesLib.slice` with explicit conversion

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#584 - refactor: mark `mapping` and state variables as `private` in LSP7/8 Core contracts

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#584 - refactor: mark `mapping` and state variables as `private` in LSP7/8 Core contracts

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#583 - chore: [TRST-R-5] return `FAILVALUE` when the signature is invalid

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#583 - chore: [TRST-R-5] return `FAILVALUE` when the signature is invalid

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#582 - chore: [TRST-L-2] remove LSP9 interfaceId check

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#582 - chore: [TRST-L-2] remove LSP9 interfaceId check

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#581 - feat!: Add validity timestamps for Relay Calls

Pull Request - State: closed - Opened by b00ste over 1 year ago - 1 comment

#580 - docs: [Code Docsumentation] add natspec about initialising ERC725

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#580 - docs: [Code Docsumentation] add natspec about initialising ERC725

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#579 - fix: do not check for `balanceOf` in LSP1 when minting via constructor

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#578 - chore: LSP14 remove line that will never be executed

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#578 - chore: LSP14 remove line that will never be executed

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#577 - refactor: [TRST-M-7] Incorrect permission check due to confusion between empty call and the zero selector

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#576 - fix: [TRST-H-1] Disallow turning reentrancy bool to false in reentrantCalls

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#576 - fix: [TRST-H-1] Disallow turning reentrancy bool to false in reentrantCalls

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#575 - refactor!: Remove function overloading in LSP0 | LSP6 | LSP9

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#574 - [LSP1]: allow the `universalReceiver` function to return arbitrary `bytes` (not necessarily abi-encoded)

Issue - State: closed - Opened by CJ42 over 1 year ago
Labels: enhancement, help wanted, discussion

#574 - [LSP1]: allow the `universalReceiver` function to return arbitrary `bytes` (not necessarily abi-encoded)

Issue - State: closed - Opened by CJ42 over 1 year ago
Labels: enhancement, help wanted, discussion

#573 - refactor: [TRST-M-1 LSP20] LSP20 fix accepted magic value, 4 bytes followed by 28 zero bytes

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#573 - refactor: [TRST-M-1 LSP20] LSP20 fix accepted magic value, 4 bytes followed by 28 zero bytes

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#572 - chore: [WP-N13] Remove unused imports

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#572 - chore: [WP-N13] Remove unused imports

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#571 - chore: [WP-N12] Consistancy: explicit false

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#571 - chore: [WP-N12] Consistancy: explicit false

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#570 - fix: [WP-L3] LSP6: LSP6KeyManagerCore.lsp20VerifyCall() Wrong value for the signer parameter in the VerifiedCall event

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#569 - perf: [WP-G11] use bitwise operations instead of modulus

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#569 - perf: [WP-G11] use bitwise operations instead of modulus

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#568 - chore: [WP-L2] encode the result of `execute` in LSP0 in LSP20 scenario

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#568 - chore: [WP-L2] encode the result of `execute` in LSP0 in LSP20 scenario

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#567 - refactor: [TRST-Recommendations] apply suggested recommendations across code

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#567 - refactor: [TRST-Recommendations] apply suggested recommendations across code

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#566 - test: verify the actual behaviour of internal functions, not custom behaviour

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#566 - test: verify the actual behaviour of internal functions, not custom behaviour

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#565 - docs: use american date format YYYY-MM-DD for audits in README

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#565 - docs: use american date format YYYY-MM-DD for audits in README

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#564 - docs: use american date format YYYY-MM-DD for audits in README

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#563 - refactor: [TRST-M-6] Add LSP20 interfaceId to LSP0 & LSP6

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#563 - refactor: [TRST-M-6] Add LSP20 interfaceId to LSP0 & LSP6

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#562 - fix: [TRST-M-5] `renounceOwnership()` will accidentally be one-step in a certain time period

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments
Labels: bug

#562 - fix: [TRST-M-5] `renounceOwnership()` will accidentally be one-step in a certain time period

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments
Labels: bug

#561 - ci: trigger foundry tests not only when PR is opened

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#561 - ci: trigger foundry tests not only when PR is opened

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#560 - test: use smock library to mock fallback function for LSP16 test

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#560 - test: use smock library to mock fallback function for LSP16 test

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#559 - fix: Change to yarn and fix prettier config

Pull Request - State: closed - Opened by richtera over 1 year ago - 4 comments

#559 - fix: Change to yarn and fix prettier config

Pull Request - State: closed - Opened by richtera over 1 year ago - 4 comments

#558 - refactor: move `ValueReceived` event in LSP0 + LSP9 interfaces + delete interface inheritance for LSP0/9

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#558 - refactor: move `ValueReceived` event in LSP0 + LSP9 interfaces + delete interface inheritance for LSP0/9

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#557 - feat: Allow calling `ERC725X.execute(uint256[],address[],uint256[],bytes[])` through the LSP6

Pull Request - State: closed - Opened by b00ste over 1 year ago - 5 comments

#555 - ci: run foundry tests only on PRs that edit Solidity

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#554 - test: run proxy related tests in parallel in CI

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#554 - test: run proxy related tests in parallel in CI

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments

#553 - tests: Add tests written by RV

Pull Request - State: closed - Opened by lucasmt over 1 year ago - 1 comment

#553 - tests: Add tests written by RV

Pull Request - State: closed - Opened by lucasmt over 1 year ago - 1 comment

#552 - tests: move Reentrancy tests in separate test suites

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#552 - tests: move Reentrancy tests in separate test suites

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#551 - build(wip): add scripts to generate list of custom errors/events and functions

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 3 comments

#551 - build(wip): add scripts to generate list of custom errors/events and functions

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 3 comments

#550 - wip: Add some patches to PR #542

Pull Request - State: closed - Opened by richtera over 1 year ago - 1 comment

#550 - wip: Add some patches to PR #542

Pull Request - State: closed - Opened by richtera over 1 year ago - 1 comment

#549 - fix: Add vite build and ts-gen hardhat task

Pull Request - State: closed - Opened by richtera over 1 year ago - 3 comments

#549 - fix: Add vite build and ts-gen hardhat task

Pull Request - State: closed - Opened by richtera over 1 year ago - 3 comments

#548 - refactor: Refactor LSP16UniversalFactory naming and natspec

Pull Request - State: open - Opened by YamenMerhi over 1 year ago - 2 comments

#548 - refactor: Refactor LSP16UniversalFactory naming and natspec

Pull Request - State: open - Opened by YamenMerhi over 1 year ago - 2 comments

#547 - ci: change name of iOS / Android artifacts to `LSPSmartContracts` / `lspsmartcontracts`

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#546 - test: reduce foundry `runs` from 50k to 10k

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 1 comment

#546 - test: reduce foundry `runs` from 50k to 10k

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 1 comment

#545 - ci: fix android java wrapper generation with web3j

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#545 - ci: fix android java wrapper generation with web3j

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#544 - test: replace `beforeEach` -> `before` hooks in LSP8

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#544 - test: replace `beforeEach` -> `before` hooks in LSP8

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#543 - chore: prepare patch release 0.8.2

Pull Request - State: closed - Opened by richtera over 1 year ago

#543 - chore: prepare patch release 0.8.2

Pull Request - State: closed - Opened by richtera over 1 year ago

#542 - refactor!: create a script for generating errors and events

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#542 - refactor!: create a script for generating errors and events

Pull Request - State: closed - Opened by b00ste over 1 year ago - 2 comments

#541 - fix: export assets for 0.8.1 (patch)

Pull Request - State: closed - Opened by richtera over 1 year ago

#541 - fix: export assets for 0.8.1 (patch)

Pull Request - State: closed - Opened by richtera over 1 year ago

#540 - test: add benchmark tests for EOA x UniversalProfile

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#540 - test: add benchmark tests for EOA x UniversalProfile

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#539 - refactor: rename GasLib to GasUtils and remove uncheckedIncrement from LSP2

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#539 - refactor: rename GasLib to GasUtils and remove uncheckedIncrement from LSP2

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#538 - chore: add `generateMappingWithGroupingKey(bytes6,bytes4,bytes20)` to LSP2Utils

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#538 - chore: add `generateMappingWithGroupingKey(bytes6,bytes4,bytes20)` to LSP2Utils

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#537 - style: add issue templates

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 1 comment

#537 - style: add issue templates

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 1 comment

#536 - ci: fix MythX CI to run against new contracts and solc version 0.8.15

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#536 - ci: fix MythX CI to run against new contracts and solc version 0.8.15

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#535 - style: add Pull Request template

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 1 comment

#535 - style: add Pull Request template

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 1 comment

#534 - test: replace `beforeEach` by `before` hooks across LSP test suites

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#534 - test: replace `beforeEach` by `before` hooks across LSP test suites

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 1 comment

#533 - test: replace `beforeEach` hooks by `before` across LSP test suites

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#533 - test: replace `beforeEach` hooks by `before` across LSP test suites

Pull Request - State: closed - Opened by CJ42 over 1 year ago

#532 - docs: add natspec and code comments

Pull Request - State: closed - Opened by YamenMerhi over 1 year ago - 2 comments

#531 - fix: fix Panic error out-of-bounds index in KeyManager when decoding + checking data keys / values arrays of different length

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments
Labels: bug

#531 - fix: fix Panic error out-of-bounds index in KeyManager when decoding + checking data keys / values arrays of different length

Pull Request - State: closed - Opened by CJ42 over 1 year ago - 2 comments
Labels: bug

#530 - test: separate LSP6 tests with proxy in their own test suite

Pull Request - State: closed - Opened by CJ42 over 1 year ago

GitHub / lukso-network/lsp-smart-contracts issues and pull requests