Ecosyste.ms: Issues
An open API service for providing issue and pull request metadata for open source projects.
GitHub / lilycoco/lilycoco.github.io issues and pull requests
#55 - Update libraries and fix error
Pull Request -
State: closed - Opened by lilycoco almost 4 years ago
#54 - [Technical improvement] Prettier and eslint
Issue -
State: open - Opened by lilycoco almost 5 years ago
#53 - Add Storybook
Issue -
State: open - Opened by lilycoco almost 5 years ago
#52 - Add database
Issue -
State: open - Opened by lilycoco almost 5 years ago
#51 - Add backend
Issue -
State: open - Opened by lilycoco almost 5 years ago
#50 - add content
Pull Request -
State: closed - Opened by lilycoco almost 5 years ago
#49 - update next
Pull Request -
State: closed - Opened by lilycoco almost 5 years ago
#48 - Bump next from 8.1.0 to 9.3.3
Pull Request -
State: closed - Opened by dependabot[bot] almost 5 years ago
- 1 comment
Labels: dependencies
#47 - edit eslint rule
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#46 - Create Blog Page
Issue -
State: closed - Opened by lilycoco over 5 years ago
#45 - rename Interface
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#44 - refactoring
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#43 - any をなくす
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#42 - delete a board
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#41 - Issue#33
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#40 - remove any
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#39 - Boardをひとつにまとめる
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#38 - updateBaseBoard が分かりづらい
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#37 - Refactoring
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#36 - fix issue
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#35 - changeBoardがaddBlockToBoardの中で使われているけど、あまり名前から見たら筋が通らない
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#34 - deleteRow 具現が非常に危ないRender中なのにbaseBoardを直接いじっている。編集するのであればsetBaseBoardを使うべきで、あたいだけきめたかったら配列をコピってからやるべき
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#33 - 一部のStateは名前を見ても意味がわかりづらい。 1. axes 2. boardType 3. didDeleteRowBoard (Booleanのように使われているがBooleanではない) 4. deleteRow
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 2 comments
Labels: done
#32 - Randomで数字を選ぶ部分を関数として出せるかなと思う
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#31 - components/tetris/Game.tsxのinitialShapeとinitialColorが最初からいるのかがかなり疑問、最初は適当に0とかを入れておいて、ゲームを始めるときにRandomで値をとって計算した方が良いと思う
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#30 - pages/tetris.tsx FCで、PropsにInterfaceもいらない
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#29 - issue#15: fix useRef
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#28 - issue#13: reduce calculation
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#27 - issue#7: rename variables
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#26 - issue#9: combine useState
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#25 - issue#8: transform FC to JSX
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#24 - issue#11: rename function
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#23 - issue#10: rename functions
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#22 - issue#17: move styled components
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#21 - issue#5: move <Game> to component
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#20 - issue#6: add component folders
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#19 - issue#12: fix typo
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#18 - issue#18: transform children
Pull Request -
State: closed - Opened by lilycoco over 5 years ago
#17 - BoardWrapperStyleとBoardStyleの意味がわからない。Componentにはこういう名前つけない。Styled componentの例題を参考。Styledで作ったものは全部Componentである。Componentに入れること。
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#16 - children propは使わない <button>Clear</button>でいい
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#15 - intervalRef使い方が完全に間違っている。currentには自分が設定するものでも無いし、RenderingされたElementになるべきである。またGenericでTypeを渡す必要がある。
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#14 - Math.floor(Math.random() * 27)はそのComponentがRenderingされるときに毎回呼ばれます 自分たちがRandomの値が必要な時は新しいBlockを生成するときのみです 多分、その部分は毎回BoardがRenderingされるとき(Blockが動いた時など)に呼ばれるので無駄ですね。
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#13 - selectShape, selectColorが無駄に毎回計算されている。必要なのは一回だけなのにまたこれらの名前も良く無いinitialShapeとかだったらよかったかも、とりあえず、ゲームが始まってからRandomで計算して十分だと思う
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#12 - TictacSwichButton ->TictacSwitchButton?
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#11 - FlagとAssertionをはっきり区別すること。canDeleteRowはAssertion関数では無い
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#10 - handleRunClickみたいな名前より、toggleRunningみたいな名前にして、直接onClick={toggleRunning}に入れる。そうするとRenderされているJSXだけ見て何が起きるのかの予測が非常にしやすい
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#9 - 一部のStateを一つにまとめるxとy、currentColorとcurrentShapeなどはまとめていいかなと思う。
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#8 - FCは必ずJSXで書くこと。DrowBoard() -> <DrowBorad />
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#7 - DrowBoard?DrowGameOver? x? y? over? 変数の名前を見てもなんなのかが推測しづらい
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#6 - tetris関連、Tictac関連のComponentはそれぞれのフォルダーにまとめるcomponents/tetris, components/tictac
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#5 - pages/tetris.tsxのGame Componentも外に出す
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
Labels: done
#4 - addEventListener() で外部のstateの更新を反映させたい
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#3 - 外部 stateの更新をuseEffect()内に反映させたい
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#2 - ブロックが描画されない
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment
#1 - Not found hot-update.json
Issue -
State: closed - Opened by lilycoco over 5 years ago
- 1 comment