jamesmartin/inline_svg issues and pull requests

#162 - Drop webpacker support in favour of Shakapacker

Issue - State: open - Opened by tagliala 7 days ago

#161 - Drop Legacy Ruby and Rails compatibility

Issue - State: open - Opened by tagliala 8 days ago

#160 - Feature request: Add vite support

Issue - State: open - Opened by jamesst20 19 days ago - 4 comments

#159 - Run GitHub Actions on PRs

Pull Request - State: open - Opened by tagliala about 1 month ago - 2 comments

#158 - Add support to Shakapacker

Pull Request - State: open - Opened by tagliala about 1 month ago - 6 comments

#157 - Fix typos

Pull Request - State: open - Opened by tagliala about 1 month ago

#156 - Support Shakapacker 8

Issue - State: open - Opened by tagliala about 1 month ago - 2 comments

#155 - Change asset finder configuration

Pull Request - State: open - Opened by xymbol 8 months ago

#154 - Set asset finder from callable

Pull Request - State: open - Opened by xymbol 8 months ago - 4 comments

#153 - Specs not running on main

Issue - State: closed - Opened by trobrock 9 months ago - 2 comments

#152 - Add missing activesupport require

Pull Request - State: closed - Opened by xymbol 9 months ago - 1 comment

#151 - Propshaft detection is load order dependant

Issue - State: open - Opened by xymbol 9 months ago - 1 comment

#150 - fix: remove any whitespace from SVG tag output

Pull Request - State: closed - Opened by fredboyle 11 months ago

#149 - `inline_svg_tag` Adds extra space after output

Issue - State: closed - Opened by fredboyle 11 months ago - 2 comments

#147 - Why in documentation it is mentioned that support for Rails 7 is experimental?

Issue - State: closed - Opened by bunufi over 1 year ago - 2 comments

#146 - Test

Pull Request - State: closed - Opened by pcothenet over 1 year ago - 2 comments

#145 - NoMethodError with rails 7/propshaft

Issue - State: closed - Opened by nickcoyne over 1 year ago - 2 comments

#144 - Display from Active Storage

Issue - State: open - Opened by richjdsmith over 1 year ago - 5 comments

#143 - RuboCop: Fix redundant self

Pull Request - State: open - Opened by sunny almost 2 years ago

#142 - Add viewBox option

Pull Request - State: closed - Opened by sunny almost 2 years ago - 1 comment

#141 - Handling missing file when using static assets

Pull Request - State: closed - Opened by leighhalliday almost 2 years ago

#140 - Allow Propshaft assets to use fallbacks

Pull Request - State: closed - Opened by ohrite almost 2 years ago

#139 - Support arbitrary HTML Attributes

Issue - State: open - Opened by jherdman about 2 years ago

#138 - fix: if file isn't found then this would be nil

Pull Request - State: open - Opened by jnylen about 2 years ago - 1 comment

#137 - Require activesupport prior to core_ext/string

Pull Request - State: closed - Opened by mjankowski over 2 years ago

#136 - Add some documentation around configuring asset finders

Pull Request - State: open - Opened by mjankowski over 2 years ago - 5 comments

#135 - Bump version rubygems

Issue - State: closed - Opened by navidemad over 2 years ago - 1 comment

#134 - Add support for Propshaft

Pull Request - State: closed - Opened by martinzamuner over 2 years ago - 4 comments

#133 - Rails 7 support without asset pipeline

Issue - State: open - Opened by mjc-gh over 2 years ago - 3 comments

#132 - Intended use with sprockets + cssbundling-rails and jsbundling-rails?

Issue - State: closed - Opened by ivy over 2 years ago - 2 comments

#131 - Remove deprecation warning for inline_svg, as we intend to keep it in 2.0

Pull Request - State: closed - Opened by DanielJackson-Oslo over 2 years ago

#130 - Webpacker 6 support

Issue - State: closed - Opened by AlecRust almost 3 years ago - 3 comments
Labels: help wanted

#129 - Fix: correct asset path for webpacker 6 when using an asset host (2)

Pull Request - State: closed - Opened by tessi almost 3 years ago - 3 comments

#128 - Add support for vite_ruby

Pull Request - State: closed - Opened by Intrepidd about 3 years ago - 2 comments

#127 - Support for using CDN as the asset host

Issue - State: closed - Opened by tenshiAMD about 3 years ago - 2 comments

#126 - Ruby 3.0 timeout

Issue - State: closed - Opened by trobrock over 3 years ago - 1 comment

#125 - Fix: correct asset path for webpacker 6 when using an asset host

Pull Request - State: closed - Opened by Intrepidd over 3 years ago - 4 comments

#124 - Reduce repeated SVG size with <use> tag

Issue - State: open - Opened by ryanb over 3 years ago - 7 comments
Labels: enhancement, help wanted

#123 - Bump version for 1.7.2

Pull Request - State: closed - Opened by jamesmartin over 3 years ago

#122 - Request: 1.7.2 release

Issue - State: closed - Opened by davefp over 3 years ago - 1 comment

#121 - Add fallback option to README

Pull Request - State: closed - Opened by bartosjiri almost 4 years ago

#120 - removes slashes from Tempfile's name on WebpackAssetFinder

Pull Request - State: closed - Opened by marcelokanzaki about 4 years ago - 5 comments

#119 - Add support for viewBox svg field

Issue - State: closed - Opened by djsegal over 4 years ago - 4 comments

#118 - Improve CachedAssetFile

Pull Request - State: closed - Opened by stevendaniels over 4 years ago - 2 comments

#117 - Escape filename to avoid XSS from malicious input

Pull Request - State: closed - Opened by pbyrne over 4 years ago - 3 comments

#116 - Run integration tests on multiple Rails versions

Pull Request - State: closed - Opened by jamesmartin over 4 years ago - 1 comment

#115 - Create integration_test.yml

Pull Request - State: closed - Opened by jamesmartin over 4 years ago

#114 - Make helpers thread-safe

Pull Request - State: closed - Opened by kylefox over 4 years ago - 3 comments

#113 - Fix "EOFError error" when using webpack dev server over HTTPS

Pull Request - State: closed - Opened by kylefox over 4 years ago - 14 comments

#112 - ⚠️ Using both asset pipeline and webpacker is not thread safe

Issue - State: closed - Opened by kylefox over 4 years ago - 6 comments

#111 - Modify WebpackAssetFinder to serve file from dev server if one is running (with fixes)

Pull Request - State: closed - Opened by connorshea over 4 years ago - 4 comments

#110 - SVG file not found

Issue - State: open - Opened by george-norris-salesforce over 4 years ago - 13 comments
Labels: enhancement, help wanted

#109 - support implicit "media/images" for webpack inline_svg_pack_tag

Issue - State: open - Opened by felipefava over 4 years ago - 3 comments
Labels: enhancement, help wanted

#108 - Cached assets seems to take longer to load than when reading from file

Issue - State: closed - Opened by danfragoso over 4 years ago - 5 comments

#107 - Caching assets at boot time doesn't map asset names to fingerprinted filenames

Issue - State: open - Opened by agrobbin over 4 years ago - 3 comments
Labels: help wanted

#106 - Fix bad reference to Sprockets::Asset.pathname

Pull Request - State: closed - Opened by subdigital over 4 years ago - 5 comments

#105 - Version 2.0

Issue - State: open - Opened by jamesmartin over 4 years ago - 3 comments

#104 - Feature request: add aria-label to <path>

Issue - State: open - Opened by rhymes over 4 years ago - 1 comment
Labels: enhancement, help wanted

#103 - Support both Sprockets and Webpacker

Pull Request - State: closed - Opened by kylefox over 4 years ago - 2 comments

#102 - Support both Sprockets and Webpacker?

Issue - State: closed - Opened by kylefox almost 5 years ago - 11 comments

#101 - Modify WebpackAssetFinder to serve file from dev server if one is running

Pull Request - State: closed - Opened by moxie almost 5 years ago - 7 comments

#100 - Added new method to check if path starts with media or add it

Pull Request - State: open - Opened by damjack almost 5 years ago - 3 comments

#99 - Automatically configure Webpacker

Issue - State: open - Opened by jamesmartin about 5 years ago

#98 - 1.5.0 and 1.5.1 can no longer find assets in production

Issue - State: closed - Opened by shepmaster about 5 years ago - 16 comments

#97 - Undefined method `find_asset`

Issue - State: closed - Opened by guillaumewrobel about 5 years ago - 9 comments

#96 - Support Webpacker

Pull Request - State: closed - Opened by jamesmartin about 5 years ago - 2 comments

#95 - Not working without sprockets

Issue - State: closed - Opened by askehansen about 5 years ago - 5 comments
Labels: enhancement, help wanted

#94 - Optionally raise an error when SVG file not found

Pull Request - State: closed - Opened by jamesmartin about 5 years ago

#93 - Feature request: Raise error if missing SVG Files

Issue - State: closed - Opened by elalemanyo about 5 years ago - 2 comments

#92 - inline_svg + angular-rails-templates + in RAILS_ENV=production rake assets:precompile

Issue - State: closed - Opened by leviwilson over 5 years ago - 2 comments

#91 - Webpacker

Issue - State: closed - Opened by richjdsmith over 5 years ago - 8 comments

#90 - Use the sprockets manifest for precompiled assets

Issue - State: closed - Opened by jamesmartin almost 6 years ago - 1 comment

#89 - `inline_svg` does not use sprockets manifest

Issue - State: closed - Opened by wjdhamilton almost 6 years ago - 6 comments

#88 - simple fix to ensure that the digests begins with a char

Pull Request - State: closed - Opened by endorfin almost 6 years ago - 2 comments

#87 - Accessibility: invalid digests for id aria-labelled-by

Issue - State: closed - Opened by endorfin almost 6 years ago - 1 comment

#86 - Feature Request: Include SVGO (or some optimizer) before inlining

Issue - State: closed - Opened by elliottregan about 6 years ago - 2 comments
Labels: wontfix

#85 - NoMethodError - undefined method `inline_svg`

Issue - State: closed - Opened by JonaMX about 6 years ago - 4 comments

#84 - Improve performance when no transformations are necessary

Pull Request - State: closed - Opened by kylerippey about 6 years ago - 4 comments

#83 - [CI] Test against Ruby 2.5

Pull Request - State: closed - Opened by nicolasleger over 6 years ago - 1 comment

#82 - SVG not found

Issue - State: closed - Opened by amnesia7 over 6 years ago - 2 comments

#81 - Missing array in cached_asset_file.rb

Issue - State: closed - Opened by LeahArmstrong over 6 years ago - 4 comments

#80 - Adds missing array to cached_asset_file.rb

Pull Request - State: closed - Opened by LeahArmstrong over 6 years ago

#79 - Add `aria_hidden` option

Pull Request - State: closed - Opened by seanpdoyle over 6 years ago

#78 - Add the aria-hidden attribute to the root SVG element

Pull Request - State: closed - Opened by jamesmartin over 6 years ago

#77 - Improve likelihood of Aria IDs being unique

Pull Request - State: closed - Opened by jamesmartin over 6 years ago

#76 - Aria SVGs with identical titles create IDs with identical values

Issue - State: closed - Opened by sonniesedge over 6 years ago - 4 comments
Labels: bug

#75 - Add rubocop

Pull Request - State: closed - Opened by meowsus over 6 years ago - 6 comments

#74 - Abstract svg read & placeholder logic

Pull Request - State: closed - Opened by meowsus over 6 years ago - 1 comment

#73 - Fallback SVG

Issue - State: closed - Opened by meowsus over 6 years ago - 2 comments
Labels: question

#72 - Feature request: `aria-hidden`

Issue - State: closed - Opened by tysongach over 6 years ago - 9 comments
Labels: enhancement, help wanted, Hacktoberfest

#71 - Add style attribute

Pull Request - State: closed - Opened by sunny almost 7 years ago - 1 comment

#70 - Support absolute file paths

Issue - State: closed - Opened by elstgav almost 7 years ago - 3 comments
Labels: enhancement

#69 - Handle non-ASCII characters in titles

Pull Request - State: closed - Opened by calleluks almost 7 years ago - 2 comments
Labels: bug

#68 - Can you pass links to your inline_svg helper method?

Issue - State: closed - Opened by RailsCod3rFuture almost 7 years ago - 2 comments

#67 - Add configurable empty SVG class

Pull Request - State: closed - Opened by meowsus about 7 years ago - 8 comments

#66 - Add a class to empty SVG element when image is not found

Pull Request - State: closed - Opened by meowsus about 7 years ago - 3 comments
Labels: enhancement

#65 - Handle documents that do not contain SVG root elements

Pull Request - State: closed - Opened by jamesmartin about 7 years ago

#64 - Rank matched cached assets

Pull Request - State: closed - Opened by jamesmartin about 7 years ago

#63 - CachedAssetFile chooses the incorrect file

Issue - State: closed - Opened by jamesmartin about 7 years ago - 1 comment
Labels: bug

#62 - Cache asset files at boot-time

Pull Request - State: closed - Opened by jamesmartin about 7 years ago

GitHub / jamesmartin/inline_svg issues and pull requests