idotavorslab/PYANO issues and pull requests

#100 - Shortcuts stop working when popups show (needs alt+tab)

Issue - State: open - Opened by giladbarnea about 5 years ago

#99 - "Dump everything send to gilad" button

Issue - State: open - Opened by idotavorslab over 5 years ago
Labels: mid

#98 - Backup experiments data on app launch

Issue - State: open - Opened by idotavorslab over 5 years ago
Labels: mid

#97 - Stable

Pull Request - State: closed - Opened by idotavorslab over 5 years ago

#96 - samples bitrate to 96

Pull Request - State: closed - Opened by idotavorslab over 5 years ago

#95 - output folder of a session should be named after config, not after truth

Issue - State: open - Opened by ShacharGal over 5 years ago
Labels: high

#94 - skip button in exam mode breaks stuff

Issue - State: open - Opened by ShacharGal over 5 years ago

#93 - [🎹 Inside Test] Pressing Ready from NewTest changes base txt file

Issue - State: open - Opened by idotavorslab over 5 years ago

#92 - [✨New Test] Loading a new truth saves previous config values into new ones (doesn't check if notes match etc)

Issue - State: open - Opened by idotavorslab over 5 years ago

#91 - Merge Unstable into Stable: fixed numbers in english > 10, volume diff, cursor hide. Maybe fixed: velocities = 1 (animation lag)

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#90 - [✨New Test] Remove all auto-save behavior and prompt user to save on change

Issue - State: open - Opened by giladbarnea over 5 years ago
Labels: high

#89 - Unstable

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#88 - subject name in config should stay "null"

Issue - State: open - Opened by ShacharGal over 5 years ago - 1 comment
Labels: qa-needed

#87 - Should disallow subject names / dirs of empty strings

Issue - State: open - Opened by giladbarnea over 5 years ago
Labels: mid

#86 - [🎹 Inside Test] "I'm done playing" button appears 1s~ before newWriteStream is called on labs laptop

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: high

#85 - [🎹 Inside Test] Rhythm: if a (should be) chord is played sloppily (ie one note after the other), the whole chord should be colored blue

Issue - State: open - Opened by idotavorslab over 5 years ago - 1 comment
Labels: mid

#84 - Change "save" functionality so any future changes / saves are also written to target config

Issue - State: closed - Opened by giladbarnea over 5 years ago

#83 - export information

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#82 - change messages in exam mode

Issue - State: closed - Opened by ShacharGal over 5 years ago

#81 - drop "whole piece" animation in exam mode

Issue - State: closed - Opened by ShacharGal over 5 years ago

#80 - adding exam\training to config

Issue - State: closed - Opened by ShacharGal over 5 years ago

#79 - change "test" to "training"

Issue - State: open - Opened by ShacharGal over 5 years ago
Labels: mid

#78 - load truth along with config

Issue - State: closed - Opened by ShacharGal over 5 years ago

#77 - fuck "start experiment" nav item

Issue - State: closed - Opened by giladbarnea over 5 years ago

#76 - Verify active power plan

Issue - State: open - Opened by idotavorslab over 5 years ago

#75 - Exam

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#74 - Exam

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#73 - colour tone of rhythm errors

Issue - State: open - Opened by ShacharGal over 5 years ago

#72 - simultaneousness errors should count as rhythm, not accuracy

Issue - State: closed - Opened by ShacharGal over 5 years ago - 2 comments
Labels: very high

#71 - [✨New Test] Values in drop lists don't update when a new Truth is selected

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: mid

#70 - [✨New Test] Current subject in cfg is sometimes set to null when loading new cfg file

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: mid

#69 - Record prelude of bach (20~s)

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: very high

#68 - [🎹 Inside Test] Output check_done_trial.py data to file

Issue - State: closed - Opened by giladbarnea over 5 years ago - 1 comment
Labels: very high

#67 - [🎹 Inside Test] Find a better text than "Oi vei!"

Issue - State: closed - Opened by giladbarnea over 5 years ago

#66 - [🎹 Inside Test] Remove periods at end of sentences

Issue - State: closed - Opened by giladbarnea over 5 years ago

#65 - [🎹 Inside Test] adding a "skip animation" option

Issue - State: closed - Opened by ShacharGal over 5 years ago
Labels: high

#64 - [🎹 Inside Test] Pre-trial and Post-trial demo flow changes

Issue - State: closed - Opened by ShacharGal over 5 years ago - 5 comments
Labels: very high

#63 - Add "Exam" page (in contrast with "New Test")

Issue - State: closed - Opened by ShacharGal over 5 years ago - 3 comments
Labels: very high

#62 - [🎹 Inside Test] Making tempo error text more encouraging

Issue - State: closed - Opened by ShacharGal over 5 years ago - 2 comments
Labels: discuss

#61 - [🎹 Inside Test] Post-trial, accuracy error-animation in tempo should play at level tempo (not slower), and color code by mistake kind

Issue - State: closed - Opened by ShacharGal over 5 years ago - 3 comments

#60 - Tempo testing feels too strict

Issue - State: closed - Opened by ShacharGal over 5 years ago - 3 comments
Labels: discuss

#59 - [🎹 Inside Test] Better distinction between tempo/accuracy trials for user

Issue - State: open - Opened by ShacharGal over 5 years ago - 2 comments
Labels: discuss

#58 - [🎹 Inside Test] volume differences between video and animation

Issue - State: closed - Opened by ShacharGal over 5 years ago
Labels: high

#57 - [🎹 Inside Test] Post trial animation should only happen if there are accuracy and/or rhythm mistakes. Won't happen if only tempo mistakes.

Issue - State: closed - Opened by ShacharGal over 5 years ago - 3 comments
Labels: high

#56 - Newflow

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#55 - Newflow

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#54 - Code restruct

Pull Request - State: closed - Opened by giladbarnea over 5 years ago

#53 - [🎹 Inside Test] Pressing "done" when a note is still pressed crashes app

Issue - State: open - Opened by ShacharGal over 5 years ago
Labels: low, Bug :beetle:

#52 - [🎹 Inside Test] Error slow playback should slow down only mistake notes

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#51 - [🔴 Record] Add an option to just play a video

Issue - State: open - Opened by ShacharGal over 5 years ago - 3 comments

#50 - slowing down tempo

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#49 - [🎹 Inside Test] Numbers in english are one behind starting from 10

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment
Labels: mid

#48 - telling windows not to be annoying

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#47 - allow choosing notes in tempo

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#46 - tempo flow

Issue - State: closed - Opened by ShacharGal over 5 years ago

#45 - Each truth should have a different folder

Issue - State: open - Opened by giladbarnea over 5 years ago
Labels: mid

#44 - [🔴 Record] Allow overwrite of existing truths

Issue - State: open - Opened by giladbarnea over 5 years ago

#43 - "Full" full screen

Issue - State: closed - Opened by giladbarnea over 5 years ago - 1 comment
Labels: explanation-needed?

#42 - [🎹 Inside Test] Cursor should not be visible

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: high

#41 - [✨New Test] A newly-added level should automatically focus the number of notes that's 1+previous level

Issue - State: closed - Opened by giladbarnea over 5 years ago

#40 - [✨New Test] Shouldn't be able to specify more notes than available in truth

Issue - State: closed - Opened by giladbarnea over 5 years ago

#39 - [🎹 Inside Test] Piano keyboard animation fades out with artifacts

Issue - State: open - Opened by giladbarnea over 5 years ago
Labels: Bug :beetle:

#38 - [🎹 Inside Test] Sometimes post trial mistakes animation only shows first note but doesn't audibly play it

Issue - State: open - Opened by giladbarnea over 5 years ago - 4 comments
Labels: very high, Bug :beetle:

#37 - [🔧 File Tools] Handle _off.txt or _on.txt drop

Issue - State: closed - Opened by giladbarnea over 5 years ago

#36 - [✨New Test] Fix DragDrop and StoreFns.setNewTruthFile string/Truth issues

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#35 - [🎹 Inside Test] Tempo, "lets show you those 0 notes you got right again"

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#34 - [🎹 Inside Test] Tempo + Animation, shouldn't play whole truth animation then again before first trial

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#33 - Verify ffmpeg installation

Issue - State: open - Opened by giladbarnea over 5 years ago

#32 - [🎹 Inside Test] Implement note-off logic

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: very high, release-necessary

#31 - [🎹 Inside Test] There should be an "exit-test" button

Issue - State: closed - Opened by idotavorslab over 5 years ago - 2 comments

#30 - [🎹 Inside Test] Everything besides animation should be faded out when played

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#29 - [🎹 Inside Test] When tempo, big message shouldn't say "First Level", because there's only one level

Issue - State: closed - Opened by giladbarnea over 5 years ago - 1 comment

#28 - [✨New Test] Necessary file checks (also dynamic: video file on toggle etc)

Issue - State: open - Opened by giladbarnea over 5 years ago

#27 - [🔴 Record] Prevent scenario where user presses REC before piano samples have loaded

Issue - State: open - Opened by giladbarnea over 5 years ago

#26 - [🔴 Record] Should be able to handle edge case where nothing was recorded and user "stopped" recording

Issue - State: open - Opened by giladbarnea over 5 years ago

#25 - [🔴 Record] Option to delete a truth (deleting all related files in one click)

Issue - State: open - Opened by giladbarnea over 5 years ago

#24 - [🎹 Inside Test] Truth midi playback (animation) should "force legato" even if note was played staccato

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#23 - [🎹 Inside Test] First "whole" demo should be as long as the longest level, and not the whole piece

Issue - State: closed - Opened by ShacharGal over 5 years ago
Labels: release-necessary

#22 - Aesthetic notes by Ido

Issue - State: closed - Opened by giladbarnea over 5 years ago - 1 comment

#21 - [🎹 Inside Test] Flow prob: tempo mode shouldn't play whole truth video of "this level" since there's only one level. Otherwise there are too many demos

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: very high, release-necessary, qa-needed

#20 - "We'll show you what notes you got wrong" text is misleading

Issue - State: closed - Opened by giladbarnea over 5 years ago - 2 comments
Labels: release-necessary

#19 - [🎹 Inside Test] Trimming of video still messes up sometimes

Issue - State: closed - Opened by giladbarnea over 5 years ago - 1 comment
Labels: very high, release-necessary, qa-needed

#18 - [🎹 Inside Test] Playback of chords truncates all chord notes besides last one

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#17 - Animation playback has a weird sound accompanied to each note, only when 2hands

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: explanation-needed?

#16 - [🎹 Inside Test] Animation is still laggy

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: very high, release-necessary, qa-needed

#15 - InsideTest, some verbal message between vid/anim at beginning of level

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary

#14 - [✨New Test] Load config visually

Issue - State: closed - Opened by giladbarnea over 5 years ago - 2 comments

#13 - [🎹 Inside Test] Make it work full screen

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary, qa-needed

#12 - Performance: too much time until video is played (audio as well)

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: qa-needed

#11 - Add crop video functionality and make sure it plays well

Issue - State: closed - Opened by giladbarnea over 5 years ago - 2 comments

#10 - [🎹 Inside Test] Video element should sit well in page

Issue - State: closed - Opened by giladbarnea over 5 years ago
Labels: release-necessary, qa-needed

#9 - Should catch any bad config values errors and reset config file

Issue - State: closed - Opened by idotavorslab over 5 years ago

#8 - Config - silence len should not default to 2 (default to 0)

Issue - State: closed - Opened by idotavorslab over 5 years ago

#7 - messages fade-out a bit slow

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#6 - Correct accuracy, but "too many notes" isn't acknowledged

Issue - State: closed - Opened by ShacharGal over 5 years ago - 1 comment

#5 - No way to "remove level" after adding

Issue - State: closed - Opened by idotavorslab over 5 years ago - 3 comments
Labels: very high

#4 - What do I do if I don't want DevTools opening at the side?

Issue - State: closed - Opened by idotavorslab over 5 years ago - 4 comments

#3 - When whole truth is first played (midi), first note isn't heard

Issue - State: closed - Opened by idotavorslab over 5 years ago - 1 comment
Labels: very high

#2 - Record page doesn't show / doesn't let me play all files, what gives?

Issue - State: closed - Opened by idotavorslab over 5 years ago - 3 comments

#1 - [✨New Test] Pressing load config directs to "src" and not config folder

Issue - State: closed - Opened by idotavorslab over 5 years ago - 1 comment

GitHub / idotavorslab/PYANO issues and pull requests