guardian/commercial issues and pull requests

#1159 - Remove liveblog client-side ad insertion on page load logic

Pull Request - State: closed - Opened by domlander 12 months ago - 1 comment

#1158 - Bump @types/node from 20.8.0 to 20.10.0

Pull Request - State: closed - Opened by dependabot[bot] 12 months ago - 2 comments
Labels: dependencies, javascript

#1157 - Created AB test and additional sizes for MPU when no epic

Pull Request - State: closed - Opened by deedeeh 12 months ago - 6 comments

#1156 - Upgrade Prebid to v8.24.0

Pull Request - State: closed - Opened by Jakeii 12 months ago - 2 comments
Labels: [beta] @guardian/commercial

#1155 - Enable inserting new inline ad slots when new blocks are created on liveblogs

Pull Request - State: closed - Opened by domlander 12 months ago - 5 comments
Labels: [beta] @guardian/commercial

#1154 - Fix Playwright for PageSkin in small screens tests

Pull Request - State: closed - Opened by deedeeh 12 months ago - 1 comment

#1153 - Exclude US locale from ads in merch behaviour

Pull Request - State: closed - Opened by SiAdcock 12 months ago - 3 comments
Labels: Do not merge

#1152 - Move `src/lib/*` to `src`

Pull Request - State: closed - Opened by arelra 12 months ago - 1 comment

#1151 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] 12 months ago

#1150 - Change order of adding ad centering/rendered classes

Pull Request - State: closed - Opened by Jakeii 12 months ago - 1 comment

#1149 - Bump @types/node from 20.8.0 to 20.9.2

Pull Request - State: closed - Opened by dependabot[bot] 12 months ago - 2 comments
Labels: dependencies, javascript

#1148 - Bump actions/github-script from 6 to 7

Pull Request - State: closed - Opened by dependabot[bot] 12 months ago - 1 comment
Labels: dependencies, github_actions

#1147 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1146 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1145 - Unify centring slots in container to a single class

Pull Request - State: closed - Opened by Jakeii about 1 year ago - 3 comments
Labels: [beta] @guardian/commercial

#1144 - Remove ads-in-merch AB test

Pull Request - State: closed - Opened by SiAdcock about 1 year ago - 1 comment

#1143 - Add Changeset for new Index site id

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 1 comment

#1142 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1141 - add logic for feature swtich

Pull Request - State: closed - Opened by dskamiotis about 1 year ago - 2 comments
Labels: [beta] @guardian/commercial

#1140 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1139 - Bump @types/node from 20.8.0 to 20.9.0

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1138 - Add Index site id for `320x50` size ads

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 1 comment
Labels: wip 🥒

#1137 - Adds helper function to find smallest size for slot

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1136 - Remove fronts banner test

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1135 - New ad sizes for merchandising slots

Pull Request - State: closed - Opened by SiAdcock about 1 year ago - 2 comments

#1134 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1133 - Provide the full hash for prebid in dependencies

Pull Request - State: closed - Opened by sndrs about 1 year ago - 1 comment
Labels: dependencies

#1132 - Bump @types/node from 20.8.0 to 20.8.10

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1131 - Refactor: separate inline1 and inline2+ slot insertion into separate functions

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1130 - removed references to 'user-features' module booting commercial bu…

Pull Request - State: closed - Opened by dskamiotis about 1 year ago - 5 comments
Labels: [beta] @guardian/commercial

#1129 - Roll out eager Prebid for desktop

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 2 comments

#1128 - Added E2E tests for `fronts-banner` ads

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1127 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1126 - Update Prebid

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1125 - Bump @types/node from 20.8.0 to 20.8.9

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1124 - Bump actions/setup-node from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 3 comments
Labels: dependencies, github_actions

#1123 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1122 - Handle undefined testgroups

Pull Request - State: closed - Opened by arelra about 1 year ago - 1 comment

#1121 - Add Ozone testgroup to Ad slot

Pull Request - State: closed - Opened by deedeeh about 1 year ago - 3 comments

#1120 - Centre video element in video interscroller

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1119 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1118 - Unit tests for shouldLazyLoad

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1117 - bump consent-management-platform to v13.7.1 for babel traverse fix

Pull Request - State: closed - Opened by sookburt about 1 year ago - 2 comments

#1116 - Bump @types/node from 20.8.0 to 20.8.7

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1115 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1114 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1113 - Add class to fronts-banner container in postMessage

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1112 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1111 - Hide fronts-banner ads when collapsing slots

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1110 - Support defining fixtures locally in E2E tests

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 1 comment

#1109 - Custom Event filler should not try to fill slots that are already filled

Pull Request - State: closed - Opened by Jakeii about 1 year ago - 2 comments
Labels: [beta] @guardian/commercial

#1108 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1107 - Update Prebid to use updated version of babel/core

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1106 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1105 - Bump @babel/traverse from 7.22.11 to 7.23.2

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 1 comment
Labels: dependencies, javascript

#1104 - Bump prebid.js to fix @babel/traverse vulnerability

Pull Request - State: closed - Opened by SiAdcock about 1 year ago - 1 comment

#1103 - Bump @types/node from 20.8.0 to 20.8.6

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1102 - Bump tough-cookie from 4.1.2 to 4.1.3

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1101 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1100 - Make eager prebid a zero percent test

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1099 - Fix liveblog Playwright tests

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 2 comments

#1098 - Delete Cypress

Pull Request - State: closed - Opened by arelra about 1 year ago - 1 comment

#1097 - Bump @types/node from 20.8.0 to 20.8.3

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1096 - Skip failing playwright test

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1095 - Add testgroup to Ozone targeting

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1094 - Playwright fixes: consent and article inline tests

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1093 - bump ophan-tracker-js

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1092 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1091 - Updated @guardian/consent-management-platform to 13.7.0

Pull Request - State: closed - Opened by akinsola-guardian about 1 year ago - 1 comment

#1090 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1089 - Bump @types/node from 20.8.0 to 20.8.2

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1088 - Enable noUncheckedIndexedAccess

Pull Request - State: closed - Opened by Jakeii about 1 year ago - 1 comment

#1087 - Catch errors from Okta

Pull Request - State: closed - Opened by georgeblahblah about 1 year ago - 1 comment

#1086 - Dependabot updates

Pull Request - State: closed - Opened by domlander about 1 year ago - 2 comments
Labels: [beta] @guardian/commercial

#1085 - Bump @types/node from 18.15.0 to 20.8.0

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1084 - Bump type-fest from 2.19.0 to 4.3.3

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1083 - Fix remaining noUncheckedIndexedAccess errors

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1082 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1081 - fix more noUncheckedIndexedAccess

Pull Request - State: closed - Opened by Jakeii about 1 year ago - 1 comment

#1080 - Use a `Map` to track adverts on the page

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 3 comments

#1079 - Add video option to interscroller

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 4 comments
Labels: [beta] @guardian/commercial

#1078 - Add `fullwidth` messenger message

Pull Request - State: closed - Opened by Jakeii about 1 year ago - 2 comments
Labels: [beta] @guardian/commercial

#1077 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1076 - Tests can define their own fixtures

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 2 comments
Labels: wip 🥒

#1075 - fix `noUncheckedIndexedAccess` from dfp directory

Pull Request - State: closed - Opened by dskamiotis about 1 year ago - 1 comment

#1074 - Stop recording Cypress videos in CI

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 1 comment

#1073 - Bump @types/node from 18.15.0 to 20.6.5

Pull Request - State: closed - Opened by dependabot[bot] about 1 year ago - 2 comments
Labels: dependencies, javascript

#1072 - Fix noUncheckedIndexedAccess errors for messenger files

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1071 - Various `noUncheckedIndexedAccess` fixes

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 1 comment

#1070 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1069 - Unify methods to fill advert slots

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 4 comments

#1068 - Remove reference to simpleReach

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1067 - remove logic related to expiry-ad-free-cookie and its switch

Pull Request - State: closed - Opened by dskamiotis about 1 year ago - 3 comments
Labels: [beta] @guardian/commercial

#1066 - Version Packages

Pull Request - State: closed - Opened by github-actions[bot] about 1 year ago

#1065 - Prevent overlap of labs banner and inline2+ ads

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1064 - Fix noUncheckedIndexedAccess errors for files in the header bidding folder

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

#1063 - fix noUncheckedIndexAccess errors in `ab*.ts` files

Pull Request - State: closed - Opened by Jakeii about 1 year ago - 1 comment

#1062 - Fix unchecked indexed access errors in `spacefinder.ts`

Pull Request - State: closed - Opened by chrislomaxjones about 1 year ago - 1 comment

#1061 - Remove liveblog-right slot

Pull Request - State: closed - Opened by domlander about 1 year ago - 1 comment

#1060 - Fix some noUncheckedIndexedAccess rule errors

Pull Request - State: closed - Opened by emma-imber about 1 year ago - 1 comment

GitHub / guardian/commercial issues and pull requests