google/guice issues and pull requests

#1740 - Bump last stable release to 7.0.0, update README to point to 6.0.0 & 7.0.0 as the last releases, update the 6.0.0 & 7.0.0 release pages.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1739 - Make error_prone_annotations dependency optional

Pull Request - State: closed - Opened by HannesWell over 1 year ago - 4 comments

#1738 - Internal change.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1737 - Improve MissingImplementationError to lazily calculate suggestions and standardize its output.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1736 - Use linked bindings for MapBinder/Multibinder/OptionalBinder aliases, instead of linking to the same internal factory implementation. (Reusing the internal factory results in some quirks that we want to avoid.)

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1735 - Internal change

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1734 - Avoid re-initializing factories that are already initialized. This is necessary because we share the internal factory implementation, which leads to initialize(..) being called multiple times. There are other consequences/quirks of this, but re-initialization is the worst of it.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1733 - Change the way we reference what 6.0 supports in the README, so it doesn't get transformed into jakarta.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1730 - Prepare for the Guice 6.0 & 7.0 releases. This change does the following:

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago - 1 comment

#1729 - Changed behaviour in Guice 7

Issue - State: closed - Opened by cdietrich over 1 year ago - 4 comments

#1728 - Rework sun.misc.Unsafe usages so that we directly refer to sun.misc.Unsafe, and call getObject on it natively instead of through reflection. (Take 2, after exempting its usages internally.)

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1727 - Breaks some conformance around sun.misc.Unsafe usage.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1726 - Remove redundant references to javax.{inject,persistence,servlet} and replace the rest with their jakarta variants.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1725 - Expose _something_ from private modules used in tests where the test is validating that the parent can't re-bind something from the private module. If nothing is exposed, the child/private injector can otherwise be immediately GC'd (which then allows the parent to have the binding). (Note that there are other ways the child/private module could be captured: such as a Provider or its Injector being captured into a longer-lived Thread... but this is the simplest way to do it). This is happening with some regularity on the Github Actions tests, making the tests a bit flaky.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1724 - Improve the error message if an EntityManager is provisioned before a unit if work is started, to help users transition to the new default that requires an explicit work open (or the legacy option set).

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1723 - Some prefactorings that will make it easier to add transformations that strip javax and only use the jakarta variants.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1722 - Rework sun.misc.Unsafe usages so that we directly refer to sun.misc.Unsafe, and call getObject on it natively instead of through reflection.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1721 - Introduce a new type of provider with access to the injection point

Pull Request - State: closed - Opened by kashike over 1 year ago - 4 comments

#1720 - Fix a few more places where we should check jakarta variants: DaggerMethodScanner scopes and BytecodeGenTest.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1719 - Use Unsafe API in more correct way

Pull Request - State: closed - Opened by alsemenov over 1 year ago - 5 comments

#1718 - Optimize the way we skip sources of core Guice classes. Instead of building new binders by calling skipSources on-demand, we just skip all the expected sources by default. This significantly reduces some memory pressure when creating injectors (which was otherwise causing issues with the forthcoming CL to additionally bind jakarta Provider variants for MapBinder/Multibinder/OptionalBinder).

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1717 - Rewrite jakarta singleton -> c.g.i Singleton for the SPI too.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1716 - Implement `and` and `or` in `Matcher` directly

Pull Request - State: closed - Opened by kashike over 1 year ago - 2 comments

#1715 - Bind the Provider from Jakarta when creating bindings with a Multibinder

Pull Request - State: closed - Opened by kashike over 1 year ago - 2 comments

#1714 - Migrate tests to JUnit 5

Pull Request - State: closed - Opened by kashike over 1 year ago - 1 comment

#1713 - Add a couple more missing @since tags.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1712 - Update @since vNext tags to @since 6.0

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1711 - Add support for jakarta.inject to core Guice.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1710 - Test auto-import of PRs.

Pull Request - State: closed - Opened by sameb over 1 year ago

#1709 - Don't immediately lookup the linked binding associated with @ImplementedBy. Instead, defer it like a normal bind(X.class).to(Y.class) does. This ensures that later bindings of Y are used.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1708 - Completely remove OSGi Import-Package 'javax.annotation'

Pull Request - State: closed - Opened by HannesWell over 1 year ago - 4 comments

#1707 - java.lang.ClassCastException: class com.google.inject.servlet.GuiceFilter cannot be cast to class jakarta.servlet.Filter (com.google.inject.servlet.GuiceFilter is in unnamed module of loader org.apache.catalina.loader.ParallelWebappClassLoader @e383572; jakarta.servlet.Filter is in unnamed module of loader java.net.URLClassLoader @2ef1e4fa)

Issue - State: closed - Opened by Shubhamhack7 over 1 year ago - 1 comment

#1706 - Don't automatically create an EntityManager outside of a UnitOfWork, because it leads to leaks. Fixes #739, fixes #997, fixes #730, fixes #985, fixes #959, fixes #731. This also adds an optional Options to the JpaPersistModule constructor, if users wish to use the legacy behavior. This is a breaking change, but to a better default value. Users who want to keep the dangerous form can opt back in with the options.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1705 - Don't wrap methods declared by Object in transactions. Fixes #958, fixes #788.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1704 - Recognize scoping annotations on concrete types also annotated with @ProvidedBy when using the @ProvidedBy as the provider.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1703 - Make requestInjection with an explicit type actually use the type. Fixes #1071.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1702 - Bump some plugin versions. Fixes #1026

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1701 - Set correct bundle version of fragment host. Fixes #1050 & fixes #1049. Much thanks to @kenwenzel and @mcculls for their help figuring out the right incantation for this.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1700 - accomodate manually initiated rollbacks. Fixes #1137 & fixes #1136.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1699 - Fix a number of Javadoc typos. Fixes #1078

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1698 - where are the installation instructions?

Issue - State: closed - Opened by xdavidliu over 1 year ago - 4 comments

#1695 - Mark JSR305 dependency as optional as it's not required at runtime (you only need it if you want to perform null analysis on the code). Fixes #1172

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1690 - Automated visibility attribute cleanup.

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago

#1689 - Add a utility class for checking if Guice has enhanced a class (and returning the unenhanced version).

Pull Request - State: closed - Opened by copybara-service[bot] over 1 year ago - 2 comments

#1679 - Feature Request: MicroProfile-config integration: Allow injecting annotations with jakarta.inject.Qualifier

Issue - State: closed - Opened by scr-oath over 1 year ago - 13 comments

#1672 - HiddenClassDefiner incorrectly assumes Unsafe.staticFieldBase(Field) returns a real Object

Issue - State: closed - Opened by breun over 1 year ago - 8 comments

#1670 - Annotations @Provides and @Singleton do not work together

Issue - State: open - Opened by groov1kk over 1 year ago - 3 comments

#1667 - InternalProvisionException.errorInUserCode discards important context about user errors

Issue - State: open - Opened by michkot over 1 year ago - 1 comment

#1666 - enable @Inject for records

Issue - State: closed - Opened by axaluss over 1 year ago - 4 comments

#1650 - Fix of #700

Pull Request - State: closed - Opened by nineninesevenfour almost 2 years ago - 2 comments

#1644 - Please document gpg keys to verify the dependencies

Issue - State: open - Opened by yeikel about 2 years ago - 1 comment

#1642 - Update Google Guava to 31.1-jre

Issue - State: open - Opened by selundqma about 2 years ago - 4 comments

#1637 - Support for JPA 3.0 (jakarta.persistence)

Issue - State: closed - Opened by nikosmoum over 2 years ago - 2 comments

#1630 - Add JEE (jakarta.inject) support to Guice

Pull Request - State: closed - Opened by hgschmie over 2 years ago - 14 comments

#1618 - 5.0.1 gradle Build complains about missing no-aop jar?

Issue - State: open - Opened by romdhann over 2 years ago - 2 comments

#1553 - Add creation of jar with shaded guava and asm.

Pull Request - State: closed - Opened by morgwai almost 3 years ago - 6 comments

#1552 - Problem with singletons instantiation for child injectors

Issue - State: open - Opened by deinlandel almost 3 years ago

#1513 - Improve Kotlin support documentation

Issue - State: open - Opened by vigneshtdev over 3 years ago - 4 comments

#1490 - Support for jakarta annotations

Issue - State: closed - Opened by hejcz over 3 years ago - 17 comments

#1383 - jakarta.inject support

Issue - State: closed - Opened by cogman about 4 years ago - 58 comments

#1347 - Actually call default methods in AssistedInject factories

Pull Request - State: closed - Opened by ogregoire over 4 years ago - 2 comments
Labels: cla: yes

#1340 - Add a helper method to judge whether a given instance has been enhanced

Pull Request - State: closed - Opened by ShaneXiangH over 4 years ago - 3 comments
Labels: cla: yes

#1319 - Fix bug (#251)

Pull Request - State: closed - Opened by birdmanmandbir over 4 years ago
Labels: cla: yes

#1279 - Include meaningful diagnostics when getAtInject fails due to linkage errors

Pull Request - State: closed - Opened by jglick almost 5 years ago - 9 comments
Labels: cla: yes

#1186 - IllegalStateException instead of understandable error message like "No implementation for Abstract was bound"

Issue - State: closed - Opened by cobexer over 6 years ago - 11 comments

#1177 - Expose and/or matchers

Issue - State: closed - Opened by kashike over 6 years ago - 4 comments

#1173 - Fix minor OSGi metadata issues caused by upgrade to bundleplugin 3.5.0

Pull Request - State: closed - Opened by mcculls over 6 years ago
Labels: cla: yes

#1172 - Mark JSR305 dependency as optional for throwingproviders

Pull Request - State: closed - Opened by mcculls over 6 years ago
Labels: cla: yes

#1137 - accomodate manually initiated rollbacks

Pull Request - State: closed - Opened by Vogel612 almost 7 years ago - 3 comments
Labels: cla: yes

#1136 - JpaLocalTxnInterceptor incorrectly assumes that @Transactional methods never handle exceptions

Issue - State: closed - Opened by Vogel612 almost 7 years ago - 1 comment

#1132 - Add restart UnitOfWork by a single operation

Pull Request - State: closed - Opened by zubaidullo almost 7 years ago - 2 comments
Labels: cla: no

#1131 - Applying FUNC transformation using Rascal

Pull Request - State: closed - Opened by jmarcelonunes about 7 years ago - 3 comments
Labels: cla: no

#1130 - #1128 just-in-time instantiation through SPI

Pull Request - State: closed - Opened by pshirshov about 7 years ago - 13 comments
Labels: cla: yes

#1122 - Added posibility to limit errors logger to prevent OOM

Pull Request - State: closed - Opened by IgeNiaI about 7 years ago - 5 comments
Labels: cla: yes

#1121 - Lacking injection point information when using the deprecated DependenyChain replacement.

Issue - State: closed - Opened by Cybermaxke about 7 years ago - 9 comments

#1101 - Transferring Request Scope across multiple threads

Issue - State: open - Opened by ganeshjothikumar over 7 years ago - 5 comments

#1101 - Transferring Request Scope across multiple threads

Issue - State: open - Opened by ganeshjothikumar over 7 years ago - 5 comments

#1089 - Do not fail on circular constructor/setter dependency #690

Pull Request - State: closed - Opened by marcosdeveloper over 7 years ago - 1 comment
Labels: cla: yes

#1078 - Fix a number of Javadoc typos

Pull Request - State: closed - Opened by sebkur over 7 years ago - 1 comment
Labels: cla: yes

#1072 - Fix error propagation in SingleMethodInjector

Pull Request - State: closed - Opened by aadamowski over 7 years ago - 4 comments
Labels: cla: yes

#1071 - Make requestInjection with an explicit type actually use the type

Pull Request - State: closed - Opened by jedediah over 7 years ago
Labels: cla: yes

#1061 - Refactoring/examples refactoring

Pull Request - State: closed - Opened by AdamTomaja almost 8 years ago - 5 comments
Labels: cla: yes

#1058 - Missing argument for error added

Pull Request - State: closed - Opened by Yqwed almost 8 years ago - 4 comments
Labels: cla: yes

#1056 - Fix dead link to Google's java style guide.

Pull Request - State: closed - Opened by andrewthehan almost 8 years ago - 1 comment
Labels: cla: yes

#1050 - Set correct bundle version of fragment host.

Pull Request - State: closed - Opened by kenwenzel about 8 years ago - 12 comments
Labels: cla: yes

#1049 - [OSGi] Multibindings and AssistedInject JARs need version property for fragment host

Issue - State: closed - Opened by kenwenzel about 8 years ago

#1029 - Modules.override() does not work with @Provides methods

Issue - State: closed - Opened by pisarek about 8 years ago - 3 comments

#1029 - Modules.override() does not work with @Provides methods

Issue - State: closed - Opened by pisarek about 8 years ago - 3 comments

#1026 - Update plugin versions because of @threadSafe

Pull Request - State: closed - Opened by thomasmey about 8 years ago - 6 comments
Labels: cla: yes

#1025 - Make Gerrit work on IBM's WLP

Pull Request - State: closed - Opened by thomasmey over 8 years ago - 9 comments
Labels: cla: yes

#1023 - Added xml and vis.js graphing extensions.

Pull Request - State: closed - Opened by ksaric over 8 years ago - 4 comments
Labels: cla: yes

#1015 - Fix errornous value in issueManagement.system

Pull Request - State: closed - Opened by jamo over 8 years ago - 1 comment
Labels: cla: yes

#1014 - Use LinkedList to store Elements in InjectorShell

Pull Request - State: closed - Opened by biran0079 over 8 years ago - 7 comments
Labels: cla: yes

#997 - Check a system property before EntityManager injection outside work unit happens

Pull Request - State: closed - Opened by nuzayats over 8 years ago - 4 comments
Labels: cla: yes

#992 - Dependency version cleanup w/ Dependency Management

Pull Request - State: closed - Opened by jccarrillo over 8 years ago - 1 comment
Labels: cla: yes

#989 - A more usable BOM and a new Guice Platform BOM

Pull Request - State: closed - Opened by jccarrillo over 8 years ago - 9 comments
Labels: cla: yes

#987 - Fix Checkstyle violation: forbidding making public Logger

Pull Request - State: closed - Opened by yaziza over 8 years ago - 3 comments
Labels: cla: yes

#985 - Separated UnitOfWork and EntityManager

Pull Request - State: closed - Opened by jjantunen over 8 years ago - 1 comment
Labels: cla: no

#979 - JUnit 4 Guice Persist functionality.

Pull Request - State: closed - Opened by jccarrillo over 8 years ago - 7 comments
Labels: cla: no

#976 - #972 - Fixed the UnitOfWork.begin() JavaDoc to reflect the implementation

Pull Request - State: closed - Opened by jccarrillo over 8 years ago - 6 comments

GitHub / google/guice issues and pull requests