google/closure-templates issues and pull requests

#1662 - Fix a bug in StringData.equals where it didn't follow the equals contract

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1661 - Fix broken id

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1660 - * Make switch type narrowing work with null v. undefined.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1659 - Widen some straggling comparisons to null type to compare to null|undefined.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1658 - Ready param code for null->undefined change.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1657 - Delete template cloning for now. It's likely we won't be visiting it like this in the same way again and we can resurrect it when we do revisit

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1656 - In JBSRC, null-safe access coalesces to NullData, not NullData|UndefinedData. When `undefined` is fully introduced we will change this to always coalesce to UndefinedData.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1655 - Update some builtin functions to handle `undefined`.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1654 - Small cleanup.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1653 - Rename the `IncrementalDomRenderer` implemention to the alias `IncrementalDomRendererImpl`, rename `IdomRendererApi` to `IncrementalDomRenderer`. Then all existing references to `IncrementalDomRenderer` refer to the interface, and we can pass in `BufferingIncrementalDomRenderer` into `handleSoyElement` (and on to all idom internals) without the cast. All references to concrete `IncrementalDomRenderer` (new, extends, &c) have already been LSC'd to `IncrementalDomRendererImpl`.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1652 - Round trip UndefinedData through externs/plugins.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1651 - Small cleanup, add method for coalesce to undefined.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1650 - Treat null/undefined types the same in many places in the Soy compiler.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1649 - Allow empty string to be used in attributes expressions on the root element.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1648 - Change resolved type of binary operators to not be nullish.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1647 - move coercion errors up from NullData to NullishData

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1646 - Internal

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1645 - Update docs in response to a question -- make it clear that the data is applied when the call returns, not that idom is unsupported.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1644 - Add basic docs for errorfallback

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1643 - Full implementation of undefined type.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1642 - Dependencies addition of soyutils_usegoog.js makes hard to compile soy files

Issue - State: open - Opened by itchyny about 1 year ago - 5 comments

#1641 - No public description

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1640 - Internal

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1639 - Internal

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1638 - Rename the IncrementalDomRenderer implemention to the alias IncrementalDomRendererImpl, rename IdomRendererApi to IncrementalDomRenderer. Then all existing references to `IncrementalDomRenderer` refer to the interface, and we can pass in BufferingIncrementalDomRenderer in handleSoyElement without the cast.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1637 - Remove the `isLast` parameter to SoyValueProvider.renderAndResolve

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1636 - More ?: to ?? cleanup.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1635 - Remove ?: operator from Soy.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1634 - Remove double call of resolve type for first node of ?? operator. Some node visits (proto init with extensions) are not idempotent.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1633 - Add an alias `IncrementalDomRendererImpl` => `IncrementalDomRenderer`

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1632 - Classify all `MethodRef`s as pure or non-pure

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1631 - Internal

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1630 - Fix errorfallback for calls containing elements by updating `keepGoing` and `handleSoyElement` to buffer the enclosed content and passing the buffering renderer to the framework internals.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1629 - Fix errorfallback for calls containing elements.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1628 - Add a lot more tests for type narrowing, showing many cases where the result is incorrect due to b/297033128.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1627 - Update version after open source release.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1626 - Fix Maven compilation in opensource.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1625 - Add a few optimizations for let variables

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1624 - No public description

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1623 - No public description

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1622 - No public description

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1621 - Disallow logging functions in element calls.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1620 - Simplify element composition for conditional attributes using a new builtin function.

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1620 - Simplify element composition for conditional attributes using a new builtin function.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1619 - Fix a bug where the expected execution order did not match the actual execution order.

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1619 - Fix a bug where the expected execution order did not match the actual execution order.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1618 - Move functions which use `currentElement()` and `currentPointer()` onto the idom renderer in preparation for removing visibility to these methods.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1618 - Move functions which use `currentElement()` and `currentPointer()` onto the idom renderer in preparation for removing visibility to these methods.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1617 - Add a buffering idom renderer that can be used to implement `errorfallback="skip"`

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1617 - Add a buffering idom renderer that can be used to implement `errorfallback="skip"`

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1616 - Address some tiny static analysis suggestions

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1616 - Address some tiny static analysis suggestions

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1615 - Add `errorfallback="skip"` on calls, which causes any runtime exceptions to be caught. The call returns empty string and any logging is discarded. Only implemented for JbcSrc and JS backends in this CL.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1614 - Fix a bug in jssrc where we wouldn't manage variable scopes correctly.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1614 - Fix a bug in jssrc where we wouldn't manage variable scopes correctly.

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1613 - Repro a name scoping bug in js backends and fix a compiler crash in jbcsrc

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1612 - Better error messages when trying to access a proto via field.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1612 - Better error messages when trying to access a proto via field.

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1611 - Formalize Soy precedence, associativity.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1610 - Accept inlined .ico images as valid URIs

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1609 - Fix a bug in jssrc where we wouldn't remove variable names introduced by list comprehensions from the active set

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1608 - Use `ConstantDynamic` in jbcsrc to optimize a number of implicit operations.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1607 - Introduce ?? operator to Soy, matching JavaScript's.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1606 - Fix parens logic related to ?? (add fewer parens).

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1605 - Move functions which use `currentElement()` and `currentPointer()` onto the idom renderer in preparation for removing visibility to these methods.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1604 - No public description

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1603 - Fix a few small code size and performance issues

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1602 - Improve type narrowing, especially with null-safe chains.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1601 - Add a new bufferable (ie void return) idom renderer api method to set an attribute using a logging function. Use it in the case where a logging function is assigned directly to an attribute. Passing an attribute via element composition will not be handled and continues to evaluate to `evalLoggingFunction()`. That seems more difficult to support. The buffering idom renderer can just throw an exception there, attribute merging w/ element composition can be an unsupported use case since the plan is to generally discontinue support for it.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1600 - Add error messages around imported symbols that are misused.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1599 - Skip double backslashes that follow a quote from parsing.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1598 - Some no-op refactoring of type narrowing code.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1597 - Unify switch case matching logic between JS, TOFU, and JBCSRC.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1596 - Remove the return value from `text`, `close`, and `closeElement` idom renderer API methods.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1595 - Avoid unnecessary assertions when JS source functions are implemented as JS methods/fields.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1594 - Move functions which use `currentElement()` and `currentPointer()` onto the idom renderer in preparation for removing visibility to these methods.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1593 - Be smarter with the Java types of extern implementations. For impl params in general allow "? super X" and for impl return values allow "? extends X". For params this only affects List, where we now allow anything up to Iterable. For return values we allow any subclasses of Iterable for list, any Map for map/record, and any proto type for message.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1592 - Convert keepGoing() idom method to have void return and not require the current element to be passed in, as currentElement() will be removed from the API soon.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1591 - Relax casting to match previous jbcsrc behavior.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1590 - Update key methods to have void return. We rely on the gencode creating balanced pushKey/popKey commands and implement what the name `popKey()` suggests -- the top key on the stack is removed, instead of overwriting the entire key stack with arbitrary input.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1589 - Avoid unnecessary assertions when JS source functions are implemented as JS methods/fields.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1588 - Remove the return value from open() and openSimple() idom renderer api methods. Move handleSoyElement onto the idom renderer to accommodate this. Updating return values to be void will allow us to buffer commands and allow try/catch functionality in idom.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1587 - Avoid unnecessary assertions when JS source functions are implemented as JS methods/fields.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1586 - Fix a rare bug introduced by cl/560728208

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1585 - Fix precedence and associativity of ?? in our JS DSL.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1584 - Give JS cast an operator precedence so that it gets grouped. This is necessary before using the native ?. operator.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1584 - Give JS cast an operator precedence so that it gets grouped. This is necessary before using the native ?. operator.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1583 - Fix a number of subtle bugs around local variable management.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1583 - Fix a number of subtle bugs around local variable management.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1582 - Avoid compiling defaults for msg fallbacks, these are always dead code.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1582 - Avoid compiling defaults for msg fallbacks, these are always dead code.

Pull Request - State: open - Opened by copybara-service[bot] about 1 year ago

#1581 - No public description

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago - 1 comment

#1580 - Simplify the type signatures and bootstrap methods for `saveState` operations to reduce pressure on the constant pool.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1579 - Re-implement null safe access in JS backend with native JS operators.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1578 - Re-implement nullish coalesce in JS backend with native JS operator.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1577 - Fix a stack trace on an element composition error.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1576 - Oops, comparing to undefined.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1575 - Internal

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1574 - Fix bug causing indiscriminate type narrowing with triple equals in Soy.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

#1572 - Check nullish instead of null.

Pull Request - State: closed - Opened by copybara-service[bot] about 1 year ago

GitHub / google/closure-templates issues and pull requests