getify/You-Dont-Know-JS issues and pull requests

#434 - Fix various errata in Async & Performance Ch. 4: Generators

Pull Request - State: open - Opened by airandfingers over 9 years ago - 6 comments
Labels: for second edition, errata

#410 - Fixed onlyOne() not working as intended

Pull Request - State: open - Opened by tdamsma over 9 years ago - 3 comments
Labels: for second edition

#101 - "this & object prototypes": discuss devtools serialization/output of objects

Issue - State: closed - Opened by getify over 10 years ago - 6 comments

#100 - Example in "this & object prototypes / apA.md" will throw TypeError at runtime

Issue - State: closed - Opened by anba over 10 years ago - 1 comment

#99 - "this & object prototypes": discuss Object.assign(..)

Issue - State: closed - Opened by getify over 10 years ago

#98 - preface: typo "famoulsy"

Issue - State: closed - Opened by getify over 10 years ago

#97 - Tiny typo in -> is on line 175

Pull Request - State: closed - Opened by machineloop over 10 years ago - 1 comment

#96 - Get user and pass strings not dom nodes so the compare and length checks work

Pull Request - State: closed - Opened by lyle over 10 years ago - 1 comment

#95 - "this & object prototypes": ch6, add discussion of object-method shorthand

Issue - State: closed - Opened by getify over 10 years ago

#94 - "types & grammar": explain Symbol and == behavior

Issue - State: closed - Opened by getify over 10 years ago

#93 - There is no figures for Chapter 4: Mixing Class Copies

Issue - State: closed - Opened by nik-kor over 10 years ago - 1 comment

#92 - Hoisting of let

Issue - State: closed - Opened by tompazourek over 10 years ago - 4 comments

#91 - "this & object prototypes": cover shadowing properties

Issue - State: closed - Opened by getify over 10 years ago - 23 comments

#90 - "this & object prototypes": cover "parasitic inheritance" (probably ch4)

Issue - State: closed - Opened by getify over 10 years ago

#89 - Chapter 4 typos

Pull Request - State: closed - Opened by zackgao over 10 years ago - 1 comment

#88 - Typo Correction in Chapter 1 - this & Object Prototypes

Pull Request - State: closed - Opened by vigneshshanmugam over 10 years ago - 1 comment

#87 - "this & object prototypes": Explain how the instaceof works in these two cases.

Issue - State: closed - Opened by vigneshshanmugam over 10 years ago - 1 comment

#86 - "types & grammar": explain how coercion disallows `obj == obj`

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#85 - Spelling correction in Chapter 3

Pull Request - State: closed - Opened by zackgao over 10 years ago - 2 comments

#84 - Another small typo in Chapter 2

Pull Request - State: closed - Opened by zackgao over 10 years ago - 1 comment

#83 - Small typo in Chapter 2

Pull Request - State: closed - Opened by zackgao over 10 years ago

#82 - We/is in Appendix A

Pull Request - State: closed - Opened by zackgao over 10 years ago - 1 comment

#81 - Code snippet in Chapter 4 is not marked up

Pull Request - State: closed - Opened by zackgao over 10 years ago - 1 comment

#80 - Another small typo in Chapter 3

Pull Request - State: closed - Opened by zackgao over 10 years ago - 1 comment

#79 - "scope & closures": errata

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#78 - Typo in Chapter 3

Pull Request - State: closed - Opened by zackgao over 10 years ago - 1 comment

#77 - "types & grammar": cover difference between missing argument and explicit `undefined` argument

Issue - State: closed - Opened by getify over 10 years ago

#76 - Fixes some typos

Pull Request - State: closed - Opened by cirocosta over 10 years ago - 1 comment

#75 - for "this & object prototypes", clarify constructor vs constructor call

Issue - State: closed - Opened by getify over 10 years ago

#74 - "types & grammar": cover `Number(..)`

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#73 - "types & grammar": cover `if..else if..else`

Issue - State: closed - Opened by getify over 10 years ago

#72 - Fix typo in Scope&Closure - Chapter 3: Function vs. Block Scope

Pull Request - State: closed - Opened by ezhilvendhan over 10 years ago - 1 comment

#71 - for "this & object prototypes", add more explanation of for-of iterators

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#70 - Update ch4.md (this & object prototypes)

Pull Request - State: closed - Opened by stefanbruvik over 10 years ago - 1 comment

#69 - "types & grammar": cover what `Array(3)` is actually doing

Issue - State: closed - Opened by getify over 10 years ago - 2 comments

#68 - Fix typo: vairable => variable

Pull Request - State: closed - Opened by sunsations over 10 years ago - 1 comment

#67 - "types & grammar": cover how IEEE-754 numbers work

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#66 - Copyright attribution isn't explicit

Issue - State: closed - Opened by erezschatz over 10 years ago - 2 comments

#65 - The book has a degrading title to its readers

Issue - State: closed - Opened by erezschatz over 10 years ago - 1 comment

#64 - Fixed typo

Pull Request - State: closed - Opened by DickvdBrink over 10 years ago - 1 comment

#63 - Ch 4 Functions First is a little confusing

Issue - State: closed - Opened by davidbkemp over 10 years ago - 5 comments

#62 - Can you please explain when we declare x : y = 10 in the global context, It results in y=10 and x = Reference Error.

Issue - State: closed - Opened by vigneshshanmugam over 10 years ago - 2 comments

#61 - Update ch1.md

Pull Request - State: closed - Opened by martinthogersen over 10 years ago - 1 comment

#60 - For 'Scope and closures' point out var x = y= z =10; puts y, z in global scope always.

Issue - State: closed - Opened by adityapunjani over 10 years ago - 3 comments

#59 - "types & grammar": cover ints versus floating point

Issue - State: closed - Opened by getify over 10 years ago

#58 - for "scope & closures", point out that `eval` in strict mode is in its own lexical block

Issue - State: closed - Opened by getify over 10 years ago - 2 comments

#57 - for "scope & closures", point out that `var` inside a `with` block doesn't declare to that block

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#56 - for "scope & closures", point out that `let` declarations DON'T hoist!

Issue - State: closed - Opened by getify over 10 years ago - 1 comment

#55 - "types & grammar": mention falsy objects

Issue - State: closed - Opened by getify over 10 years ago

#54 - "types & grammar": cover what `&&` and `||` operators ACTUALLY do

Issue - State: closed - Opened by getify almost 11 years ago

#53 - update copyright year to range

Pull Request - State: closed - Opened by PatrickJS almost 11 years ago - 1 comment

#52 - Ch4 "Scope & Closures": add discussion of functions in block scopes

Issue - State: closed - Opened by getify almost 11 years ago - 1 comment

#51 - Fix typo- thin->thing

Pull Request - State: closed - Opened by agarrharr almost 11 years ago - 1 comment

#50 - "types & grammar": cover everything in this quiz

Issue - State: closed - Opened by getify almost 11 years ago - 1 comment

#49 - "types & grammar": cover when toString() and valueOf() are implicitly called

Issue - State: closed - Opened by getify almost 11 years ago

#48 - "types & grammar": cover stuff like `(i++)`

Issue - State: closed - Opened by getify almost 11 years ago

#47 - For objects, explain `writable`/`configurable` and `Object.seal()/freeze()`

Issue - State: closed - Opened by getify almost 11 years ago - 1 comment

#46 - Adding output for code snippet

Pull Request - State: closed - Opened by adityapunjani almost 11 years ago - 1 comment

#45 - "types & grammar": address parseInt() crazy

Issue - State: closed - Opened by getify almost 11 years ago - 2 comments

#44 - technical review - vball525

Issue - State: closed - Opened by ghost almost 11 years ago - 13 comments

#43 - ES6 has no "inline module" syntax

Issue - State: closed - Opened by getify almost 11 years ago

#42 - ES6 modules are privileged over other module systems

Issue - State: closed - Opened by othiym23 almost 11 years ago - 2 comments

#41 - scope & closure technical review - [email protected]

Issue - State: closed - Opened by shelleyp almost 11 years ago - 13 comments

#40 - technical review - [email protected]

Issue - State: closed - Opened by eborden almost 11 years ago - 8 comments

#39 - technical review [email protected]

Issue - State: closed - Opened by the-simian almost 11 years ago - 7 comments

#38 - technical review - [email protected]

Issue - State: closed - Opened by iennae almost 11 years ago - 5 comments

#37 - Tech Editors

Issue - State: closed - Opened by getify almost 11 years ago - 28 comments
Labels: question, help wanted, editorial

#36 - Chapter 5, "Future Modules" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 1 comment

#35 - Chapter 3, "IIFE" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 4 comments

#34 - Chapter 3, "Collision Avoidance" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago

#33 - Chapter 2, "Cheating Lexical" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 1 comment

#32 - Chapter 2, "Lex-Time" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 1 comment

#31 - Chapter 1, "Building on Metaphors" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 1 comment

#30 - Chapter 1, "Conversation?" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago

#29 - Chapter 1, "Scope Conversations" section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 1 comment

#28 - Chapter 1, "Compilation" Section edits

Issue - State: closed - Opened by bmacdonald-editor almost 11 years ago - 1 comment

#27 - fixed typo (call-size -> call-site)

Pull Request - State: closed - Opened by davepreston almost 11 years ago - 1 comment

#26 - Add discussion of moot/ignored value for `this` binding

Issue - State: closed - Opened by getify almost 11 years ago
Labels: enhancement

#25 - "this & object prototypes": Add discussion of ES5's (`forEach`, `every`, `some`) array value-iterations

Issue - State: closed - Opened by getify almost 11 years ago
Labels: enhancement

#24 - Update ch3.md: missing semi-colon

Pull Request - State: closed - Opened by alexreardon almost 11 years ago - 1 comment

#23 - "types & grammar": cover (some) native functions and control flows

Issue - State: closed - Opened by alexreardon almost 11 years ago - 4 comments
Labels: enhancement, question

#22 - Appendix to discuss indirect `this` bindings

Issue - State: closed - Opened by getify almost 11 years ago
Labels: enhancement

#21 - TYPO: idenfify -> identify

Pull Request - State: closed - Opened by dannyc almost 11 years ago - 1 comment

#20 - typo - 'the' word repeated

Pull Request - State: closed - Opened by varun06 almost 11 years ago - 1 comment

#19 - Small typo on line 88

Pull Request - State: closed - Opened by varun06 almost 11 years ago - 1 comment

#18 - Correct small omission in scope examples

Pull Request - State: closed - Opened by lifebeyondfife almost 11 years ago - 1 comment

#17 - Corrected one typo(changed 'is has' to 'has' on line 134

Pull Request - State: closed - Opened by varun06 almost 11 years ago - 2 comments

#16 - Fix typo

Pull Request - State: closed - Opened by ryngonzalez almost 11 years ago - 2 comments

#14 - fixed typo

Pull Request - State: closed - Opened by yannmadeleine almost 11 years ago - 1 comment

#13 - fix typo in ch3.md

Pull Request - State: closed - Opened by yannmadeleine almost 11 years ago - 1 comment

#12 - Joining?

Issue - State: closed - Opened by peterborkuti almost 11 years ago - 2 comments
Labels: enhancement

#11 - Code missing in code snippet - Module section, Chapter 5

Issue - State: closed - Opened by kushdilip almost 11 years ago

#10 - Fixed typo in JS for section "Lexical this"

Pull Request - State: closed - Opened by michaellopez almost 11 years ago - 1 comment

#9 - Is the open parts of book welcome translate to other language like chinese?

Issue - State: closed - Opened by yuanyan almost 11 years ago - 17 comments
Labels: foreign language translations

#8 - scope & closure/ch1.md; NumberLiteral => NumericLiteral

Pull Request - State: closed - Opened by rwaldron almost 11 years ago - 2 comments

#7 - Editing

Pull Request - State: closed - Opened by skeep almost 11 years ago - 1 comment

#6 - Update ch5.md

Pull Request - State: closed - Opened by codylindley almost 11 years ago - 1 comment

#5 - Update ch5.md

Pull Request - State: closed - Opened by codylindley almost 11 years ago - 1 comment

#4 - Fixes some minor grammatical, spelling, typo errors.

Pull Request - State: closed - Opened by micmath almost 11 years ago - 1 comment

#3 - Missing image

Issue - State: closed - Opened by TehShrike almost 11 years ago - 4 comments
Labels: enhancement

GitHub / getify/You-Dont-Know-JS issues and pull requests