Ecosyste.ms: Issues
An open API service for providing issue and pull request metadata for open source projects.
GitHub / gardener/gardener issues and pull requests
#10116 - [operator]: Adapt gardener/dashboard related code
Issue -
State: open - Opened by petersutter 3 months ago
- 3 comments
Labels: kind/enhancement, area/security
#10040 - Install Custom CA certs also for existing nodes
Issue -
State: open - Opened by vpnachev 3 months ago
- 1 comment
Labels: kind/enhancement, lifecycle/stale, area/robustness, area/os
#10017 - Rename the controlplaneexposure webhooks across the provider extensions to something more meaningful
Issue -
State: open - Opened by ialidzhikov 3 months ago
- 1 comment
Labels: kind/enhancement, lifecycle/stale
#10014 - Introduce `node-agent-authorizer` webhook to authenticate `gardener-node-agents` in shoots
Pull Request -
State: open - Opened by oliver-goetz 3 months ago
- 10 comments
Labels: kind/enhancement, area/security, cla: yes, needs-rebase, do-not-merge/hold, size/XXL, do-not-merge/work-in-progress
#9996 - Support new annotation that skips resource deletion/doesn't depend on ETCD&KAPI and just drops the control plane
Issue -
State: open - Opened by vlerenc 4 months ago
- 1 comment
Labels: lifecycle/stale
#9966 - SSH Key Pair Rotation for Worker Nodes Fails to Update `authorized_keys`
Issue -
State: open - Opened by petersutter 4 months ago
- 2 comments
Labels: kind/bug, area/security, lifecycle/stale
#9965 - Allow `ShootResourceReservation` to be configurable per seed
Issue -
State: open - Opened by adenitiu 4 months ago
- 6 comments
Labels: kind/enhancement, area/robustness
#9952 - WorkerGroup update behavior in ReplicaSet pattern
Issue -
State: open - Opened by epDHowwD 4 months ago
- 3 comments
Labels: lifecycle/stale, area/usability, area/control-plane, area/auto-scaling, area/scalability
#9940 - [operator] Deploy `BackupBucket`/`DNSRecord` extension resources
Pull Request -
State: closed - Opened by kon-angelo 4 months ago
- 10 comments
Labels: kind/enhancement, lifecycle/rotten, size/XL, area/control-plane, cla: yes, needs-rebase, do-not-merge/work-in-progress
#9934 - Avoid hosting API server instances that use much more memory than they request
Issue -
State: open - Opened by istvanballok 4 months ago
- 5 comments
Labels: kind/enhancement, lifecycle/stale, area/auto-scaling
#9867 - Add (Basic Auth) Monitoring URLs to `.monitoring` secret
Issue -
State: open - Opened by petersutter 4 months ago
- 2 comments
Labels: kind/enhancement, lifecycle/rotten, area/monitoring
#9864 - Extension webhooks don't have an `objectSelector`
Issue -
State: open - Opened by ialidzhikov 4 months ago
- 1 comment
Labels: kind/enhancement, area/scalability
#9858 - Support for Structured Authentication for `Shoot`s >= Kubernetes v1.30
Issue -
State: open - Opened by dimityrmirchev 4 months ago
- 13 comments
Labels: kind/enhancement, kind/epic, area/security, area/ipcei
#9830 - `gardenlet` Self-Upgrades For Unmanaged `Seed`s
Issue -
State: closed - Opened by rfranzke 4 months ago
- 1 comment
Labels: kind/enhancement, kind/epic, area/ops-productivity, area/ipcei
#9791 - chore(deps): update prometheus-operator images to v0.74.0 (minor)
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 2 comments
Labels: kind/enhancement, size/XS, cla: yes
#9790 - Fix issue with ignored `StatefulSet` labels on Cilium.
Pull Request -
State: open - Opened by axel7born 5 months ago
- 6 comments
Labels: size/M, area/networking, cla: yes, do-not-merge/needs-kind, do-not-merge/work-in-progress
#9789 - chore(deps): update dependency credativ/plutono to v7.5.30
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes
#9788 - chore(deps): update dependency credativ/vali to v2.2.15
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 2 comments
Labels: kind/enhancement, size/XS, cla: yes
#9787 - chore(deps): update dependency gardener/autoscaler to v1.28.2
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 7 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9786 - chore(deps): update dependency gardener/autoscaler to v1.27.2
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 8 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9785 - Remove resource limits for the observability components
Pull Request -
State: open - Opened by istvanballok 5 months ago
- 3 comments
Labels: kind/enhancement, area/monitoring, size/S, cla: yes, lgtm
#9784 - [GEP-26] Remove unused packages
Pull Request -
State: closed - Opened by dimityrmirchev 5 months ago
- 7 comments
Labels: size/L, kind/cleanup, cla: yes, lgtm, approved, area/ipcei
#9783 - fix(deps): update module sigs.k8s.io/controller-runtime/tools/setup-envtest to v0.0.0-20240516231036-f4ca78ebc00a
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 1 comment
Labels: kind/enhancement, size/XS, cla: yes
#9782 - Move `machine-controller-manager-provider-local` into `gardener/gardener`
Pull Request -
State: open - Opened by timebertt 5 months ago
- 5 comments
Labels: kind/enhancement, area/dev-productivity, size/XL, cla: yes, needs-rebase
#9781 - fix(deps): update module github.com/containerd/containerd to v1.7.17
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/enhancement, size/S, cla: yes, lgtm, approved
#9780 - [GEP-26] Add `WorkloadIdentity` API
Pull Request -
State: open - Opened by vpnachev 5 months ago
- 1 comment
Labels: kind/enhancement, area/security, cla: yes, size/XXL, area/ipcei
#9779 - fix(deps): update module k8s.io/autoscaler/vertical-pod-autoscaler to v1.1.2
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes
#9778 - Add go:embedded files to skaffold dependencies
Pull Request -
State: open - Opened by maboehm 5 months ago
- 4 comments
Labels: kind/enhancement, area/dev-productivity, size/L, ok-to-test, cla: yes
#9777 - chore(deps): update registry.k8s.io/autoscaling/vpa-updater docker tag to v1.1.2
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 2 comments
Labels: kind/enhancement, size/XS, cla: yes
#9776 - chore(deps): update registry.k8s.io/autoscaling/vpa-recommender docker tag to v1.1.2
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/enhancement, size/XS, cla: yes
#9775 - chore(deps): update registry.k8s.io/autoscaling/vpa-admission-controller docker tag to v1.1.2
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 2 comments
Labels: kind/enhancement, size/XS, cla: yes
#9774 - Changes for deployment of VPN2 after rewrite to Go.
Pull Request -
State: closed - Opened by MartinWeindel 5 months ago
- 11 comments
Labels: kind/enhancement, area/control-plane, cla: yes, lgtm, approved, size/XXL
#9773 - Graduate the `core.gardener.cloud` API to `v1`
Issue -
State: open - Opened by timebertt 5 months ago
- 1 comment
Labels: kind/enhancement, area/dev-productivity, area/usability
#9772 - [release-v1.95] Fix shoot control plane federation regression (2)
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/bug, size/XS, area/monitoring, cla: yes, lgtm, approved
#9771 - Introduce `core.gardener.cloud/v1.ControllerDeployment` API
Pull Request -
State: open - Opened by timebertt 5 months ago
- 2 comments
Labels: kind/enhancement, area/dev-productivity, area/usability, cla: yes, size/XXL
#9770 - extensions lib: Drop the `EnsureKubeAPIServerService` func from the controlplane `Ensurer`
Pull Request -
State: open - Opened by ialidzhikov 5 months ago
- 3 comments
Labels: size/M, kind/cleanup, area/scalability, cla: yes, lgtm
#9769 - Fix shoot control plane federation regression (2)
Pull Request -
State: closed - Opened by istvanballok 5 months ago
- 6 comments
Labels: kind/bug, size/XS, area/monitoring, cla: yes, lgtm, approved
#9768 - [release-v1.95] Fix shoot control plane federation regression
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 2 comments
Labels: kind/bug, size/M, area/monitoring, cla: yes, lgtm, approved
#9767 - [release-v1.95] Automated cherry pick of #9764: Fix shoot control plane federation regression
Pull Request -
State: closed - Opened by ialidzhikov 5 months ago
- 3 comments
Labels: kind/bug, size/M, area/monitoring, cla: yes, do-not-merge/work-in-progress
#9766 - chore(deps): update dependency helm/helm to v3.15.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9765 - fix(deps): update module helm.sh/helm/v3 to v3.15.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 6 comments
Labels: kind/enhancement, size/XS, cla: yes
#9764 - Fix shoot control plane federation regression
Pull Request -
State: closed - Opened by rickardsjp 5 months ago
- 6 comments
Labels: kind/bug, size/M, area/monitoring, cla: yes, lgtm, approved
#9763 - [provider-local] Use `gardener-operator` for local development setup
Pull Request -
State: open - Opened by oliver-goetz 5 months ago
- 2 comments
Labels: kind/enhancement, area/dev-productivity, size/L, cla: yes
#9762 - Describe howto access the shoot kubernetes apiserver via tailscale vpn
Pull Request -
State: closed - Opened by majst01 5 months ago
- 6 comments
Labels: kind/enhancement, area/documentation, size/L, needs-ok-to-test, cla: yes
#9761 - fix(deps): update module k8s.io/component-helpers to v0.29.5
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/enhancement, size/S, cla: yes, lgtm, approved
#9760 - fix(deps): update kubernetes packages to v0.29.5 (patch)
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 8 comments
Labels: kind/enhancement, size/M, cla: yes, lgtm, approved
#9759 - chore(deps): update dependency gardener/dashboard to v1.75.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 5 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9758 - Improve monitoring documentation
Pull Request -
State: open - Opened by vicwicker 5 months ago
- 2 comments
Labels: kind/enhancement, area/documentation, size/S, cla: yes, do-not-merge/work-in-progress
#9757 - Label nodes with expected OperatingSystemConfig name
Pull Request -
State: open - Opened by MichaelEischer 5 months ago
- 4 comments
Labels: kind/enhancement, size/L, area/control-plane, ok-to-test, cla: yes
#9756 - chore(deps): update dependency kubernetes/kubernetes to v1.30.1
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9755 - extensions lib: Consider dropping `EnsureKubeAPIServerService` as it is no longer required after `ManagedIstio`/`APIServerSNI` is unconditionally enabled
Issue -
State: open - Opened by ialidzhikov 5 months ago
Labels: kind/cleanup, area/scalability
#9754 - Optimise plutono and vali resource requests
Pull Request -
State: closed - Opened by plkokanov 5 months ago
- 4 comments
Labels: kind/enhancement, area/monitoring, size/S, cla: yes, lgtm, approved
#9753 - Prepare next Dev Cycle v1.96.0-dev
Pull Request -
State: closed - Opened by ialidzhikov 5 months ago
- 5 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9752 - [provider-local] Harmonize local VPN setup with real-world scenario
Pull Request -
State: open - Opened by rfranzke 5 months ago
- 7 comments
Labels: kind/enhancement, area/dev-productivity, size/L, cla: yes
#9751 - chore(deps): update dependency googlecontainertools/skaffold to v2.12.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9750 - Rework seed alerts to consider all possible conditions
Pull Request -
State: open - Opened by vicwicker 5 months ago
- 2 comments
Labels: kind/enhancement, size/L, area/monitoring, cla: yes, do-not-merge/work-in-progress
#9749 - If backupentry reconciles before Shoot namespace gets created cluster creation will fail
Issue -
State: open - Opened by Kostov6 5 months ago
- 1 comment
Labels: kind/bug
#9748 - Fix flaky test for EvictionRequirementsController
Pull Request -
State: closed - Opened by voelzmo 5 months ago
- 3 comments
Labels: size/M, area/auto-scaling, kind/flake, cla: yes, lgtm, approved
#9747 - Remove unneeded code for dwd deployment
Pull Request -
State: closed - Opened by aaronfern 5 months ago
- 5 comments
Labels: area/dev-productivity, size/M, kind/cleanup, cla: yes, lgtm, approved
#9746 - [GEP-24] Manage Gardener Discovery Server via Gardener Operator
Pull Request -
State: open - Opened by dimityrmirchev 5 months ago
- 5 comments
Labels: kind/enhancement, area/security, cla: yes, do-not-merge/hold, size/XXL, area/ipcei
#9745 - Set e2e test shoot k8s version to `v1.30.0`
Pull Request -
State: closed - Opened by shafeeqes 5 months ago
- 7 comments
Labels: kind/enhancement, size/S, cla: yes, lgtm, approved
#9744 - chore(deps): update dependency kubernetes-sigs/kind to v0.23.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9743 - fix(deps): update module sigs.k8s.io/controller-runtime/tools/setup-envtest to v0.0.0-20240514005710-5dcea7e94b71
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes
#9742 - chore(deps): update kindest/node docker tag to v1.29.4
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9741 - chore(deps): update quay.io/kiwigrid/k8s-sidecar docker tag to v1.27.1
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 5 comments
Labels: kind/enhancement, size/M, cla: yes, lgtm, approved
#9740 - Allow customization of authorization mode kubeAPIServer args
Issue -
State: open - Opened by aaronschweig 5 months ago
- 1 comment
Labels: kind/enhancement, kind/api-change
#9739 - Prometheus alerts for when `etcd-druid`'s snapshot compaction jobs fail above a certain rate
Pull Request -
State: open - Opened by renormalize 5 months ago
- 2 comments
Labels: kind/enhancement, size/M, area/monitoring, area/control-plane, cla: yes, do-not-merge/work-in-progress
#9738 - chore(deps): update dependency mikefarah/yq to v4.44.1
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9737 - [GEP-19] Adapt monitoring configuration for shoot cluster system components
Pull Request -
State: open - Opened by rfranzke 5 months ago
- 1 comment
Labels: kind/enhancement, area/monitoring, cla: yes, size/XXL
#9736 - chore(deps): update dependency projectcalico/calico to v3.28.0
Pull Request -
State: open - Opened by gardener-ci-robot 5 months ago
- 2 comments
Labels: kind/enhancement, size/XS, cla: yes
#9735 - Add the `VPAAndHPAForAPIServer` feature gate for the gardener-operator
Pull Request -
State: open - Opened by ialidzhikov 5 months ago
- 3 comments
Labels: kind/enhancement, size/L, area/auto-scaling, cla: yes
#9734 - [GEP-26] Move CredentialsBinding to security.gardener.cloud group
Pull Request -
State: closed - Opened by vpnachev 5 months ago
- 7 comments
Labels: kind/bug, area/security, cla: yes, lgtm, approved, size/XXL, area/ipcei
#9733 - [release-v1.92] Omit useless data from `OperatingSystemConfig` in `Secret`s reconciled by `gardener-node-agent`
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/bug, area/usability, size/M, cla: yes, lgtm, approved
#9732 - [release-v1.93] Omit useless data from `OperatingSystemConfig` in `Secret`s reconciled by `gardener-node-agent`
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/bug, area/usability, size/M, cla: yes, lgtm, approved
#9731 - [release-v1.94] Omit useless data from `OperatingSystemConfig` in `Secret`s reconciled by `gardener-node-agent`
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/bug, area/usability, size/M, cla: yes, lgtm, approved
#9730 - Add CVE categorisation labels for the node-problem-detector image
Pull Request -
State: closed - Opened by ialidzhikov 5 months ago
- 4 comments
Labels: kind/enhancement, size/S, cla: yes, lgtm, approved
#9729 - fix(deps): update module github.com/prometheus/client_golang to v1.19.1
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 5 comments
Labels: kind/enhancement, size/S, cla: yes
#9728 - Extend image pattern in kyverno policy to support `snapshots` and `public` registries.
Pull Request -
State: closed - Opened by dimitar-kostadinov 5 months ago
- 5 comments
Labels: kind/enhancement, area/dev-productivity, size/XS, cla: yes, lgtm, approved
#9727 - Exclude kube-system namespace from seed VPA webhook
Pull Request -
State: closed - Opened by andrerun 5 months ago
- 13 comments
Labels: kind/enhancement, size/S, area/auto-scaling, cla: yes, do-not-merge/hold
#9726 - chore(deps): update quay.io/prometheus/prometheus docker tag to v2.52.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 6 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9725 - chore(deps): update dependency prometheus/prometheus to v2.52.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9724 - chore(deps): update dependency golangci/golangci-lint to v1.58.1
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 6 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9723 - Omit useless data from `OperatingSystemConfig` in `Secret`s reconciled by `gardener-node-agent`
Pull Request -
State: closed - Opened by rfranzke 5 months ago
- 11 comments
Labels: kind/bug, area/usability, size/M, cla: yes, lgtm, approved
#9722 - Introduce `.spec.pools[].userDataSecretRef` to prevent inlining the entire user data
Pull Request -
State: closed - Opened by rfranzke 5 months ago
- 5 comments
Labels: kind/enhancement, size/L, area/scalability, cla: yes, lgtm, approved
#9721 - Fix example github `apiURL` in documentation
Pull Request -
State: closed - Opened by petersutter 5 months ago
- 2 comments
Labels: kind/enhancement, size/XS, area/documentation, cla: yes, lgtm, approved
#9720 - chore(deps): update golang (patch)
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/enhancement, size/M, cla: yes, lgtm, approved
#9719 - chore(deps): update quay.io/brancz/kube-rbac-proxy docker tag to v0.17.1
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9718 - Prevent generation of new `managedresource-shoot-core-system-*` `Secret`s on each `Shoot` reconciliation
Pull Request -
State: closed - Opened by rfranzke 5 months ago
- 3 comments
Labels: kind/bug, area/ops-productivity, size/XS, cla: yes, lgtm, approved
#9716 - Configure Cache Prometheus to scrape kubelet and cadvisor metrics directly
Pull Request -
State: open - Opened by istvanballok 5 months ago
- 12 comments
Labels: kind/enhancement, size/L, area/monitoring, cla: yes
#9714 - Validation of DNSRecords: allow domain names starting with an underscore "_"
Pull Request -
State: closed - Opened by MartinWeindel 5 months ago
- 8 comments
Labels: kind/enhancement, size/S, area/control-plane, cla: yes, lgtm, approved
#9700 - Local setup with extensions on Azure fails to recover if the dev shoot hosting the local seed is hibernated.
Issue -
State: open - Opened by ashwani2k 5 months ago
- 3 comments
Labels: kind/bug, area/dev-productivity, lifecycle/rotten
#9699 - Rework OperatingSystemConfigKey and WorkerPoolHash to allow considering `kubeReserved`
Issue -
State: open - Opened by MichaelEischer 5 months ago
Labels: kind/enhancement, area/robustness
#9698 - Drop HVPA for KCM and use VPA instead
Pull Request -
State: closed - Opened by andrerun 5 months ago
- 11 comments
Labels: kind/enhancement, size/L, area/auto-scaling, cla: yes, lgtm, approved
#9697 - fix(deps): update module sigs.k8s.io/controller-runtime to v0.17.4
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved
#9696 - fix(deps): update module sigs.k8s.io/controller-runtime/tools/setup-envtest to v0.0.0-20240501202913-9bc967a711e9
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 4 comments
Labels: kind/enhancement, size/XS, cla: yes
#9695 - [GEP-19] Migrate shoot Prometheus deployment
Pull Request -
State: closed - Opened by rfranzke 5 months ago
- 7 comments
Labels: kind/enhancement, area/dev-productivity, area/monitoring, cla: yes, lgtm, approved, size/XXL
#9694 - HA Shoot creation fails because of missing VPN
Issue -
State: open - Opened by Lappihuan 5 months ago
- 7 comments
Labels: kind/bug, lifecycle/stale, area/networking, area/high-availability
#9693 - Allow easy IPv6-only prow tests
Pull Request -
State: open - Opened by ScheererJ 5 months ago
- 2 comments
Labels: kind/enhancement, area/dev-productivity, area/quality, size/M, area/robustness, area/networking, area/testing, cla: yes, do-not-merge/hold
#9692 - [release-v1.94] Switch from `purpose` to `is_seed` for Seed alerts
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/bug, size/XS, area/monitoring, cla: yes, lgtm, approved
#9691 - fix(deps): update module google.golang.org/protobuf to v1.34.0
Pull Request -
State: closed - Opened by gardener-ci-robot 5 months ago
- 3 comments
Labels: kind/enhancement, size/XS, cla: yes, lgtm, approved