fzyzcjy/flutter_smooth issues and pull requests

#74 - Implement full hitTest logic for sub-tree-under-aux-tree of main tree, currently ignore aux tree possible transforms

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#73 - Implement hitTest for aux tree (previously the aux tree does not get any hit tests)

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#72 - Update widgets when hot reload

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#71 - Thoughts: How to implement ListView scrolling?

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#70 - Add simple widget test for ListView scrolling

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#69 - Review: How is scrolling and inertia implemented?

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#68 - Maybe modify engine to extra get user touch events, for the ListView scrolling case, if the "no-handle-user-touch-events" method gives unnatural UX

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#67 - Implement logic of `ListView` scrolling with heavy children

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#66 - Add a demo for `ListView` scrolling with heavy children

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#65 - enhance WindowRenderCapturer

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#64 - Add package `smooth_dev` and move some test code to it

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#63 - Add test for offstage cases - for example, when a page is low in Navigator stack and invisible, its animation callbacks should not be fired

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#62 - Refactor and simplify the example app

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#61 - Add sanity check for `onBeginFrame` duration input

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#60 - Change 'when one extra smooth frame' to test two frames, because bugs can occur between frames; also refactor

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#59 - Current status

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 9 comments

#58 - Add "shuffler", such that different widgets can be shuffled to test that it is unrelated to ordering

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#57 - publish package to pub.dev, after all upstream PR are merged

Issue - State: open - Opened by fzyzcjy about 2 years ago - 20 comments

#56 - When running 'when one extra smooth frame' test alone, it works; but when run with others in same file, it fails

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 6 comments

#55 - Add widget test to the "enter page transition" demo, such that can verify correctness before really running it

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 9 comments

#54 - widgets in second tree is never disposed (i.e. state.dispose never called)

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#53 - Add test to ensure we do not run unneeded runPipeline (for example, run runPipeline twice when once is enough), because it is called in several places

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#52 - Get called when main tree `flushLayout` is finished

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#51 - Mimic the "vsync" figure to add tests for 1, 2, and inf

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#50 - Add test where content is infinitely slow such that smooth create many extra frames

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#49 - Add test where content is so fast that Smooth create no extra frame; refactor existing test at the same time

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#48 - `AutomatedTestWidgetsFlutterBinding.pump` does not provide real timestamp to `handleBeginFrame`, but clamp at milliseconds

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 13 comments

#47 - Add "thanks" section for people who discuss / point out problems / possible solutions to the proposal

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#46 - Export logo to png, probably with a script

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#45 - The "vsyncLaterThan" logic in PreemptStrategyNormal is wrong, because may need vsync before it

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#44 - Improve DX of `matchesReferenceImage` or `WindowRenderCapturer`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#43 - Make a PR to add `AutomatedTestWidgetsFlutterBinding.elapseBlocking`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#42 - maybe optimize PreemptStrategyTest, do not fill in frame time by hand

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#41 - More about `PreemptStrategyNormal`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 8 comments

#40 - Set up github "Social preview" image

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#39 - Add a logo

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#38 - Run demo app again, ensuring it works

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 13 comments

#37 - Add cache to `_PreemptStrategyNormal.currentVsyncTargetTime`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#36 - Add "DateTime when onBeginFrame"

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#35 - Avoid `DateTime.now()` and use `clock.now()`, otherwise not mockable by fake-async

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#34 - Utilize the flutter master branch + only my ongoing PR, to run all code of flutter_smooth, thus ensure we do not miss anything needed to be changed in flutter

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#33 - Add global `enable` flag, such that can easily enable/disable in production build, and test behavior

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment
Labels: wontfix

#32 - Think and experiment further on `PreemptStrategyNormal` and `SmoothWidgetsFlutterBinding`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 12 comments

#31 - Refactor `PreemptStrategyNormal`, and remove need for `lastVsyncInfo`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#30 - What if rasterizer is (always) slower than 16ms, seems that we will have a too-full queue and are wasting time

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 5 comments

#29 - Notice current `_PreemptStrategyNormal` refactor has duplicated (2x) calls to `lastVsyncInfo()`, so may cause performance problem; need to solve it later

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#28 - Remove dependency on `lastVsyncInfo()`, except for `PreemptStrategyNormal` internal impl, to improve encapsulation and possibly remove the whole lastVsyncInfo in the future

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#27 - Add benchmark test, checking total duration (i.e. the time user faces to see the final content)

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#26 - Add benchmark test, checking smoothness (i.e. see 60 new frames per second)

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#25 - add testing utility: create golden reference image, such that can use `matchReferenceImage` instead of `matchesGoldenFile` and more flexible

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#24 - Faster way to check whether we are near a timeout

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#23 - Add simple test where Smooth creates one extra frame, with special content, and assert its content

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 62 comments

#22 - Intercept the `window.render` for both normal pipeline and smooth frames, by implementing own override bindings

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#21 - Add and successfully run simplest test for SmoothBuilder

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 11 comments

#20 - delete "clear RenderObject.debugActiveLayout" logic in AuxiliaryTreeRootView, since the new one in AuxiliaryTreePack should work

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#19 - Add various tests about state invalidation (setState, markNeedsLayout, markNeedsPaint), and fix all of them, to ensure we correctly refresh in all cases

Issue - State: open - Opened by fzyzcjy about 2 years ago - 5 comments

#18 - Extract logic of Actor.shouldAct, making it a class or a strategy

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#17 - Add test case when multiple `SmoothBuilder` exist at the same time (i.e. multiple auxiliary trees)

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#16 - Unit test `SmoothPreemptPoint`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 10 comments

#15 - Remove `AuxiliaryTreePack.instance`

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#14 - Avoid singleton `Actor.instance`, which is not testable and bad code smell

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#13 - Add code comments to public API code

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 4 comments
Labels: wontfix

#12 - Remove all unconditionally-trigger-refresh hack, such as `dummy++`, and create real when-to-refresh logic

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 3 comments

#11 - Clean up code by removing unneeded comments and outdated code

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#10 - Copy all discussions into the repo as an archive

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 5 comments

#9 - Rename to more friendly API, such as PreemptBuilder -> SmoothBuilder

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#8 - Refactor the code to make it much cleaner (currently some components are messed together)

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 1 comment

#7 - Add unit and widget tests to existing library code

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 4 comments

#6 - Add documentation to `README.md`

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#5 - Configure GitHub CI (need to wait until flutter/flutter and flutter/engine PRs are merged)

Issue - State: open - Opened by fzyzcjy about 2 years ago - 4 comments

#4 - Configure standard things for a GitHub repository

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#3 - Move the `old/` code to `smooth/`, and distinguish example and library

Issue - State: closed - Opened by fzyzcjy about 2 years ago

#2 - Make the migrated code run successfully

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 2 comments

#1 - Copy source code from `fzyzcjy/flutter` to here, preserving git commit history

Issue - State: closed - Opened by fzyzcjy about 2 years ago - 5 comments

GitHub / fzyzcjy/flutter_smooth issues and pull requests