dominikh/go-staticcheck issues and pull requests

#73 - Ignoring instances of SA4006

Issue - State: closed - Opened by nicksnyder over 7 years ago - 2 comments
Labels: enhancement

#72 - WIP: sync.Pool accepts a argument of size word, not only pointers

Pull Request - State: closed - Opened by bradleyfalzon over 7 years ago - 1 comment

#71 - Read and incorporate http://www.viva64.com/en/b/0466/

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: research

#70 - Checks equivalent to Aspirator

Issue - State: closed - Opened by doherty over 7 years ago - 1 comment
Labels: research

#69 - SA4017 doesn't flag unused return value of *net/http.Request.WithContext()

Issue - State: closed - Opened by bubaflub over 7 years ago - 2 comments
Labels: enhancement

#68 - Ticker not stopped

Issue - State: closed - Opened by judwhite over 7 years ago - 2 comments
Labels: enhancement

#67 - Detect invocations of os.Exit in func assigned to flag.Usage or flag.FlagSet.Usage.

Issue - State: closed - Opened by dmitshur over 7 years ago - 1 comment
Labels: enhancement

#66 - Don't inspect synthetic functions

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: bug

#65 - SA5006 triggers when ranging over slice of size 0

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: bug, VRP

#64 - Detect bytes.Equal used on net.IP instead of net.IP.Equal

Issue - State: closed - Opened by FiloSottile over 7 years ago - 2 comments
Labels: enhancement

#63 - detect math.Pow() with small positive constants

Issue - State: closed - Opened by dgryski over 7 years ago - 4 comments
Labels: enhancement

#62 - SA1015: infinite loop detection not working for closures

Issue - State: closed - Opened by FiloSottile over 7 years ago - 4 comments
Labels: bug

#61 - Don't report discarded pure function results in benchmarks

Issue - State: closed - Opened by dominikh over 7 years ago - 3 comments
Labels: enhancement

#60 - SA2002 (T.Fatal called in non-main goroutine) can be fooled by depth

Issue - State: closed - Opened by tamird over 7 years ago - 1 comment
Labels: enhancement

#59 - os.Exit(0) should be a return in main()

Issue - State: closed - Opened by mvdan over 7 years ago - 3 comments

#58 - request: allow callsites to opt-out of certain rules

Issue - State: closed - Opened by dt over 7 years ago - 1 comment

#57 - vrp: support propagating ranges backwards

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP

#56 - VRP: support declaring function's return value as a function of one of its inputs

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP

#55 - improve performance

Issue - State: closed - Opened by dominikh over 7 years ago - 14 comments
Labels: enhancement, started

#54 - Detect useless continue/break statements

Issue - State: closed - Opened by mvdan over 7 years ago
Labels: enhancement

#53 - Avoid flagging the same mistake twice

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#52 - Detect 0775, 0755, 0664, 0644 os.FileModes

Issue - State: closed - Opened by bradleyfalzon over 7 years ago - 3 comments
Labels: enhancement

#51 - Detect non-octal literal os.FileMode

Issue - State: closed - Opened by FiloSottile over 7 years ago
Labels: enhancement

#50 - staticcheck -h still runs the linter

Issue - State: closed - Opened by mvdan over 7 years ago - 1 comment
Labels: bug

#49 - Flag strings.Replace with n == 0

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#48 - Go 1.8 supports bool type in binary.{Read,Write}

Pull Request - State: closed - Opened by bradleyfalzon over 7 years ago - 5 comments
Labels: enhancement

#47 - Detect `math.Ceil(float64(anInteger))`

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#46 - Detect branches with identical code

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: enhancement

#45 - Detect noop bitwise operations

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#44 - Detect discarded return value of pure functions

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#43 - VRP: support channels

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP

#42 - Use VRP information in CheckSliceOutOfBounds

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: enhancement, VRP

#41 - Detect if/else if chains with duplicate conditions

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#40 - Detect double `!!`

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#39 - Check sequential tests with identical conditions

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: enhancement

#38 - Be added to gometalinter

Issue - State: closed - Opened by santagada over 7 years ago - 4 comments

#37 - VRP: implement all arithmetic operators

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP

#36 - VRP: support slices

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP, started

#35 - VRP: support pointers

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP

#34 - VRP: support strings

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: VRP, started

#33 - VRP: special cases for the standard library

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP, started

#32 - VRP: Get tighter ranges when integer overflow occurs

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: VRP

#31 - WIP: Check for sufficient channel buffer size for signals being trapped

Pull Request - State: closed - Opened by bradleyfalzon over 7 years ago - 4 comments

#30 - Check if channel provided to signal.Notify has sufficient buffer

Issue - State: closed - Opened by bradleyfalzon over 7 years ago
Labels: enhancement

#29 - Check for trapping untrappable signals

Pull Request - State: closed - Opened by bradleyfalzon over 7 years ago
Labels: enhancement

#28 - document minimum Go version

Issue - State: closed - Opened by kevinburke over 7 years ago - 2 comments
Labels: invalid

#27 - SA4005 - is a pointer OK

Issue - State: closed - Opened by kevinburke over 7 years ago - 4 comments
Labels: question

#26 - Consider flagging signal.Notify(..., os.Kill, ...)

Issue - State: closed - Opened by dominikh over 7 years ago - 7 comments
Labels: enhancement

#25 - SA4006: false positive on unused variable

Issue - State: closed - Opened by dsnet over 7 years ago - 1 comment
Labels: invalid

#24 - fmt.Errorf with no formatting arguments - should use errors.New instead

Issue - State: closed - Opened by kevinburke over 7 years ago - 2 comments

#23 - Support more scenarios in SA1001

Issue - State: closed - Opened by dominikh over 7 years ago
Labels: enhancement

#22 - SA1001 doesn't account for Delims

Issue - State: closed - Opened by titanous over 7 years ago
Labels: bug

#21 - Detect value type being passed to json.Unmarshal v parameter

Issue - State: closed - Opened by bradleyfalzon over 7 years ago
Labels: enhancement

#20 - Detect leaky use of time.Tick

Issue - State: closed - Opened by bradleyfalzon over 7 years ago - 3 comments
Labels: enhancement

#19 - Check for return statements before mutex unlock

Pull Request - State: closed - Opened by vcabbage over 7 years ago - 4 comments

#18 - nil crash in append check

Issue - State: closed - Opened by riking over 7 years ago - 5 comments
Labels: bug

#17 - Detect type inconsistencies

Issue - State: closed - Opened by FiloSottile over 7 years ago - 2 comments
Labels: enhancement

#16 - "defer rc.Close() or similar" check doesn't detect bad calls of Close() on nested fields.

Issue - State: closed - Opened by dmitshur over 7 years ago
Labels: enhancement

#15 - Check for alignment of variables used in atomic access.

Issue - State: closed - Opened by dgryski over 7 years ago - 1 comment
Labels: enhancement

#14 - Detect assignment to b.N

Issue - State: closed - Opened by dominikh over 7 years ago - 1 comment
Labels: enhancement

#13 - Weirdness under go v1.7

Issue - State: closed - Opened by charl almost 8 years ago - 2 comments
Labels: invalid

#12 - Fix DeferInChannelRangeLoop nil pointer

Pull Request - State: closed - Opened by bradleyfalzon almost 8 years ago - 3 comments

#11 - Add a check for non-pointer types in sync.Pool.Put

Pull Request - State: closed - Opened by bradleyfalzon almost 8 years ago - 2 comments

#10 - Add check for non-pointers stored within sync.Pool

Issue - State: closed - Opened by rasky almost 8 years ago - 3 comments
Labels: enhancement

#9 - panic: New already declared

Issue - State: closed - Opened by broady almost 8 years ago - 9 comments
Labels: invalid

#8 - Check for pointer value pointer and related bad copy attempts

Pull Request - State: closed - Opened by bradleyfalzon about 8 years ago

#7 - Implementing empty critical section check

Pull Request - State: closed - Opened by MohamedBassem about 8 years ago - 8 comments

#6 - (suggestion) check filepath.Walk misusage

Issue - State: closed - Opened by AkihiroSuda about 8 years ago - 5 comments

#5 - Remove some sync.WaitGroup checks

Issue - State: closed - Opened by dominikh about 8 years ago

#4 - Check constant url.Parse arguments

Issue - State: closed - Opened by dominikh about 8 years ago
Labels: enhancement

#3 - Detect certain always true/false conditions

Issue - State: closed - Opened by dominikh about 8 years ago
Labels: enhancement

#2 - Considered trying to get this in to golint or `go vet`?

Issue - State: closed - Opened by JensRantil about 8 years ago - 2 comments
Labels: question

#1 - Flag uses of time.Sleep with suspiciously small, untyped delay

Issue - State: closed - Opened by dominikh about 8 years ago
Labels: enhancement

GitHub / dominikh/go-staticcheck issues and pull requests