dart-lang/dart_style issues and pull requests

#1463 - Not really happy with the indentation in a specific combination of language features

Issue - State: closed - Opened by escamoteur 5 months ago - 8 comments

#1462 - Migrate regression/0300/

Pull Request - State: closed - Opened by munificent 5 months ago

#1461 - [tall] Incorrect indentation with multiple annotations on a parameter

Issue - State: closed - Opened by munificent 5 months ago
Labels: rare, easy, safe, wrong, tall

#1460 - Migrate regression/0200/

Pull Request - State: closed - Opened by munificent 5 months ago

#1459 - Migrate regression/0100/

Pull Request - State: closed - Opened by munificent 5 months ago

#1458 - Migrate regression/0000/

Pull Request - State: closed - Opened by munificent 5 months ago

#1457 - Add a couple of regression tests for examples from Jake.

Pull Request - State: closed - Opened by munificent 5 months ago

#1456 - Ignore warnings from deprecated analyzer APIs for now.

Pull Request - State: closed - Opened by munificent 5 months ago

#1455 - Bind pieces based on page width during formatting.

Pull Request - State: closed - Opened by munificent 5 months ago

#1454 - Bump dart-lang/setup-dart from 1.6.2 to 1.6.4

Pull Request - State: closed - Opened by dependabot[bot] 5 months ago - 2 comments
Labels: infrastructure

#1453 - Bump actions/checkout from 4.1.2 to 4.1.4

Pull Request - State: closed - Opened by dependabot[bot] 5 months ago - 2 comments
Labels: infrastructure

#1452 - `analyzer-6.5.0` breaks `dart_style-2.3.2`

Issue - State: closed - Opened by ditman 5 months ago - 2 comments

#1451 - Chunky pieces! Aggregate multiple tokens into single CodePieces.

Pull Request - State: closed - Opened by munificent 5 months ago - 2 comments

#1450 - Add a utility script for benchmarking and profiling a directory.

Pull Request - State: closed - Opened by munificent 5 months ago

#1449 - Don't apply the page width optimization to already pinned pieces.

Pull Request - State: closed - Opened by munificent 5 months ago

#1448 - Don't allow splitting in interpolation expressions.

Pull Request - State: closed - Opened by munificent 5 months ago - 1 comment

#1447 - Take leading indentation into account when constraining by page width.

Pull Request - State: closed - Opened by munificent 5 months ago - 1 comment

#1446 - Make it easier to run and compare multiple benchmarks.

Pull Request - State: closed - Opened by munificent 5 months ago

#1445 - Add some manual profiling instrumentation.

Pull Request - State: closed - Opened by munificent 5 months ago

#1444 - Don't allow function calls to be block arguments.

Pull Request - State: closed - Opened by munificent 5 months ago

#1443 - Format named constructor calls in enum value constructors.

Pull Request - State: closed - Opened by munificent 5 months ago

#1442 - Format `with` and `implements` in enum declarations.

Pull Request - State: closed - Opened by munificent 5 months ago

#1441 - This indentation is very unsightly

Issue - State: closed - Opened by niuxinyu 5 months ago - 2 comments

#1440 - Better code formatting for flow controls in Maps

Issue - State: open - Opened by escamoteur 5 months ago - 3 comments

#1439 - Simplify AssignPiece.

Pull Request - State: closed - Opened by munificent 6 months ago

#1438 - Remove pushAllowNewlines() and popAllowNewlines() from CodeWriter.

Pull Request - State: closed - Opened by munificent 6 months ago

#1437 - Remove some unneeded code and update a doc comment.

Pull Request - State: closed - Opened by munificent 6 months ago

#1436 - Bump actions/checkout from 4.1.1 to 4.1.2

Pull Request - State: closed - Opened by dependabot[bot] 6 months ago
Labels: infrastructure, autosubmit

#1435 - Add some regression tests from the old prototype.

Pull Request - State: closed - Opened by munificent 6 months ago

#1434 - Use NodeContext for all downwards contextual formatting.

Pull Request - State: closed - Opened by munificent 6 months ago

#1433 - Allow comments before infix expressions to not split the operator.

Pull Request - State: closed - Opened by munificent 6 months ago

#1432 - Rework how comments are represented in the Piece model

Pull Request - State: closed - Opened by munificent 6 months ago

#1431 - Don't indent split binary operands in an assignment-like context.

Pull Request - State: closed - Opened by munificent 6 months ago

#1430 - Indent comments inside switch statement cases.

Pull Request - State: closed - Opened by munificent 6 months ago

#1429 - Weird indentation and splitting when comment appears before cascade setter

Issue - State: closed - Opened by munificent 6 months ago
Labels: common, easy, safe, bad

#1428 - Tweak the call chain splitting rules.

Pull Request - State: closed - Opened by munificent 7 months ago

#1427 - Prefer splitting at ".." instead of in the cascade target.

Pull Request - State: closed - Opened by munificent 7 months ago

#1426 - Update tool/test_updater.dart to handle the tall style and test changes.

Pull Request - State: closed - Opened by munificent 7 months ago

#1425 - Format code with 4 spaces

Issue - State: closed - Opened by nmtitov 7 months ago - 6 comments

#1424 - Handle trailing commas in catches

Issue - State: closed - Opened by munificent 7 months ago - 3 comments

#1423 - Reorganize the sources and tests to split out the short and tall files.

Pull Request - State: closed - Opened by munificent 7 months ago

#1422 - Tweak the block formatting rules to disallow `=>` function expressions.

Pull Request - State: closed - Opened by munificent 7 months ago

#1421 - Support leading indentation in the new style.

Pull Request - State: closed - Opened by munificent 7 months ago

#1420 - Preserve newlines (or lack of) in collections with line comments.

Pull Request - State: closed - Opened by munificent 7 months ago

#1419 - Test that benchmarks produce their expected output.

Pull Request - State: closed - Opened by munificent 7 months ago

#1418 - Force list, set, and maps to split if they are nested.

Pull Request - State: closed - Opened by munificent 7 months ago

#1417 - Migrate a couple more stragglers.

Pull Request - State: closed - Opened by munificent 7 months ago

#1416 - Require analyzer 6.3.0 and remove corresponding hack.

Pull Request - State: closed - Opened by munificent 7 months ago

#1415 - Tall style: Preserve blank line between line comments and subsequent code?

Issue - State: closed - Opened by munificent 7 months ago - 5 comments
Labels: tall

#1414 - Fix compile error when using dart_style with analyzer 6.2.0.

Pull Request - State: closed - Opened by munificent 7 months ago - 1 comment

#1413 - dart_style `2.3.5` throws when running `build_runner`

Issue - State: closed - Opened by vkammerer 7 months ago - 6 comments
Labels: bug

#1412 - Get ready to publish 2.3.5.

Pull Request - State: closed - Opened by munificent 7 months ago - 4 comments

#1411 - Migrate more tests over to the new style.

Pull Request - State: closed - Opened by munificent 7 months ago

#1410 - Fix a crash and some formatting bugs in cascades.

Pull Request - State: closed - Opened by munificent 7 months ago

#1409 - Fix two bugs around pinned states in the Solver and SolutionCache.

Pull Request - State: closed - Opened by munificent 7 months ago

#1408 - Tweak the heuristics on which expressions allow block formatting.

Pull Request - State: closed - Opened by munificent 7 months ago

#1407 - Don't eagerly bind pinned Pieces in Solution.

Pull Request - State: closed - Opened by munificent 7 months ago

#1406 - For loop metadata

Pull Request - State: closed - Opened by munificent 7 months ago - 1 comment

#1405 - Force switch expressions to split if they contain a line comment.

Pull Request - State: closed - Opened by munificent 7 months ago

#1404 - dart format produce invalid code

Issue - State: closed - Opened by nielsenko 7 months ago - 2 comments
Labels: bug, common, bad

#1403 - Tall style implementation

Issue - State: open - Opened by munificent 7 months ago
Labels: meta

#1402 - Make the formatter aware of the language version of what it's formatting

Issue - State: closed - Opened by munificent 7 months ago - 17 comments
Labels: enhancement

#1401 - Add more tests for type arguments in object patterns and remove a TODO.

Pull Request - State: closed - Opened by munificent 7 months ago - 2 comments

#1400 - Remove TODO about non-inline block comments.

Pull Request - State: closed - Opened by munificent 7 months ago

#1399 - Remove TODO that's already TODONE.

Pull Request - State: closed - Opened by munificent 7 months ago

#1398 - Migrate more tests to the new style and reorganize some.

Pull Request - State: closed - Opened by munificent 7 months ago

#1397 - Test that the new style doesn't keep line comments flush left.

Pull Request - State: closed - Opened by munificent 7 months ago - 1 comment

#1396 - Format relational, null-check, and null-assert patterns.

Pull Request - State: closed - Opened by munificent 7 months ago

#1395 - Format null asserts, null checks, and relational patterns.

Pull Request - State: closed - Opened by kallentu 7 months ago - 2 comments

#1394 - Format pattern assignment expressions.

Pull Request - State: closed - Opened by munificent 7 months ago

#1393 - Drop node bits

Pull Request - State: closed - Opened by kevmoo 7 months ago - 3 comments

#1392 - Format pattern variable declarations, including in for loops.

Pull Request - State: closed - Opened by munificent 7 months ago - 1 comment

#1391 - Bump js from 0.6.7 to 0.7.1

Pull Request - State: closed - Opened by dependabot[bot] 7 months ago - 1 comment
Labels: infrastructure

#1390 - Accessibility problem: indent forces 2 spaces instead of 4

Issue - State: closed - Opened by tgrushka 7 months ago - 1 comment

#1389 - Remove parsing time from benchmark and support comparing to a baseline.

Pull Request - State: closed - Opened by munificent 8 months ago

#1388 - Format cast pattern.

Pull Request - State: closed - Opened by kallentu 8 months ago

#1387 - Format extension types.

Pull Request - State: closed - Opened by munificent 8 months ago

#1386 - Format metadata annotations.

Pull Request - State: closed - Opened by munificent 8 months ago

#1385 - Format object patterns.

Pull Request - State: closed - Opened by kallentu 8 months ago - 1 comment

#1384 - Migrate constant pattern tests to tall formatter.

Pull Request - State: closed - Opened by kallentu 8 months ago

#1383 - Format guard clauses in switches.

Pull Request - State: closed - Opened by munificent 8 months ago

#1382 - Fill in a bunch of corners of if-case and patterns.

Pull Request - State: closed - Opened by munificent 8 months ago

#1381 - Add logic comment tests.

Pull Request - State: closed - Opened by kallentu 8 months ago - 2 comments

#1380 - Format logic and parenthesized patterns

Pull Request - State: closed - Opened by munificent 8 months ago

#1379 - Prefer any valid solution over an invalid one, regardless of overflow.

Pull Request - State: closed - Opened by munificent 8 months ago - 1 comment

#1378 - Pin Pieces if we can determine they will split just by their children.

Pull Request - State: closed - Opened by munificent 8 months ago

#1377 - Fix bug in subtree merging cost calculation.

Pull Request - State: closed - Opened by munificent 8 months ago - 1 comment

#1376 - Solve subtrees separately

Pull Request - State: closed - Opened by munificent 8 months ago

#1375 - Support multiple benchmarks.

Pull Request - State: closed - Opened by munificent 8 months ago

#1374 - Bump dart-lang/setup-dart from 1.6.0 to 1.6.2

Pull Request - State: closed - Opened by dependabot[bot] 8 months ago
Labels: infrastructure, autosubmit

#1373 - Reorganize how Solution handles pinned states and constraints.

Pull Request - State: closed - Opened by munificent 8 months ago

#1372 - Prune solutions derived from invalid ones.

Pull Request - State: closed - Opened by munificent 8 months ago - 3 comments

#1371 - Format record pattern.

Pull Request - State: closed - Opened by kallentu 8 months ago - 1 comment

#1370 - Update benchmark script to support running tall style formatter.

Pull Request - State: closed - Opened by munificent 8 months ago

#1370 - Update benchmark script to support running tall style formatter.

Pull Request - State: open - Opened by munificent 8 months ago

#1369 - Combine SequencePiece and BlockPiece.

Pull Request - State: closed - Opened by munificent 8 months ago

#1369 - Combine SequencePiece and BlockPiece.

Pull Request - State: open - Opened by munificent 8 months ago

#1368 - Format map patterns.

Pull Request - State: closed - Opened by kallentu 8 months ago

#1368 - Format map patterns.

Pull Request - State: open - Opened by kallentu 8 months ago

#1367 - Fix bug where solver looks at the last piece on line instead of first.

Pull Request - State: closed - Opened by munificent 8 months ago

GitHub / dart-lang/dart_style issues and pull requests