cyfrin/2023-07-foundry-defi-stablecoin issues and pull requests

#101 - When an user calls liquidate(), s_DSCMinted mapping is not correctly updated

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 3 comments
Labels: high

#101 - When an user calls liquidate(), s_DSCMinted mapping is not correctly updated

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 3 comments
Labels: high

#100 - Hardcoded timeout for considering price as the stale may block users using the protocol for some tokens used as deposit

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: high, finding-oracle-hard-timeout

#99 - Data returned by `latestRoundData` not checked enough in order to determinate if price is stale

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, ai-dup-970, ai-dup-537, ai-dup-312, ai-dup-152, ai-dup-75, finding-oracle-stale

#98 - Perform a division before a multiply

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, ai-dup-917, ai-dup-706, ai-dup-102, ai-dup-78, ai-dup-890, ai-dup-691, ai-dup-412, ai-dup-315, finding-precision-loss-division

#98 - Perform a division before a multiply

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, ai-dup-917, ai-dup-706, ai-dup-102, ai-dup-78, ai-dup-890, ai-dup-691, ai-dup-412, ai-dup-315, finding-precision-loss-division

#97 - Inefficient Loop Condition in getAccountCollateralValue

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-760, ai-dup-723

#97 - Inefficient Loop Condition in getAccountCollateralValue

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-760, ai-dup-723

#96 - DSCEngineTest contract name re-used

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low, ai-dup-946

#96 - DSCEngineTest contract name re-used

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low, ai-dup-946

#95 - isAllowedToken modifier

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: gas

#95 - isAllowedToken modifier

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: gas

#94 - DSCEngine Constructor

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#94 - DSCEngine Constructor

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#93 - moreThanZero modifier

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, finding-amount-not-smaller-than-zero-i

#93 - moreThanZero modifier

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, finding-amount-not-smaller-than-zero-i

#92 - `burn()` and `staleCheckLatestRoundData()` and `getTimeout()` can be `external`

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, selected, finding-burn-external-g

#92 - `burn()` and `staleCheckLatestRoundData()` and `getTimeout()` can be `external`

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, selected, finding-burn-external-g

#91 - Centralized Ownership - mint()

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: medium

#91 - Centralized Ownership - mint()

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: medium

#90 - OnlyOwner modifier

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#90 - OnlyOwner modifier

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#89 - Remove useless `_revertIfHealthFactorIsBroken` check to save gas

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-71, finding-needless-health-check

#89 - Remove useless `_revertIfHealthFactorIsBroken` check to save gas

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-71, finding-needless-health-check

#88 - Missing safety check on `liquidate()`

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#87 - Chainlink oracle will return the wrong price if the aggregator hits `minPrice`

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, ai-dup-570, ai-dup-314, ai-dup-269, ai-dup-739, ai-dup-272, ai-dup-777, ai-dup-132, ai-dup-519, finding-oracle-stale

#86 - 1111111

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#86 - 1111111

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#85 - `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-1060, ai-dup-887, ai-dup-717, ai-dup-646, ai-dup-303, ai-dup-1139, finding-unchecked++-g

#85 - `++i`/`i++` should be `unchecked{++i}`/`unchecked{i++}` when it is not possible for them to overflow, as is the case when used in `for`- and `while`-loops

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-1060, ai-dup-887, ai-dup-717, ai-dup-646, ai-dup-303, ai-dup-1139, finding-unchecked++-g

#84 - adsdas

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#84 - adsdas

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#83 - Solidity version 0.8.20 may not work on other chains due to `PUSH0`

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, ai-dup-432, ai-dup-126, ai-dup-639, finding-bad-solc

#83 - Solidity version 0.8.20 may not work on other chains due to `PUSH0`

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, ai-dup-432, ai-dup-126, ai-dup-639, finding-bad-solc

#82 - Cache storage variables

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: gas

#82 - Cache storage variables

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: gas

#81 - `Unchecked` block

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-360, finding-unchecked++-g

#80 - `_amount == 0` instead of `_amount <= 0` saves gas

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-amount-not-smaller-than-zero-i

#80 - `_amount == 0` instead of `_amount <= 0` saves gas

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-amount-not-smaller-than-zero-i

#79 - Uint cannot be less than 0

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-amount-not-smaller-than-zero-i

#79 - Uint cannot be less than 0

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-amount-not-smaller-than-zero-i

#78 - Rounding error in calculation _calculateHealthFactor()

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, ai-dup-1022, ai-dup-948, ai-dup-917, ai-dup-736, ai-dup-706, ai-dup-554, ai-dup-505, ai-dup-359, ai-dup-98, finding-precision-loss-division

#78 - Rounding error in calculation _calculateHealthFactor()

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, ai-dup-1022, ai-dup-948, ai-dup-917, ai-dup-736, ai-dup-706, ai-dup-554, ai-dup-505, ai-dup-359, ai-dup-98, finding-precision-loss-division

#77 - System can have un-liquidatable loans even while solvent.

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: high, finding-liquidate-110

#77 - System can have un-liquidatable loans even while solvent.

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: high, finding-liquidate-110

#76 - Uncorrect NetSpect comment format

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#76 - Uncorrect NetSpect comment format

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#75 - Incomplete check for stale data from Chainlink Aggregator inside staleCheckLatestRoundData()

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, ai-dup-1036, ai-dup-1017, ai-dup-856, ai-dup-700, ai-dup-695, ai-dup-603, ai-dup-537, ai-dup-515, ai-dup-332, ai-dup-312, ai-dup-299, ai-dup-275, ai-dup-264, ai-dup-152, ai-dup-55, ai-dup-660, ai-dup-138, ai-dup-99, finding-oracle-stale

#75 - Incomplete check for stale data from Chainlink Aggregator inside staleCheckLatestRoundData()

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, ai-dup-1036, ai-dup-1017, ai-dup-856, ai-dup-700, ai-dup-695, ai-dup-603, ai-dup-537, ai-dup-515, ai-dup-332, ai-dup-312, ai-dup-299, ai-dup-275, ai-dup-264, ai-dup-152, ai-dup-55, ai-dup-660, ai-dup-138, ai-dup-99, finding-oracle-stale

#74 - Collateral/Debt balance solvency manipulation

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#74 - Collateral/Debt balance solvency manipulation

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#73 - `DSCEngine` miscalculates the USD value of tokens with other than 18 decimals.

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: high, ai-dup-400, finding-collateral-decimal

#73 - `DSCEngine` miscalculates the USD value of tokens with other than 18 decimals.

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: high, ai-dup-400, finding-collateral-decimal

#72 - Liquidations do not work when collateralization ratio is below liquidation premium.

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, finding-liquidate-110

#71 - Useless check can be removed to save gas

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-89, finding-needless-health-check-burn

#70 - Add check to burnDsc to unsure user isn't burning his Dsc by mistake

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#69 - Liquidations allow for too much debt to be paid back.

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 5 comments
Labels: high, selected

#69 - Liquidations allow for too much debt to be paid back.

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 5 comments
Labels: high, selected

#68 - mintDsc and depositCollateral don't follow CEI

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#68 - mintDsc and depositCollateral don't follow CEI

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#67 - No amountCollateral > balance check

Issue - State: open - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: selected, finding-error-insufficient-collateral-i, info

#67 - No amountCollateral > balance check

Issue - State: open - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: selected, finding-error-insufficient-collateral-i, info

#66 - Unnecessary comparison on parameters of type uint256

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-amount-not-smaller-than-zero-i

#66 - Unnecessary comparison on parameters of type uint256

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-amount-not-smaller-than-zero-i

#65 - No tokenCollateralAddress check

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#65 - No tokenCollateralAddress check

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: low

#64 - DSCEngine__NotAllowedToken

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-error-allowed-token-i

#64 - DSCEngine__NotAllowedToken

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, finding-error-allowed-token-i

#63 - modifier isAllowedToken could be used in more places to prevent underflow revert and provide gas optimization

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, finding-error-insufficient-collateral-i

#63 - modifier isAllowedToken could be used in more places to prevent underflow revert and provide gas optimization

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, finding-error-insufficient-collateral-i

#62 - redeemCollateralForDsc

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#62 - redeemCollateralForDsc

Issue - State: closed - Opened by codehawks-bot over 1 year ago
Labels: high

#61 - Increments can be unchecked in for-loops

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: gas, ai-dup-735, finding-unchecked++-g

#60 - Unneccessary health check stops users from lowering their debt.

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: medium

#60 - Unneccessary health check stops users from lowering their debt.

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: medium

#59 - _revertIfHealthFactorIsBroken(msg.sender) on burnDsc will revert when user try to make his healthFactor grow

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, finding-needless-health-check-burn

#59 - _revertIfHealthFactorIsBroken(msg.sender) on burnDsc will revert when user try to make his healthFactor grow

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: low, finding-needless-health-check-burn

#58 - `DSCEngine` is incompatible with ERC20 that do not return a `bool`.

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: medium, ai-dup-502, finding-transfer

#58 - `DSCEngine` is incompatible with ERC20 that do not return a `bool`.

Issue - State: closed - Opened by codehawks-bot over 1 year ago - 1 comment
Labels: medium, ai-dup-502, finding-transfer

#57 - Price feed is assumed to always return value with 8 decimals

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, finding-oracle-price-decimal

#56 - staleCheckLatestRoundData

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, finding-oracle-stale

#56 - staleCheckLatestRoundData

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, finding-oracle-stale

#55 - 'staleCheckLatestRoundData()' does not check for round completeness

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, ai-dup-1082, ai-dup-1036, ai-dup-1017, ai-dup-970, ai-dup-856, ai-dup-700, ai-dup-695, ai-dup-603, ai-dup-537, ai-dup-515, ai-dup-472, ai-dup-332, ai-dup-312, ai-dup-299, ai-dup-275, ai-dup-264, ai-dup-189, ai-dup-152, ai-dup-1095, ai-dup-842, ai-dup-649, ai-dup-130, ai-dup-75, ai-dup-660, ai-dup-138, ai-dup-324, finding-oracle-stale

#55 - 'staleCheckLatestRoundData()' does not check for round completeness

Issue - State: open - Opened by codehawks-bot over 1 year ago
Labels: medium, ai-dup-1082, ai-dup-1036, ai-dup-1017, ai-dup-970, ai-dup-856, ai-dup-700, ai-dup-695, ai-dup-603, ai-dup-537, ai-dup-515, ai-dup-472, ai-dup-332, ai-dup-312, ai-dup-299, ai-dup-275, ai-dup-264, ai-dup-189, ai-dup-152, ai-dup-1095, ai-dup-842, ai-dup-649, ai-dup-130, ai-dup-75, ai-dup-660, ai-dup-138, ai-dup-324, finding-oracle-stale

GitHub / cyfrin/2023-07-foundry-defi-stablecoin issues and pull requests