crystal-ameba/ameba issues and pull requests

#389 - Error on macro expansion when building with Crystal 1.9.0

Issue - State: closed - Opened by mrexox over 1 year ago - 2 comments

#388 - Providing an invalid file path should raise instead of silently ignoring it

Issue - State: open - Opened by jwoertink over 1 year ago - 7 comments
Labels: bug

#387 - Add `Performance/MinMaxAfterMap` rule

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: rule

#386 - Add `Performance/ExcessiveAllocations` rule

Pull Request - State: closed - Opened by Sija over 1 year ago - 1 comment
Labels: rule

#385 - Excessive allocations

Issue - State: closed - Opened by Sija over 1 year ago
Labels: rule

#384 - Fix `Style/VerboseBlock` rule to work with binary operations

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: bug, rule

#383 - correctable error results in invalid crystal

Issue - State: closed - Opened by stakach over 1 year ago
Labels: bug, rule

#382 - [Feature request]: Json output

Issue - State: closed - Opened by meatball133 over 1 year ago - 1 comment

#381 - Add `Lint/Typos` rule

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: rule

#380 - Add `Lint/DocumentationAdmonition` rule

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: rule

#379 - Several tweaks and refactors

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: refactor, rule

#378 - Add `AST::NodeVisitor::Category` simplifying code a bit

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: refactor

#377 - Installation failing on windows CI

Issue - State: closed - Opened by wout over 1 year ago - 1 comment

#376 - Fix specs against Crystal nightly

Pull Request - State: closed - Opened by Sija over 1 year ago - 2 comments

#374 - Add `Lint/Documentation` rule

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: documentation, rule

#373 - Raise when empty severity provided to `SeverityYamlConverter.from_yaml`

Pull Request - State: closed - Opened by Sija over 1 year ago
Labels: bug

#372 - Issue with Crystal Nightly

Issue - State: closed - Opened by mamantoha over 1 year ago - 12 comments

#371 - Specs fail with Crystal 1.8.1

Issue - State: closed - Opened by manveru over 1 year ago - 3 comments

#370 - Ameba seems to incorrectly show what the line that needs fixing is

Issue - State: closed - Opened by weirdbricks over 1 year ago - 5 comments
Labels: wontfix

#369 - Update Dockerfile for Crystal 1.8 + check if binary works

Pull Request - State: closed - Opened by daliborfilus over 1 year ago

#368 - Support Windows postinstall

Issue - State: closed - Opened by devnote-dev over 1 year ago - 2 comments
Labels: infrastructure

#367 - Outdated docker hub image

Issue - State: closed - Opened by hugopl over 1 year ago - 6 comments

#366 - Fix severity type for YAML converter spec

Pull Request - State: closed - Opened by straight-shoota over 1 year ago

#365 - excludes files for all rules

Issue - State: closed - Opened by noraj over 1 year ago - 2 comments
Labels: question

#364 - CyclomaticComplexity on SQL?

Issue - State: closed - Opened by jwoertink over 1 year ago - 2 comments

#363 - Skip all config when use with --gen-config.

Pull Request - State: closed - Opened by zw963 over 1 year ago
Labels: bug

#362 - Providing invalid config file path should raise instead of silently ignoring it

Issue - State: closed - Opened by Sija over 1 year ago - 1 comment
Labels: bug

#361 - Support hierarchical loading of the config file

Pull Request - State: closed - Opened by Sija over 1 year ago - 5 comments
Labels: feature

#360 - `Style/ParenthesesAroundCondition`: Redundant parentheses check assign.

Issue - State: closed - Opened by zw963 over 1 year ago - 2 comments

#359 - undefined constant Crystal::ThreadLocalValue on Windows

Issue - State: closed - Opened by jwoertink over 1 year ago - 4 comments

#357 - fix(style): correct typo in `Style/ParenthesesAroundCondition` rule doc

Pull Request - State: closed - Opened by veelenga over 1 year ago
Labels: bug, documentation, rule

#356 - chore: fix crystal-nightly compatibility

Pull Request - State: closed - Opened by veelenga over 1 year ago - 4 comments
Labels: refactor

#355 - fix(lint): `Lint/UnusedBlockArgument` is triggered by abstract def

Pull Request - State: closed - Opened by veelenga over 1 year ago - 1 comment
Labels: bug, rule

#354 - Invalid memory access on Alpine Linux

Issue - State: closed - Opened by snacks02 almost 2 years ago - 12 comments
Labels: infrastructure

#353 - Using `loop do` hides `SharedVarInFiber` warning

Issue - State: closed - Opened by wwalker almost 2 years ago
Labels: bug, rule

#352 - `Lint/UnusedBlockArgument` is triggered by `abstract def`

Issue - State: closed - Opened by stakach almost 2 years ago
Labels: bug

#351 - fix(lint): useless assignment for type definition

Pull Request - State: closed - Opened by veelenga almost 2 years ago - 2 comments
Labels: bug, rule

#350 - Bump docker/build-push-action from 3 to 4

Pull Request - State: closed - Opened by dependabot[bot] almost 2 years ago - 1 comment
Labels: dependencies

#349 - Remove SWUbanner

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: documentation

#348 - Remove Travis CI references from `README.md`

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: documentation

#347 - Use Crystal 1.6.x for ameba v1.4

Pull Request - State: closed - Opened by Sija almost 2 years ago

#346 - Remove gitter badge

Pull Request - State: closed - Opened by veelenga almost 2 years ago
Labels: documentation

#344 - Error: undefined constant Crystal::Keyword::BEGIN

Issue - State: closed - Opened by lstrzebinczyk almost 2 years ago - 3 comments
Labels: question

#343 - Specs broken for Crystal 1.7.0

Issue - State: closed - Opened by manveru almost 2 years ago - 2 comments

#342 - Unexpected [Lint/UselessAssign] Useless assignment to variable

Issue - State: closed - Opened by zw963 almost 2 years ago - 3 comments
Labels: bug

#341 - Remove buggy auto-correction from `Performance/AnyInsteadOfEmpty` rule

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: bug, rule

#340 - Fix CI docs workflow

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: bug, infrastructure

#339 - Tweak CI workflow + `Makefile` refactor

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: refactor, infrastructure

#338 - Build and push Docker images to GHCR

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: infrastructure

#337 - Tweak reported rule locations

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: refactor, rule

#336 - Allow skipping autocorrect from within autocorrect block

Pull Request - State: open - Opened by FnControlOption almost 2 years ago
Labels: work in progress, refactor, autocorrect

#335 - Fix regression in docs CI

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: infrastructure

#334 - Fix specs on Crystal nightly (soon to be v1.7.0)

Pull Request - State: closed - Opened by Sija almost 2 years ago - 1 comment
Labels: infrastructure

#333 - Release 1.4.0

Pull Request - State: closed - Opened by Sija almost 2 years ago - 4 comments

#332 - Update CI definitions + add @Dependabot

Pull Request - State: closed - Opened by Sija almost 2 years ago - 1 comment
Labels: infrastructure

#331 - Images on Docker Hub are not being updated

Issue - State: closed - Opened by Sija almost 2 years ago - 7 comments
Labels: infrastructure

#330 - Remove `develop` branch

Issue - State: closed - Opened by Sija almost 2 years ago - 1 comment
Labels: infrastructure

#328 - Remove OpenSSL from Docker image

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: infrastructure

#327 - Specs cleanup

Pull Request - State: closed - Opened by Sija almost 2 years ago - 2 comments
Labels: refactor

#326 - Add `Lint/Formatting` rule

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: rule

#325 - Add autocorrect for `Style/UnlessElse`

Pull Request - State: closed - Opened by FnControlOption almost 2 years ago - 4 comments
Labels: refactor, rule, autocorrect

#324 - Extend `Lint/UnusedArgument` and `Lint/UnusedBlockArgument` rules with corrections

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: refactor, rule

#323 - Make `Lint/NotNilAfterNoBang` report calls to `#rindex`

Pull Request - State: closed - Opened by Sija almost 2 years ago - 4 comments
Labels: enhancement, rule

#322 - `Lint/LiteralsComparison` not always accurate

Issue - State: closed - Opened by stakach almost 2 years ago - 1 comment
Labels: false positive

#321 - Add `Lint/MissingBlockArgument` rule

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: rule

#320 - Add `Lint/UnusedBlockArgument` rule

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: rule

#319 - Do not report anonymous block arguments in `Lint/UnusedArgument`

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: bug

#318 - False positive `Lint/LiteralsComparison` when comparing a generic type in a macro

Issue - State: closed - Opened by DanielGilchrist almost 2 years ago - 4 comments

#317 - Further refinements

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: refactor

#316 - The not_nil! warnings aren't always caught

Issue - State: closed - Opened by jwoertink almost 2 years ago - 11 comments
Labels: wontfix

#315 - Refresh readme

Pull Request - State: closed - Opened by veelenga almost 2 years ago
Labels: documentation

#314 - Add `Style/QueryBoolMethods` rule

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: rule

#313 - [Feature Request] Warn on expressions that contain logical operators but no braces

Issue - State: open - Opened by m-o-e almost 2 years ago
Labels: good first issue, rule

#312 - QoL refactors

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: refactor

#311 - Add `Severity#color`

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: enhancement

#310 - Refactor rules’ default group severity handling

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: breaking change, refactor

#309 - Make boolean rule properties generate query-style methods

Pull Request - State: closed - Opened by Sija almost 2 years ago
Labels: refactor

#307 - Add ability to work with a rule subset

Issue - State: open - Opened by veelenga almost 2 years ago
Labels: feature

#306 - Fix typos throughout the code

Pull Request - State: closed - Opened by Sija about 2 years ago

#303 - Add `Lint/LiteralAssignmentsInExpressions` rule

Pull Request - State: closed - Opened by Sija about 2 years ago - 1 comment
Labels: rule

#302 - Refactor `Style/RedundantParentheses` into more general `ParenthesesAroundCondition` rule

Pull Request - State: closed - Opened by Sija about 2 years ago
Labels: rule

#298 - Fix specs on Crystal nightly

Pull Request - State: closed - Opened by Sija about 2 years ago
Labels: infrastructure

#296 - Use `alpine:edge` for ameba builder image

Pull Request - State: closed - Opened by Sija about 2 years ago
Labels: infrastructure

#294 - Identify unintended assignment in condition

Issue - State: open - Opened by straight-shoota about 2 years ago - 1 comment
Labels: rule

#277 - Crystal 1.6 support

Pull Request - State: closed - Opened by veelenga about 2 years ago
Labels: infrastructure

#275 - [Feature Request] Search ~/.ameba.yml as a default config for current linux user.

Issue - State: closed - Opened by zw963 about 2 years ago - 12 comments
Labels: feature

#274 - Get blocked forever when run with `bin/ameba`, but it works with prebuild ameba or `bin/ameba src`.

Issue - State: closed - Opened by zw963 about 2 years ago - 7 comments
Labels: invalid

#273 - Add support of crystal 1.5

Pull Request - State: closed - Opened by veelenga about 2 years ago
Labels: infrastructure

#269 - Build ameba with MT by default

Pull Request - State: closed - Opened by carlhoerberg over 2 years ago
Labels: infrastructure

#265 - Rework inline directives

Pull Request - State: closed - Opened by veelenga over 2 years ago
Labels: feature, breaking change, refactor

#263 - Change `crystal` version constraint to `~> 1.4.0`

Pull Request - State: closed - Opened by Sija over 2 years ago
Labels: infrastructure

#259 - Crystal 1.4 compatibility

Pull Request - State: closed - Opened by veelenga over 2 years ago - 3 comments
Labels: infrastructure

#253 - Autocorrect various rules

Pull Request - State: closed - Opened by FnControlOption about 3 years ago
Labels: enhancement, autocorrect

#252 - Do not report unreachable code after loops

Pull Request - State: closed - Opened by veelenga about 3 years ago
Labels: bug

#248 - Add autocorrect

Pull Request - State: closed - Opened by FnControlOption about 3 years ago - 2 comments
Labels: feature, autocorrect

#245 - Add `expect_issue` and `expect_no_issues` spec helpers

Pull Request - State: closed - Opened by FnControlOption about 3 years ago - 7 comments
Labels: enhancement, autocorrect

#243 - [Feature Request] Produce a warning for unused methods

Issue - State: closed - Opened by caspiano about 3 years ago - 6 comments
Labels: rule

#241 - [Feature Request] Warning for undocumented public methods

Issue - State: closed - Opened by caspiano about 3 years ago - 2 comments
Labels: good first issue, rule

#233 - Don't report Trailing whitespace within a Heredoc

Issue - State: open - Opened by Blacksmoke16 over 3 years ago
Labels: false positive

#231 - Path for source files in config file should preserve relative position

Issue - State: open - Opened by veelenga over 3 years ago
Labels: bug, good first issue

GitHub / crystal-ameba/ameba issues and pull requests