cookpad/global-style-guides issues and pull requests

#98 - Remove easily misinterpreted mention of "explicitness"

Pull Request - State: closed - Opened by balvig over 6 years ago

#97 - Avoid using `before` in tests?

Issue - State: closed - Opened by sogamoso over 6 years ago - 2 comments
Labels: Icebox

#96 - Document some usages of CONSTANTS

Pull Request - State: closed - Opened by balvig over 6 years ago - 4 comments

#95 - Add conventions about testing endpoints

Pull Request - State: closed - Opened by sogamoso over 6 years ago - 4 comments

#94 - Testing, it vs example

Issue - State: closed - Opened by lewispb over 6 years ago - 4 comments

#93 - Enforce rails style indentation for private methods

Pull Request - State: closed - Opened by Knack over 6 years ago

#92 - Reorganize to focus just on styles

Pull Request - State: closed - Opened by balvig over 6 years ago - 2 comments

#91 - Proposal for re-arranging guides

Issue - State: closed - Opened by lewispb over 6 years ago - 1 comment

#90 - Add guide on bang / non-bang methods

Issue - State: closed - Opened by lewispb over 6 years ago - 7 comments
Labels: Icebox

#89 - Avoid HTML in locale file

Pull Request - State: closed - Opened by firewalker06 over 6 years ago - 1 comment

#88 - Add a guide for service objects in Rails

Pull Request - State: closed - Opened by lewispb over 6 years ago - 3 comments

#87 - Revisit "avoid trailing conditional" guide

Issue - State: closed - Opened by karlentwistle over 6 years ago - 7 comments

#86 - Propose Code Review guide improvements

Issue - State: closed - Opened by lewispb over 6 years ago - 2 comments

#85 - Preferred column types for database migrations

Issue - State: closed - Opened by lewispb over 6 years ago - 2 comments

#84 - Don't prefer Array.new(3) over 3.times.map

Pull Request - State: closed - Opened by lewispb almost 7 years ago - 8 comments

#83 - Use minutes not second when asserting results order

Pull Request - State: closed - Opened by sogamoso almost 7 years ago - 1 comment

#82 - Fix the links in the rake task section

Pull Request - State: closed - Opened by lewispb almost 7 years ago

#81 - Avoid logic in rake tasks

Pull Request - State: closed - Opened by lewispb almost 7 years ago

#80 - Disable Rails/DynamicFindBy cop

Pull Request - State: closed - Opened by balvig almost 7 years ago - 8 comments

#79 - Document variable naming convention in JS

Pull Request - State: closed - Opened by balvig almost 7 years ago

#78 - Update guides to reflect current conventions

Pull Request - State: closed - Opened by balvig almost 7 years ago - 1 comment

#77 - Document preference for RESTful controllers

Pull Request - State: closed - Opened by balvig almost 7 years ago

#76 - Best practices about memoized instance variable names

Pull Request - State: closed - Opened by Knack almost 7 years ago - 1 comment

#75 - Lint/ConditionPosition has the wrong namespace - should be Layout

Pull Request - State: closed - Opened by Knack almost 7 years ago

#74 - Disable MemoizedInstanceVariableName rule

Pull Request - State: closed - Opened by firewalker06 almost 7 years ago - 6 comments

#73 - Split Style/TrailingCommaInLiteral in rubocop

Pull Request - State: closed - Opened by firewalker06 almost 7 years ago - 2 comments

#72 - add convention for using i18n helpers in specs

Pull Request - State: closed - Opened by balvig about 7 years ago

#71 - Fix link to sample

Pull Request - State: closed - Opened by mshka about 7 years ago

#70 - Allow all our Rails environments in Rubocop

Pull Request - State: closed - Opened by davidstosik about 7 years ago - 1 comment

#69 - Inline examples and make guidelines linkable

Pull Request - State: closed - Opened by balvig about 7 years ago

#68 - What do you think about inlining best practice code examples and making each item linkable?

Issue - State: closed - Opened by balvig about 7 years ago - 5 comments

#67 - Enforce request.referrer over request.referer

Pull Request - State: closed - Opened by Knack over 7 years ago - 3 comments

#66 - avoid trailing conditionals

Pull Request - State: closed - Opened by balvig over 7 years ago - 5 comments

#65 - Add missing namespaces to RuboCop configuration

Pull Request - State: closed - Opened by Knack over 7 years ago

#64 - Remove settings for Style/OpMethod and Lint/LiteralInCondition

Pull Request - State: closed - Opened by Knack over 7 years ago

#63 - The cop InvalidCharacterLiteral has been removed

Pull Request - State: closed - Opened by Knack over 7 years ago

#62 - Revert "Rubocop: Warn about class/method length"

Pull Request - State: closed - Opened by balvig over 7 years ago - 4 comments

#61 - Add a convention for using $stdin, $stdout, $stderr

Pull Request - State: closed - Opened by JuanitoFatas over 7 years ago - 1 comment

#60 - Rubocop: Warn about class/method length

Pull Request - State: closed - Opened by Knack over 7 years ago - 6 comments

#59 - Update workflow guidelines

Pull Request - State: closed - Opened by balvig over 7 years ago

#58 - Document spec naming/length preferences

Pull Request - State: closed - Opened by balvig over 7 years ago

#57 - move rails tip to ruby section

Pull Request - State: closed - Opened by balvig over 7 years ago

#56 - Show aria-label / title examples

Pull Request - State: closed - Opened by balvig over 7 years ago

#55 - CSS: Allow shorthand of 4

Pull Request - State: closed - Opened by kinopyo over 7 years ago

#54 - The namespace of EmptyLines has changed to Layout

Pull Request - State: closed - Opened by Knack over 7 years ago

#53 - EnforcedStyle: template

Pull Request - State: closed - Opened by rikarumi over 7 years ago - 1 comment

#52 - Add Rake Tasks Section

Pull Request - State: closed - Opened by halogenandtoast over 7 years ago - 3 comments

#51 - Move style rule exclusion to global config

Pull Request - State: closed - Opened by balvig over 7 years ago

#50 - Do not push big files to GitHub

Pull Request - State: closed - Opened by davidstosik over 7 years ago - 7 comments

#49 - Mention usage of CSS classes in tests as an anti-pattern

Pull Request - State: closed - Opened by balvig over 7 years ago

#48 - Exclude special ruby files from BlockLength rule [Delivers #1prpIT5g]

Pull Request - State: closed - Opened by Knack over 7 years ago - 2 comments

#47 - Document scope preference

Pull Request - State: closed - Opened by balvig over 7 years ago

#46 - Add note about merge vs. rebase

Pull Request - State: closed - Opened by sogamoso over 7 years ago - 1 comment

#45 - Exclude HttpPositionalArguments cop for API tests

Pull Request - State: closed - Opened by balvig over 7 years ago - 2 comments

#44 - Disable SkipsModelValidations cop

Pull Request - State: closed - Opened by balvig over 7 years ago - 1 comment

#43 - Exclude routes from block rule

Pull Request - State: closed - Opened by balvig over 7 years ago - 2 comments

#42 - apply hound globally [Delivers #lLrFEWyZ]

Pull Request - State: closed - Opened by balvig over 7 years ago

#41 - Include specs in Rails/Output cop

Pull Request - State: closed - Opened by Knack over 7 years ago

#40 - move linters to guides [Delivers #50hc697n]

Pull Request - State: closed - Opened by balvig almost 8 years ago

#39 - Do not use should when describing your tests

Pull Request - State: closed - Opened by Knack almost 8 years ago

#38 - Bring in some tips from manifesto.md

Pull Request - State: closed - Opened by balvig almost 8 years ago

#37 - make guides public [Delivers #3kqK9QHF]

Pull Request - State: closed - Opened by balvig almost 8 years ago

#36 - mention usage of ternary operator in guides [Delivers #OT65zkEE]

Pull Request - State: closed - Opened by balvig almost 8 years ago

#35 - Mention current convention of creating dummy data [Delivers #PeGzsRH3]

Pull Request - State: closed - Opened by balvig almost 8 years ago

#34 - Kaizen board is now more for collecting ideas

Pull Request - State: closed - Opened by balvig almost 8 years ago

#33 - Add a guide on using data-role

Pull Request - State: closed - Opened by JuanitoFatas almost 8 years ago - 8 comments

#32 - Add i18n step to workflow

Pull Request - State: closed - Opened by l15n almost 8 years ago

#31 - Make dedicated branch for staging-mobile to share one server with all sprint teams

Issue - State: closed - Opened by y310 almost 8 years ago - 9 comments

#30 - mention usage of instance vars in controllers [Delivers #ElDG2Iel]

Pull Request - State: closed - Opened by balvig almost 8 years ago

#29 - Update code review docs to capture latest changes

Pull Request - State: closed - Opened by balvig about 8 years ago - 1 comment

#28 - Prefer `have_text` over `have_content`

Pull Request - State: closed - Opened by balvig about 8 years ago - 1 comment

#27 - Encourage other teams to use cookpad/guides

Issue - State: closed - Opened by l15n about 8 years ago - 6 comments

#26 - Prefer method invocation over instance variables

Pull Request - State: closed - Opened by JuanitoFatas about 8 years ago - 4 comments

#25 - Formalize flow for making development suggestions

Pull Request - State: closed - Opened by balvig about 8 years ago - 1 comment

#24 - Summarize recent decisions in bullet-point form

Pull Request - State: closed - Opened by balvig about 8 years ago - 7 comments

#23 - Linkify guidelines in RSpec Style Guide

Pull Request - State: closed - Opened by JuanitoFatas about 8 years ago - 4 comments

#22 - Use globalweb-api-doc to discuss and specify web API changes

Issue - State: closed - Opened by l15n about 8 years ago - 6 comments

#21 - Add have_text preference in our guides

Pull Request - State: closed - Opened by JuanitoFatas over 8 years ago - 8 comments

#20 - Add our conclusion of using Query Object to guides

Pull Request - State: closed - Opened by JuanitoFatas over 8 years ago - 3 comments

#19 - Revert "Should format source code for 100 characters"

Pull Request - State: closed - Opened by JuanitoFatas over 8 years ago

#18 - Should format source code for 100 characters

Pull Request - State: closed - Opened by JuanitoFatas over 8 years ago - 14 comments

#17 - Document cp-8 functionality

Issue - State: closed - Opened by halogenandtoast over 8 years ago - 2 comments

#16 - pt-flow

Issue - State: closed - Opened by halogenandtoast over 8 years ago - 2 comments

#15 - Update workflow to mention Trello

Pull Request - State: closed - Opened by balvig over 8 years ago - 2 comments

#14 - Add rspec style guides

Pull Request - State: closed - Opened by kinopyo over 8 years ago - 14 comments

#13 - Emphasize importance of deploying after merge

Pull Request - State: closed - Opened by balvig over 8 years ago - 3 comments

#12 - Avoid using `.classes` in JS

Pull Request - State: closed - Opened by balvig over 8 years ago - 1 comment

#11 - Document DB operations

Pull Request - State: closed - Opened by balvig almost 9 years ago - 1 comment

#10 - [Fixme Fridays] keep guides universal/independent from app

Pull Request - State: closed - Opened by balvig about 9 years ago - 2 comments

#9 - Update docs to reflect current situation

Pull Request - State: closed - Opened by balvig about 9 years ago - 2 comments

#8 - Explain how to move a translation to common

Pull Request - State: closed - Opened by balvig over 9 years ago - 1 comment

#7 - Reusing a key for a different translation

Pull Request - State: closed - Opened by Knack over 9 years ago - 11 comments

#6 - Clarify issues vs stories

Pull Request - State: closed - Opened by balvig over 9 years ago - 2 comments

#5 - Mention hypothesis format

Pull Request - State: closed - Opened by balvig over 9 years ago

#4 - basic migration info

Pull Request - State: closed - Opened by tapster over 9 years ago - 1 comment

#3 - I18n

Pull Request - State: closed - Opened by tapster over 9 years ago - 1 comment

#2 - Add info about `zero:` key

Pull Request - State: closed - Opened by balvig over 9 years ago - 1 comment

#1 - I18n

Pull Request - State: closed - Opened by tapster over 9 years ago - 1 comment

GitHub / cookpad/global-style-guides issues and pull requests