celestiaorg/nmt issues and pull requests

#158 - TestNamespacedMerkleTree_calculateAbsenceIndex_Panic isn’t complete

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#157 - ValidateInclusion function can panic if it is called with an invalid nid

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago - 1 comment
Labels: audit

#156 - VerifyInclusion InvalidInput

Pull Request - State: closed - Opened by andrijamitrovic23 over 1 year ago - 1 comment

#155 - Consider unexporting `PrefixedData8`

Issue - State: closed - Opened by rootulp over 1 year ago
Labels: enhancement

#154 - Proof struct is missing a function for range verification

Issue - State: open - Opened by andrijamitrovic23 over 1 year ago
Labels: enhancement, audit

#153 - ValidateNode does not check the exact size of the non-leaf nodes

Issue - State: closed - Opened by staheri14 over 1 year ago
Labels: enhancement

#152 - chore: delay initialization

Pull Request - State: closed - Opened by rootulp over 1 year ago - 1 comment

#151 - chore: defer compute

Pull Request - State: closed - Opened by rootulp over 1 year ago

#150 - test: remove duplicate test case

Pull Request - State: closed - Opened by rootulp over 1 year ago - 1 comment

#149 - Empty Tree test case

Pull Request - State: open - Opened by andrijamitrovic23 over 1 year ago - 1 comment

#148 - IgnoreMaxNS leads to false computing maxNs

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago - 3 comments
Labels: audit

#147 - Sanity check should be done immediately after tree creation

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago - 1 comment
Labels: enhancement, audit

#146 - Duplication of test cases or a unfinished test case

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: question, audit

#145 - test

Pull Request - State: closed - Opened by MSevey over 1 year ago

#144 - Wrapper Push function will panic if the data is invalid

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#143 - redundant hashing in the computeRoot

Issue - State: closed - Opened by staheri14 over 1 year ago - 1 comment
Labels: enhancement

#142 - buildRangeProof can panic upon invalid input range

Issue - State: closed - Opened by staheri14 over 1 year ago

#141 - VerifyLeafHashes can panic in the completeness check if proof.nodes are not namespaced

Issue - State: closed - Opened by staheri14 over 1 year ago
Labels: enhancement

#140 - verifyLeafHashes function will panic if called from VerifyInclusion function over an empty proof

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#139 - Computing leaf hashes should be done after the range check

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago - 3 comments
Labels: enhancement, audit

#138 - validateSiblingsNamespaceOrder can panic upon invalid inputs

Issue - State: closed - Opened by staheri14 over 1 year ago
Labels: invalid

#137 - Capture index range error in the computeRoot helper

Issue - State: closed - Opened by staheri14 over 1 year ago
Labels: invalid

#136 - feat!: updates the HashNode and HashLeaf methods to return error instead of panic and refactors the code

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 3 comments
Labels: enhancement

#135 - chore: upgrade to Go 1.19

Pull Request - State: closed - Opened by rootulp over 1 year ago - 1 comment
Labels: enhancement

#134 - Reworded explanation of calculating namespace when IgnoreMaxNamespace is set

Pull Request - State: closed - Opened by ivan-gavran over 1 year ago - 2 comments
Labels: documentation

#133 - Unclear explanation of namespace calculation when IgnoreMaxNamespace is set

Issue - State: closed - Opened by ivan-gavran over 1 year ago
Labels: documentation, audit

#132 - Introducing a generic function for generating example trees

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#131 - Hasher initialization and reset should be done after validity checks

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#130 - Duplication of code

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#129 - Check ordering of namespace among child nodes in HashNode function

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago
Labels: audit

#128 - Explain normal Merkle inclusion and range proof in the NMT specification

Issue - State: closed - Opened by staheri14 over 1 year ago
Labels: documentation

#127 - Add NOTICE file

Pull Request - State: closed - Opened by MSevey over 1 year ago - 1 comment

#126 - chore: removes the usage of the merkletree package

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 2 comments
Labels: enhancement

#125 - clarifying the merkletree package usage

Issue - State: closed - Opened by staheri14 over 1 year ago - 5 comments

#124 - chore: enable markdownlint

Pull Request - State: closed - Opened by rootulp over 1 year ago - 1 comment
Labels: enhancement

#123 - Comment about the return value for `ProveNamespace` function does not correspond the code

Issue - State: closed - Opened by andrijamitrovic23 over 1 year ago - 4 comments
Labels: enhancement, audit

#122 - Typo in the spec: `end` instead of `end-1`

Issue - State: closed - Opened by ivan-gavran over 1 year ago
Labels: audit

#121 - Assumption that leaves are ordered is not used consistently

Issue - State: closed - Opened by ivan-gavran over 1 year ago
Labels: audit

#120 - chore: splits the nmt spec into two files and moves them into separate directories

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 1 comment
Labels: documentation

#119 - chore: fixes the description of absence index in the calculateAbsenceIndex

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 1 comment
Labels: documentation

#118 - Assessment of Soundness for the NMT Partial Namespace Absence Proof

Issue - State: closed - Opened by staheri14 over 1 year ago - 4 comments
Labels: documentation, enhancement

#117 - What are the benefits of `IgnoreMaxNamespace`?

Issue - State: closed - Opened by rootulp over 1 year ago - 7 comments
Labels: question

#116 - feat: check the namespace ID range of the leafHash in an absence proof to ensure soundness

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 1 comment
Labels: enhancement

#115 - Namespace proof soundness can fail if leafHash namespace range isn't checked against queried namespace ID

Issue - State: closed - Opened by staheri14 over 1 year ago - 1 comment
Labels: enhancement

#114 - chore: fixes the description of the index of leafHash in the absence proof

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 1 comment
Labels: documentation

#113 - feat: implements input validation functions for HashNode and HashLeaf to prevent panics

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 2 comments
Labels: enhancement

#112 - chore: separation of NMT lib usage guide from the specs

Issue - State: closed - Opened by staheri14 over 1 year ago

#111 - Incorporating test-vectors in the NMT specs

Issue - State: open - Opened by staheri14 over 1 year ago

#110 - Vulnerability in VerifyNamespace: Partial Absence Proofs

Issue - State: closed - Opened by staheri14 over 1 year ago - 9 comments
Labels: enhancement

#109 - feat: Handling Panics in HashNode Method

Issue - State: closed - Opened by staheri14 over 1 year ago - 1 comment

#108 - feat: compute leaf hashes immediately after data items are pushed

Issue - State: closed - Opened by staheri14 over 1 year ago
Labels: enhancement

#106 - Enable markdownlint

Issue - State: closed - Opened by rootulp over 1 year ago

#100 - feat!: increase default namespace id size to 16 bytes

Pull Request - State: closed - Opened by rootulp over 1 year ago - 2 comments

#99 - fix: Resolving Inconsistency in the ProveNamespace Signature for Error Handling

Issue - State: closed - Opened by staheri14 over 1 year ago - 1 comment

#98 - chore: add a link to the nmt specification inside the nmt implementation

Issue - State: closed - Opened by staheri14 over 1 year ago

#97 - Defining and Clarifying the Verification Process for NMT Proofs Generated from Non-Lexicographically Ordered Trees

Issue - State: open - Opened by staheri14 over 1 year ago - 4 comments

#94 - NMT Review

Pull Request - State: closed - Opened by staheri14 over 1 year ago - 2 comments

#86 - Bug: Proofs of Absence can be Forged

Issue - State: closed - Opened by preston-evans98 almost 2 years ago - 2 comments
Labels: bug

#84 - Implement NMT in Rust + make it easy to use from other languages

Issue - State: closed - Opened by liamsi almost 2 years ago - 4 comments

#82 - test: add fuzzers to prevent vulnerability regressions

Pull Request - State: closed - Opened by odeke-em almost 2 years ago - 1 comment

#70 - NamespacedMerkleTree.foundInRange should not narrow uint64 to int

Issue - State: closed - Opened by elias-orijtech almost 2 years ago - 5 comments
Labels: enhancement

#60 - Use the go-internal fuzzer soon.

Issue - State: open - Opened by evan-forbes over 2 years ago - 1 comment

#59 - api: Make the api consistent

Issue - State: open - Opened by evan-forbes over 2 years ago - 1 comment
Labels: API

#46 - New verify and create functions are needed for NamespaceMerkleTreeInclusionProof.

Issue - State: open - Opened by nusret1996 about 3 years ago - 5 comments

#17 - Explore if we want to store inner nodes (in memory) too

Issue - State: open - Opened by liamsi over 3 years ago - 5 comments
Labels: enhancement

GitHub / celestiaorg/nmt issues and pull requests