attestate/ERC4973 issues and pull requests

#67 - Block ERC721 transfers

Pull Request - State: open - Opened by rotcivegaf about 1 year ago - 1 comment

#66 - Fix solidity lint

Pull Request - State: closed - Opened by rotcivegaf about 1 year ago - 1 comment

#65 - Remove ERC721 inheritance

Pull Request - State: closed - Opened by rotcivegaf about 1 year ago

#64 - Fix test expected signature

Pull Request - State: closed - Opened by rotcivegaf about 1 year ago

#63 - Is ERC4973 backwards compatible with ERC721

Issue - State: open - Opened by umerarif01 over 1 year ago - 3 comments

#62 - Replace `function getHash()` with eip-5267

Issue - State: open - Opened by TimDaub over 1 year ago

#61 - Make most external interface functions overrideable like e.g. OZ's ERC721 implementation

Issue - State: open - Opened by TimDaub over 1 year ago

#60 - Implement burn and issue auth

Issue - State: open - Opened by TimDaub over 1 year ago - 2 comments

#59 - An additional `bytes calldata data` to give and take could help extending the interface's functionality

Issue - State: open - Opened by TimDaub over 1 year ago

#58 - Create compatibility with IERC721 and IERC5192

Pull Request - State: closed - Opened by TimDaub over 1 year ago - 5 comments

#57 - fix GHSA-4h98-2769-gh6h

Pull Request - State: closed - Opened by TimDaub over 1 year ago

#56 - Agreement signature has changed to `bytes metadata` and so the sdk has to be updated too

Issue - State: closed - Opened by TimDaub over 1 year ago - 2 comments

#55 - Lint the code, add lint checks to CI

Pull Request - State: closed - Opened by h0tw4t3r over 1 year ago

#54 - Drop local ERC165 implementation, use OZ

Pull Request - State: closed - Opened by h0tw4t3r over 1 year ago - 2 comments

#53 - Signature malleability fix

Pull Request - State: closed - Opened by TimDaub over 1 year ago - 2 comments

#52 - Use opaque metadata

Pull Request - State: closed - Opened by frangio over 1 year ago - 6 comments

#51 - change `string uri` to `bytes metadata` in give and take function

Issue - State: closed - Opened by TimDaub over 1 year ago

#50 - Question: payload to approve signatures from Gnosis Safe

Issue - State: closed - Opened by rahulrumalla over 1 year ago - 4 comments

#49 - implement eip-5267 for structured eip-712 domain retrieval

Issue - State: open - Opened by TimDaub almost 2 years ago - 2 comments

#48 - consider making _mint private so that it is absolutely not used by implementers

Issue - State: open - Opened by TimDaub almost 2 years ago

#47 - testTakeWithDifferentTokenURI

Issue - State: open - Opened by ra-phael almost 2 years ago

#46 - Failing tests: testGiveEOA() and testTakeEOA()

Issue - State: closed - Opened by ra-phael almost 2 years ago - 2 comments

#45 - Consider using vm.prank instead of account abstraction in Badges.t.sol

Issue - State: open - Opened by grp06 almost 2 years ago - 2 comments

#44 - Consider adding totalSupply

Issue - State: open - Opened by rahulrumalla almost 2 years ago - 1 comment

#43 - Cannot import ERC4793.sol from NPM package

Issue - State: closed - Opened by markcutajar almost 2 years ago - 2 comments

#42 - Is it a problem that `testTakeEOA` and `testGiveEOA` produce the same validation signature?

Issue - State: open - Opened by TimDaub almost 2 years ago - 2 comments
Labels: question

#41 - Adding `from` to Transfer event

Pull Request - State: closed - Opened by rahulrumalla almost 2 years ago - 2 comments

#40 - Inclusion of uri in Transfer event

Issue - State: closed - Opened by rahulrumalla almost 2 years ago - 4 comments

#39 - Question: why is from address in TransferEvent hardcoded to address(0)?

Issue - State: closed - Opened by rahulrumalla almost 2 years ago - 6 comments
Labels: bug

#38 - Decleration shadow for tokenURI

Issue - State: closed - Opened by markcutajar almost 2 years ago - 1 comment

#37 - Unused variable `inventory`

Issue - State: closed - Opened by rahulrumalla almost 2 years ago - 1 comment

#36 - Now that function burn was renamed to function unequip we can't distinguish between someone disassociating themselves or "trashing" an item and someone unequipping it

Issue - State: open - Opened by TimDaub almost 2 years ago

#35 - IERC4973 function give and function take need natspec comments

Issue - State: closed - Opened by TimDaub almost 2 years ago

#34 - Remove manually increased tokenId with uint256 generated through type cashing Agreement hash

Issue - State: closed - Opened by TimDaub almost 2 years ago

#33 - Combine Permit and regular standard interface

Issue - State: closed - Opened by TimDaub almost 2 years ago

#32 - Patch: packing tokenURI as keccak256

Pull Request - State: closed - Opened by rahulrumalla about 2 years ago

#31 - once https://github.com/ethereum/EIPs/pull/5193 is merged, create new tag for 3b906d5

Issue - State: closed - Opened by TimDaub about 2 years ago

#30 - fix: bump minimum Solidity version for ERC4973.sol to 0.8.8

Pull Request - State: closed - Opened by YutaSugimura about 2 years ago

#29 - Fixing solc_version = '0.8.6 in foundry.toml makes compiler throw:

Issue - State: closed - Opened by TimDaub about 2 years ago

#28 - Question: How to call mintFromPermission from front-end?

Issue - State: closed - Opened by rahulrumalla about 2 years ago - 3 comments

#27 - Risk in _mint() not using Counters

Issue - State: closed - Opened by rahulrumalla about 2 years ago - 1 comment

#26 - consider renaming `mintWithPermission` to `mintFrom`

Issue - State: closed - Opened by TimDaub about 2 years ago - 3 comments

#25 - consider foundry recommendation on how to test EIP-712

Issue - State: open - Opened by TimDaub about 2 years ago

#24 - The from in mintWithPermission must also allow a contract account (e.g. where the contract implements a permitter interface)

Issue - State: closed - Opened by TimDaub about 2 years ago

#23 - Fixing infinitly callable mintWithPermission

Pull Request - State: closed - Opened by rahulrumalla about 2 years ago - 2 comments

#22 - mintWithPermission is infinitely callable but should only be callable once per type hash voucher

Issue - State: closed - Opened by TimDaub about 2 years ago - 9 comments

#21 - Provide means to internally call mintWithPermission

Issue - State: closed - Opened by rahulrumalla about 2 years ago - 5 comments

#20 - Using counters to dynamically set tokenId in mint

Pull Request - State: closed - Opened by rahulrumalla about 2 years ago - 1 comment

#19 - public interface mintWithPermission must not have uint256 tokenId as it introduces synchronicity requirement for callers

Issue - State: closed - Opened by TimDaub about 2 years ago - 5 comments
Labels: bug

#18 - Mint with permission

Pull Request - State: closed - Opened by rahulrumalla about 2 years ago - 6 comments

#17 - Separate IERC4973Permit as file and then inherit in ERC4973Permit

Issue - State: closed - Opened by TimDaub about 2 years ago - 1 comment

#16 - author field should include url to file

Issue - State: closed - Opened by TimDaub about 2 years ago

#15 - Mint with permission #2

Pull Request - State: closed - Opened by rahulrumalla about 2 years ago - 1 comment

#14 - consider making ERC4973Permit typehash `immutable`

Issue - State: closed - Opened by TimDaub about 2 years ago - 1 comment

#13 - remove inconsistently applied underscore naming convention of internal function

Issue - State: closed - Opened by TimDaub about 2 years ago

#12 - remove inconsistent underscore input parameter convention

Issue - State: closed - Opened by TimDaub about 2 years ago

#11 - Implement balanceOf

Issue - State: closed - Opened by TimDaub about 2 years ago

#10 - set up a linter that checks if files all use two spaces

Issue - State: open - Opened by TimDaub about 2 years ago

#9 - Introduce a .editorconfig that defines repositories tabwidth

Issue - State: closed - Opened by TimDaub about 2 years ago

#8 - Mint with permission

Pull Request - State: closed - Opened by rahulrumalla about 2 years ago - 6 comments

#7 - implement mint with permission

Issue - State: closed - Opened by TimDaub about 2 years ago - 8 comments

#6 - implement optional mint with permission

Issue - State: closed - Opened by TimDaub about 2 years ago - 1 comment

#5 - according to EIP-4973, function burn should now be exposed

Issue - State: closed - Opened by TimDaub about 2 years ago

#4 - Validate re-introducing event Transfer(address,address,uint256) signature to improve backward-compatibility

Issue - State: closed - Opened by TimDaub about 2 years ago - 1 comment

#3 - Add safeMint function

Issue - State: closed - Opened by TimDaub about 2 years ago

#2 - Feat/release on npm

Pull Request - State: closed - Opened by TimDaub about 2 years ago - 8 comments

#1 - Release as npm Package

Issue - State: closed - Opened by slavakurilyak about 2 years ago - 1 comment

GitHub / attestate/ERC4973 issues and pull requests