alchemyplatform/modular-account issues and pull requests

#100 - refactor: move FunctionReference type to IPluginManager

Pull Request - State: closed - Opened by jaypaik 10 months ago

#99 - chore: deploy MA for Alpha release

Pull Request - State: closed - Opened by fangting-alchemy 10 months ago

#98 - fix: [spearbit-40] Evaluate keccak expressions at compile time when possible

Pull Request - State: closed - Opened by adam-alchemy 10 months ago

#97 - fix: [spearbit-24] refactor _resolveManifestFunction

Pull Request - State: closed - Opened by jaypaik 10 months ago

#96 - fix: [spearbit-56] update comments for factory withdraw functions

Pull Request - State: closed - Opened by fangting-alchemy 10 months ago

#95 - fix: [spearbit-60] add comment to explain that view functions are not given user op validation functions

Pull Request - State: closed - Opened by jaypaik 10 months ago

#94 - fix: [spearbit-65] make custom errors more informative

Pull Request - State: closed - Opened by jaypaik 10 months ago

#93 - fix: [spearbit-77] Refactor session key loading util functions

Pull Request - State: closed - Opened by adam-alchemy 10 months ago

#92 - fix: [spearbit-69] reorder functions and update comments in plugins to be consistent

Pull Request - State: closed - Opened by fangting-alchemy 10 months ago

#91 - fix: [spearbit-68] rename vars in account to be consistent

Pull Request - State: closed - Opened by fangting-alchemy 10 months ago

#90 - fix: [spearbit-48] Collapse if/else in SessionKeyPermissionsLoupe

Pull Request - State: closed - Opened by adam-alchemy 10 months ago

#89 - chore: bump to pragma ^0.8.22

Pull Request - State: closed - Opened by jaypaik 10 months ago

#88 - fix: [spearbit-26] Upgrade to solc 0.8.22 and remove explicit unchecked blocks for loop increments

Pull Request - State: closed - Opened by adam-alchemy 11 months ago - 1 comment

#87 - fix: [spearbit-28] Simplify storage access syntax of executeFromPluginExternal

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#86 - fix: [spearbit-71] Expanded comment documentation for structs in SessionKeyPermissionsBase

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#85 - fix: [spearbit-37] Add event emission to MultiOwnerPlugin install/uninstall

Pull Request - State: closed - Opened by adam-alchemy 11 months ago - 1 comment

#84 - fix: [spearbit-39] Declare memory-safe assembly block in AccountStorage

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#83 - fix: [spearbit-16] Use _assertNotNullFunction in `_addHooks`

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#82 - fix: [spearbit-97] cap owners on creation to 100

Pull Request - State: closed - Opened by jaypaik 11 months ago

#81 - fix: [quanstamp-req] Contract data key

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#80 - fix: [spearbit-82] Session key init perms

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#79 - fix: [spearbit-85] Add documentation for no ERC-20 spend limit checks during user op validation

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#78 - fix: [spearbit-90] add warnings for _coalescePreValidation helper function

Pull Request - State: closed - Opened by howydev 11 months ago

#77 - fix: [quantstamp-16] Disallow using dependencies for hooks

Pull Request - State: closed - Opened by dphilipson 11 months ago - 2 comments

#76 - feat: remove permitted call hooks from MSCA (rebase on cache PR)

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 2 comments

#75 - fix: [spearbit-101] Spend limit interval comments

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#74 - fix: [spearbit-105] Remove extraneous comment

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#73 - fix: [spearbit-88] move SIG_VALIDATION_X to a global var

Pull Request - State: closed - Opened by howydev 11 months ago - 2 comments

#72 - fix: [spearbit-58] improve natSpec

Pull Request - State: closed - Opened by howydev 11 months ago

#71 - fix: [spearbit-61] standardize index variable init

Pull Request - State: closed - Opened by howydev 11 months ago

#70 - fix: [spearbit-64] update comments in BasePlugin

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 1 comment

#69 - fix: [spearbit-96] make clearFlag consistent in clear() for associatedLinkedList

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#68 - fix: remove unnecessary view functions for MultiOwnerPlugin

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 1 comment

#67 - fix: [spearbit-47] add evm version=paris in config

Pull Request - State: closed - Opened by howydev 11 months ago

#66 - fix: [spearbit-100] Limit what selectors can be used by session keys on ERC-20 tokens with a spending limit

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#65 - feat: remove permitted call hooks from MSCA

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 1 comment

#64 - fix: [spearbit-106] update comments to use bitwise OR instead of logical OR operator

Pull Request - State: closed - Opened by howydev 11 months ago - 7 comments

#63 - fix: [spearbit-35] flip condition to remove a NOT

Pull Request - State: closed - Opened by jaypaik 11 months ago - 3 comments

#62 - fix: [spearbit-79,102][quantstamp-13] Merge session key plugin with permissions plugin

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#61 - fix: [spearbit-14] remove unused error in PluginManagerInternals

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#60 - fix: [spearbit-30] [quantstamp-26] fix AssociatedLinkedListSetLib _ASSOCIATED_STORAGE_PREFIX bytes4

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#59 - chore: remove pinned foundry version

Pull Request - State: closed - Opened by jaypaik 11 months ago

#58 - fix: [spearbit-98][quantstamp-8] State is not cached properly before validation/execution steps, Non-Idempotent Pre-Execution Hook

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#57 - fix: [spearbit-107] [quantstamp-22] use memory safe revert instead in AccountExecutor

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#56 - fix: [spearbit-44] optimize CountableLinkedListSetLib

Pull Request - State: closed - Opened by jaypaik 11 months ago

#55 - fix: [spearbit-11] Clear bits more efficiently

Pull Request - State: closed - Opened by dphilipson 11 months ago

#54 - fix: [spearbit-31] Remove unnecessary assignment

Pull Request - State: closed - Opened by dphilipson 11 months ago

#53 - fix: [spearbit-27] Remove redundant selector length check

Pull Request - State: closed - Opened by dphilipson 11 months ago

#52 - fix: [spearbit-43] simplify `tryRemoveKnown()`

Pull Request - State: closed - Opened by dphilipson 11 months ago

#51 - fix: [spearbit-29] remove redundant SSTOREs

Pull Request - State: closed - Opened by dphilipson 11 months ago

#50 - fix: [spearbit-42] reorder add and remove owner s logic in multi owner plugin to save gas

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#49 - fix: [quantstamp-32] add owner sorting check and comments in factory and MultiOwnerPlugin for different order of owners

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#48 - fix: [quantstamp-15] only support executeWithSessionKey method in session key permission hooks

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#47 - fix: [spearbit-83] [quantstamp-12] revert in session key permissions preExecHook when function Id not matched

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#46 - fix: [spearbit-107] [quantstamp-22] revert UO validation when error is not sig mismatch in both core account and session key plugin

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 1 comment

#45 - fix: [quantstamp-21] prevent adding IPlugin interface to account

Pull Request - State: closed - Opened by dphilipson 11 months ago

#44 - chore: bump foundry version

Pull Request - State: closed - Opened by jaypaik 11 months ago

#43 - fix: [spearbit-46] remove extra argument from _checkCallPermissions()

Pull Request - State: closed - Opened by jaypaik 11 months ago

#42 - fix: [spearbit-62] cache owners_.length

Pull Request - State: closed - Opened by jaypaik 11 months ago

#41 - fix: [spearbit-66] remove redundant 0 check

Pull Request - State: closed - Opened by jaypaik 11 months ago

#40 - fix: [spearbit-72] cache dependencies.length earlier

Pull Request - State: closed - Opened by jaypaik 11 months ago

#39 - fix: [spearbit-86-41] use cached variables accessControlType, callLength

Pull Request - State: closed - Opened by jaypaik 11 months ago

#38 - fix: [spearbit-54] use salt in eip-712 domain separator

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#37 - style: forge fmt and update foundry version in CI

Pull Request - State: closed - Opened by adam-alchemy 11 months ago

#36 - chore: add optimized-build profile

Pull Request - State: closed - Opened by jaypaik 11 months ago - 1 comment

#35 - fix: [spearbit-51][quantstamp-14] clean up upper bits of address in PluginStorageLib

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 1 comment

#34 - fix: [quantstamp-6] add runtime deny pre hook for session key plugin

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago - 3 comments

#33 - fix: [spearbit-95][quantstamp-9] disallow self-dependencies

Pull Request - State: closed - Opened by jaypaik 11 months ago - 2 comments

#32 - fix: [quantstamp-1] sessionKey ERC20 spending limit comments update

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#31 - fix: [spearbit-89] use newTotalUsage

Pull Request - State: closed - Opened by jaypaik 11 months ago

#30 - fix: [spearbit-92] make gas limit validation reverts less expensive

Pull Request - State: closed - Opened by jaypaik 11 months ago

#29 - fix: [quantstamp-3] add target is not self check in executeFromPluginExternal

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#28 - fix: [quantstamp-1] sessionKey ERC20 spending limit to count approve into limitUsed and ignore existing approve amount

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#27 - fix: lint

Pull Request - State: closed - Opened by howydev 11 months ago - 1 comment

#26 - fix: [spearbit-97] Prevent createAccount() user error

Pull Request - State: closed - Opened by howydev 11 months ago

#25 - fix: [quantstamp-18] clear plugin data early in uninstallPlugin

Pull Request - State: closed - Opened by fangting-alchemy 11 months ago

#24 - fix: [spearbit-55] switch from .transfer to .call

Pull Request - State: closed - Opened by howydev 12 months ago

#23 - fix: [spearbit-45] 2 step ownable factories

Pull Request - State: closed - Opened by howydev 12 months ago

#22 - fix: [spearbit-94] runtime validation bypass special case should only allow installPlugin and upgradeToAndCall

Pull Request - State: closed - Opened by fangting-alchemy 12 months ago

#21 - fix: Reorder CI elements to run `forge fmt` on the correct code

Pull Request - State: closed - Opened by adam-alchemy 12 months ago

#20 - fix: [spearbit-99] Correctly set post-only hook flag

Pull Request - State: closed - Opened by adam-alchemy 12 months ago - 1 comment

#19 - fix: [spearbit-34] Session key rotation registration check

Pull Request - State: closed - Opened by adam-alchemy 12 months ago

#18 - fix: [spearbit-25] Function initialize() can use calldata

Pull Request - State: closed - Opened by dphilipson 12 months ago

#17 - fix: [spearbit-15] IPlugin function prevention in installing execution functions

Pull Request - State: closed - Opened by fangting-alchemy 12 months ago

#16 - fix: [spearbit-97] Prevent createAccount() user error

Pull Request - State: closed - Opened by howydev 12 months ago

#15 - fix: [spearbit-38] ERC-1271 signature validation with EOA owners of contract owners of MSCA

Pull Request - State: closed - Opened by fangting-alchemy 12 months ago

#14 - fix: [spearbit-76] Session key data storage collision

Pull Request - State: closed - Opened by adam-alchemy 12 months ago

#13 - fix: Remove variable shadowing and lint deploy script

Pull Request - State: closed - Opened by adam-alchemy 12 months ago

#12 - fix: [spearbit-12] Typos

Pull Request - State: closed - Opened by adam-alchemy 12 months ago - 1 comment

#11 - style: run forge fmt

Pull Request - State: closed - Opened by adam-alchemy 12 months ago

#10 - chore: setup deploy script and deploy to sepolia

Pull Request - State: closed - Opened by fangting-alchemy about 1 year ago

#9 - test: Expand session key test coverage

Pull Request - State: closed - Opened by adam-alchemy about 1 year ago

#8 - feat: allow upgrade

Pull Request - State: closed - Opened by howydev about 1 year ago

#7 - update readme and comments

Pull Request - State: closed - Opened by howydev about 1 year ago

#6 - update readme and comments

Pull Request - State: closed - Opened by howydev about 1 year ago

#5 - update readme and comments

Pull Request - State: closed - Opened by howydev about 1 year ago

#4 - chore: loupe cleanup

Pull Request - State: closed - Opened by howydev about 1 year ago

#3 - test: revert coverage

Pull Request - State: closed - Opened by jaypaik about 1 year ago

#2 - test: native token spend permissions, unrecognized selector

Pull Request - State: closed - Opened by jaypaik about 1 year ago

#1 - test: upgrade to different MSCA implementation

Pull Request - State: closed - Opened by jaypaik about 1 year ago

GitHub / alchemyplatform/modular-account issues and pull requests