Shopify/javascript issues and pull requests

#277 - Javascript

Issue - State: open - Opened by Manurami9-5 almost 2 years ago

#276 - Fixed the URL link which led users to a HTTP 404.

Pull Request - State: open - Opened by Kavignon over 3 years ago - 1 comment

#275 - Link to 'Testing styleguide' in mian README.md is broken

Issue - State: open - Opened by umar-k over 5 years ago

#274 - Discourage the use of default exports

Pull Request - State: closed - Opened by perrupa about 6 years ago - 4 comments

#270 - Update 10.2 as per func-style allowArrowFunction

Pull Request - State: closed - Opened by sambostock over 7 years ago - 1 comment

#269 - Add legacy CoffeeScript guide

Pull Request - State: closed - Opened by nwtn over 7 years ago - 4 comments

#268 - Translating in to Spanish

Issue - State: closed - Opened by LuigiBaute almost 8 years ago

#267 - Update JS testing guide to include Jest and info on generating coverage

Pull Request - State: closed - Opened by vividviolet about 8 years ago - 1 comment

#266 - Loosen the rule on instance methods using `this`

Pull Request - State: closed - Opened by davidcornu over 8 years ago

#265 - Add spread rule for iterable objects

Issue - State: open - Opened by tmlayton over 8 years ago
Labels: new-rule

#264 - Add spread rule for iterable objects

Pull Request - State: closed - Opened by tmlayton over 8 years ago - 7 comments

#263 - [Discussion] class-methods-use-this

Issue - State: closed - Opened by davidcornu over 8 years ago - 10 comments
Labels: rule-change

#262 - Consider adopting prettier

Issue - State: closed - Opened by davidcornu over 8 years ago - 9 comments

#261 - Definition for rule 'jsx-a11y/img-has-alt' was not found

Issue - State: closed - Opened by skew202 almost 9 years ago - 3 comments

#260 - [fix] Removed the word "ugly" from otherwise fantastic documentation

Pull Request - State: closed - Opened by KsenijaGogic almost 9 years ago - 2 comments

#259 - Can this be used if I want to write custom JS for my shopify theme?

Issue - State: closed - Opened by mdunbavan about 9 years ago - 1 comment

#258 - Fix up README.md links :memo:

Pull Request - State: closed - Opened by ismail-syed about 9 years ago

#257 - Remove packages with solo repos

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago - 2 comments

#256 - Fix minor typos

Pull Request - State: closed - Opened by clauderic about 9 years ago

#255 - Remove esify

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago

#254 - Added guides for using Yarn to install deps

Pull Request - State: closed - Opened by AWaselnuk about 9 years ago - 1 comment

#253 - Add yarn installation instructions

Issue - State: closed - Opened by lemonmade about 9 years ago

#252 - [babel-preset-shopify] inline environment variables opt in

Issue - State: closed - Opened by macdonaldr93 about 9 years ago - 1 comment

#251 - eslint-index

Issue - State: closed - Opened by wagerfield about 9 years ago - 3 comments

#250 - Use babel-preset-env

Issue - State: closed - Opened by lemonmade about 9 years ago - 1 comment

#249 - Recast now adds arrow parens to single arg functions

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago

#248 - Add a TypeScript config

Issue - State: closed - Opened by lemonmade about 9 years ago - 1 comment

#247 - Update eslint plugins

Pull Request - State: closed - Opened by TylerHorth about 9 years ago - 2 comments

#246 - Document our Node.js version strategy

Pull Request - State: closed - Opened by lemonmade about 9 years ago

#245 - Changelog/version bumps for 15.1.0

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago

#244 - Update CHANGELOG for 15.0.4 version bump

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago - 2 comments

#243 - Warn about `for...in`->`for...Object.entries`-style mismatch & null guards

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago - 2 comments

#242 - Split up sequence assignments generated by decaf

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago - 4 comments

#241 - split-if-assignments should handle `else if` assignments

Pull Request - State: closed - Opened by GoodForOneFare about 9 years ago - 1 comment

#240 - esify assumes foo is defined with "for x, y of foo"

Issue - State: closed - Opened by WillsonSmith about 9 years ago - 3 comments
Labels: bug, decaf

#239 - esify silently drops inner classes

Issue - State: closed - Opened by GoodForOneFare about 9 years ago - 1 comment
Labels: bug, decaf

#238 - Fix this destructuring

Issue - State: closed - Opened by GoodForOneFare about 9 years ago - 5 comments
Labels: new-rule

#237 - Warn when removing unused expression

Pull Request - State: closed - Opened by TylerHorth about 9 years ago - 1 comment

#236 - Bump eslint version

Pull Request - State: closed - Opened by TylerHorth about 9 years ago - 2 comments

#235 - Fix `social_marketing_frame.coffee` transform

Issue - State: closed - Opened by GoodForOneFare about 9 years ago - 2 comments
Labels: bug, decaf

#234 - Fix `resource_browser.coffee` transform

Issue - State: closed - Opened by GoodForOneFare about 9 years ago - 1 comment
Labels: bug

#233 - Fix esify eslint

Pull Request - State: closed - Opened by TylerHorth about 9 years ago - 5 comments

#232 - esify should not mangle class properties in shorthand hashes

Issue - State: closed - Opened by GoodForOneFare about 9 years ago - 2 comments
Labels: decaf

#231 - Babel polyfills

Issue - State: open - Opened by tessalt over 9 years ago - 3 comments

#230 - Check on the status of fixes to the react/forbid-component-props rule

Issue - State: closed - Opened by lemonmade over 9 years ago - 1 comment

#229 - Add codemod for "flattening" iife global assignments

Pull Request - State: closed - Opened by nathanmarks over 9 years ago - 2 comments

#228 - Create a wrapper for ESLint

Issue - State: open - Opened by lemonmade over 9 years ago

#227 - Lint rule to prevent use of mocha context instead of closure variable scope

Issue - State: open - Opened by nathanmarks over 9 years ago
Labels: new-rule

#226 - Cannot find `eslint-plugin-mocha` on older versions of Node

Issue - State: closed - Opened by mikkoh over 9 years ago - 11 comments

#225 - esify should warn about removing unused statements

Issue - State: closed - Opened by GoodForOneFare over 9 years ago

#224 - Add ESLint config validation tests

Issue - State: closed - Opened by lemonmade over 9 years ago - 1 comment

#223 - Look at adding a few more ESLint plugins

Issue - State: closed - Opened by lemonmade over 9 years ago - 1 comment

#222 - Look at integrating Khan Academy React recommendations

Issue - State: open - Opened by lemonmade over 9 years ago

#221 - Write up recommendations for publishing packages

Issue - State: open - Opened by lemonmade over 9 years ago

#220 - Update babel presets

Pull Request - State: closed - Opened by lemonmade over 9 years ago - 3 comments

#219 - Promise lints are annoying

Issue - State: open - Opened by bouk over 9 years ago - 5 comments

#218 - Update all dependencies

Pull Request - State: closed - Opened by lemonmade over 9 years ago - 6 comments

#217 - Set a recommended version of Node and tell people a bit about the Node update process

Issue - State: open - Opened by lemonmade over 9 years ago

#216 - Question RE space-before-function-paren

Issue - State: closed - Opened by nathanmarks over 9 years ago - 2 comments

#215 - Turn off `no-duplicate-imports` rule

Pull Request - State: closed - Opened by bouk over 9 years ago - 1 comment

#214 - Always commas for multiline function params

Pull Request - State: closed - Opened by bouk over 9 years ago - 3 comments

#213 - Setup greenkeeper with eslint-plugin-shopify

Issue - State: closed - Opened by mikkoh over 9 years ago - 2 comments

#212 - Can't use babel-preset-shopify with rollup

Issue - State: closed - Opened by bouk over 9 years ago - 3 comments

#211 - Linting updates

Pull Request - State: closed - Opened by lemonmade over 9 years ago - 5 comments

#210 - Fix tests

Pull Request - State: closed - Opened by lemonmade over 9 years ago

#209 - No way to create an object with underscored keys

Issue - State: closed - Opened by bouk over 9 years ago - 2 comments

#208 - Minor React styleguide updates

Pull Request - State: closed - Opened by lemonmade over 9 years ago - 3 comments

#207 - Fixed anchor tag for 10.10 it was pointing to 10.1

Pull Request - State: closed - Opened by mikkoh over 9 years ago - 4 comments

#206 - Testing guide

Pull Request - State: closed - Opened by AWaselnuk over 9 years ago - 11 comments

#205 - Update dependencies

Pull Request - State: closed - Opened by lemonmade over 9 years ago

#204 - Minor linting updates

Pull Request - State: closed - Opened by lemonmade over 9 years ago - 3 comments

#203 - Adds regex search fallback for files that are not of a pure .js extension

Pull Request - State: closed - Opened by justinthec over 9 years ago - 2 comments

#202 - Fix avoid-returning-unused-results edges

Pull Request - State: closed - Opened by lemonmade over 9 years ago

#201 - Issue squashing

Pull Request - State: closed - Opened by lemonmade over 9 years ago

#200 - esify should not try to convert .js.erb files into ASTs

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 7 comments
Labels: bug, transform-blocker

#199 - Exports in coffee/js files with the same name are not conflicts

Pull Request - State: closed - Opened by GoodForOneFare over 9 years ago - 1 comment

#198 - esify should ignore exports in coffee/js files with the same name

Issue - State: closed - Opened by GoodForOneFare over 9 years ago
Labels: bug, transform-blocker

#197 - Use a looser peerDependencies for eslint-plugin-shopify

Pull Request - State: closed - Opened by bouk over 9 years ago - 1 comment

#196 - Add esify doc + warning about interpolated keys

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 1 comment

#195 - Add rule discouraging use of `Bindings`, encouraging `Twine` instead

Issue - State: closed - Opened by qq99 over 9 years ago

#194 - v12.3.3 changelog

Pull Request - State: closed - Opened by GoodForOneFare over 9 years ago - 1 comment

#193 - Automatically import Twine for Bindings

Pull Request - State: closed - Opened by bouk over 9 years ago - 1 comment

#191 - Modify transform to use namespaced import when finding named exports

Pull Request - State: closed - Opened by justinthec over 9 years ago - 3 comments

#185 - ESLint is not actually running

Issue - State: closed - Opened by lemonmade over 9 years ago - 2 comments
Labels: bug

#182 - `hosted_fields.coffee` should be parseable

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 1 comment
Labels: bug, core

#181 - Fix `avoid-returning-unused-results` edge cases

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 2 comments
Labels: bug, transform-blocker

#174 - eslint not being installed by setup script

Issue - State: closed - Opened by justinthec over 9 years ago - 1 comment
Labels: bug

#167 - Add parens to single-parameter arrow functions

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 4 comments

#164 - esify should warn users about class-private vars/calls being moved

Issue - State: closed - Opened by GoodForOneFare over 9 years ago

#143 - Add Node Babel presets

Pull Request - State: closed - Opened by lemonmade over 9 years ago - 1 comment

#133 - Add Promise guidance to styleguide

Issue - State: closed - Opened by GoodForOneFare over 9 years ago
Labels: new-rule

#124 - Consider more transforms to address lint warnings

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 4 comments
Labels: new-codemod

#123 - Consider more transforms to address lint errors

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 1 comment
Labels: new-codemod

#113 - Remove unnecessary IIFEs from non-test code

Issue - State: closed - Opened by GoodForOneFare over 9 years ago - 5 comments
Labels: new-codemod

#80 - Document assertion transforms

Issue - State: closed - Opened by GoodForOneFare almost 10 years ago - 1 comment

#79 - Discourage alternatives to `assert.fail`

Issue - State: closed - Opened by GoodForOneFare almost 10 years ago - 1 comment
Labels: new-rule

#74 - Lint rule to prevent literals as the "actual" part of an assertion

Issue - State: closed - Opened by GoodForOneFare almost 10 years ago
Labels: new-rule

#67 - Arguments to function calls sometimes look weird

Issue - State: closed - Opened by lemonmade almost 10 years ago - 3 comments
Labels: bug

#56 - Provide a better experience for Mocha using expect

Issue - State: closed - Opened by lemonmade almost 10 years ago
Labels: preset-change

#55 - Provide a better initial experience for CSS modules users

Issue - State: closed - Opened by lemonmade almost 10 years ago
Labels: preset-change

GitHub / Shopify/javascript issues and pull requests