RvSpectML/EchelleCCFs.jl issues and pull requests

#103 - CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat)

Pull Request - State: open - Opened by github-actions[bot] 4 months ago

#102 - CompatHelper: add new compat entry for Statistics at version 1, (keep existing compat)

Pull Request - State: closed - Opened by github-actions[bot] 4 months ago

#101 - CompatHelper: bump compat for LsqFit to 0.15, (keep existing compat)

Pull Request - State: closed - Opened by github-actions[bot] 4 months ago

#100 - CompatHelper: bump compat for StatsBase to 0.34, (keep existing compat)

Pull Request - State: closed - Opened by github-actions[bot] over 1 year ago - 1 comment

#99 - CompatHelper: bump compat for LsqFit to 0.13, (keep existing compat)

Pull Request - State: closed - Opened by github-actions[bot] about 2 years ago - 1 comment

#98 - CompatHelper: bump compat for FITSIO to 0.17, (keep existing compat)

Pull Request - State: closed - Opened by github-actions[bot] about 2 years ago - 1 comment

#97 - add `v_center_to_avoid_tellurics` to documentation and check sign convention (address TODO)

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#96 - update documentation (e.g. replace `depth` with `weight`)

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#95 - early return to save time? Also the type of the output would be different ('Nothing')

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: help wanted

#94 - check if `psf_width` is correct (or address TODOs)?

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: documentation, help wanted

#93 - Update documentation to be accurate and address TODOs

Issue - State: open - Opened by hematthi over 2 years ago - 1 comment
Labels: documentation, enhancement

#92 - remove old/commented code

Issue - State: open - Opened by hematthi over 2 years ago
Labels: enhancement

#91 - should `σ_new` be multiplied by `sqrt(2)` or is it already included?

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: help wanted

#90 - address TODOs?

Issue - State: open - Opened by hematthi over 2 years ago
Labels: enhancement

#89 - check if `n1` = 0/1 for even/odd or vice versa

Issue - State: closed - Opened by hematthi over 2 years ago - 2 comments
Labels: bug, help wanted

#88 - if intended to index `x` in steps of 2i, should check that `length(ifo.x) = 2*length(info.gw)`?

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: help wanted

#87 - add documentation for functions

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#86 - unknown type `FuncT` in struct

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: documentation, help wanted

#85 - `v_offset` and `σ_sqrt2` should be fields of `m`

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: bug, enhancement

#84 - update documentation (and function to actually allow for a mixture of Gaussians)

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation, enhancement

#83 - update docstring for inner constructor

Issue - State: open - Opened by hematthi over 2 years ago - 1 comment
Labels: documentation

#82 - use `boost_factor` (address TODO)

Issue - State: open - Opened by hematthi over 2 years ago
Labels: enhancement

#81 - remove commented/moved code and add documentation to remaining function

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#80 - assert on an array of values

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: bug

#79 - `fits_hdr` optional argument is overwritten anyway in function

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: help wanted, invalid

#78 - add documentation and warnings for default values (address TODO)

Issue - State: open - Opened by hematthi over 2 years ago - 2 comments
Labels: documentation

#77 - cannot pass named tuples into `fieldtypes()`?

Issue - State: closed - Opened by hematthi over 2 years ago - 2 comments
Labels: bug, invalid

#76 - repetitive large blocks of code can be made into separate function

Issue - State: open - Opened by hematthi over 2 years ago - 1 comment
Labels: enhancement

#75 - can use `nobs` instead of `length(clt)`

Issue - State: open - Opened by hematthi over 2 years ago - 1 comment
Labels: enhancement

#74 - `num_chunks(clt)` should be the same as `norders`

Issue - State: closed - Opened by hematthi over 2 years ago - 2 comments
Labels: help wanted

#73 - should probably check size of `chunk_ccf_vars_out` too

Issue - State: open - Opened by hematthi over 2 years ago
Labels: enhancement

#72 - default value for `plan_for_chunk` optional argument does not match type

Issue - State: closed - Opened by hematthi over 2 years ago - 3 comments
Labels: bug

#71 - update documentation to consistently describe and name all arguments

Issue - State: open - Opened by hematthi over 2 years ago - 5 comments
Labels: documentation

#70 - `calc_ccf_covar` and `calc_ccf_var` can both be true in if-elseif condition

Issue - State: open - Opened by hematthi over 2 years ago

#69 - potentially redundant print statements?

Issue - State: open - Opened by hematthi over 2 years ago - 2 comments

#68 - should `num_vels` be the maximum or the first of the lengths of each ccf plan?

Issue - State: open - Opened by hematthi over 2 years ago
Labels: help wanted, question

#67 - length of `chunk_list` or `chunk_list.data`?

Issue - State: open - Opened by hematthi over 2 years ago
Labels: help wanted

#66 - `num_chunks` not defined in function

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: bug

#65 - update documentation to describe and consistently name all arguments

Issue - State: open - Opened by hematthi over 2 years ago - 6 comments
Labels: documentation

#64 - function seems redundant with `calc_ccf_chunk()` with `calc_ccf_var = True`

Issue - State: open - Opened by hematthi over 2 years ago
Labels: enhancement

#63 - update documentation to describe and consistently name all arguments (`plan` instead of `ccf_plan`; `var`)

Issue - State: open - Opened by hematthi over 2 years ago - 3 comments
Labels: documentation

#62 - check if documentation for struct is accurate

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: documentation, help wanted

#61 - improve documentation to describe different versions (e.g. `ccf_vars`) and all arguments

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#60 - const default parameters also defined in `EchelleCCFs` module

Issue - State: open - Opened by hematthi over 2 years ago
Labels: question

#59 - function sometimes uses `length(plan.line_list)` and sometimes uses `length(plan.line_list.λ)`

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: enhancement, help wanted

#58 - improve documentation for large function

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#57 - output assigned to `ccf_var` could be a 1d or 2d array

Issue - State: open - Opened by hematthi over 2 years ago - 1 comment
Labels: help wanted

#56 - check if `calc_length_ccf_v_grid` is doing what is intended (see Issue #52)

Issue - State: closed - Opened by hematthi over 2 years ago - 2 comments
Labels: help wanted

#55 - (not an issue)

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment

#54 - could add assert at beginning of function to also check length of `var`

Issue - State: open - Opened by hematthi over 2 years ago
Labels: enhancement

#53 - dangerous assertion?

Issue - State: closed - Opened by hematthi over 2 years ago - 3 comments
Labels: help wanted

#52 - `calc_ccf_v_grid(plan)` function does not do what the docstring says

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: bug, documentation, invalid, question

#51 - asserts redundant due to type declarations for `λ` and `flux`

Issue - State: open - Opened by hematthi over 2 years ago - 5 comments

#50 - update documentation to include all arguments

Issue - State: open - Opened by hematthi over 2 years ago - 3 comments
Labels: documentation

#49 - Fix typos and indentation for all I could find in `src/calc_rv/`

Pull Request - State: closed - Opened by hematthi over 2 years ago - 1 comment

#48 - `in` argument of type `MeasureRvFromCCFTemplateNonDiagCovar` does not have `frac_of_width_to_fit` and `measure_width_at_frac_depth` fields

Issue - State: closed - Opened by hematthi over 2 years ago - 1 comment
Labels: bug

#47 - not all `alg` functors have implementations for all four versions of `measure_rv_from_ccf`

Issue - State: open - Opened by hematthi over 2 years ago - 1 comment
Labels: enhancement

#46 - adding `@assert issorted(vels)` would make this function safer

Issue - State: open - Opened by hematthi over 2 years ago
Labels: help wanted

#45 - update documentation to describe how `ccf`, `ccf_var`, and `ccf_covar` are one dimension higher than those arguments in `measure_rv_from_ccf`

Issue - State: open - Opened by hematthi over 2 years ago
Labels: documentation

#33 - `covar_out` argument not used in function (besides asserts); should replace all instances of `ccf_sample_covar` with `covar_out`

Issue - State: closed - Opened by hematthi over 2 years ago
Labels: bug, enhancement

GitHub / RvSpectML/EchelleCCFs.jl issues and pull requests