DavidT3/XGA issues and pull requests

#1048 - Point label y offset won't be applied properly in relation view method

Issue - State: closed - Opened by DavidT3 about 1 year ago - 1 comment
Labels: bug

#1047 - I missed adding the grouping information to the temperature, luminosi…

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1046 - Added the ability to control spectral binning to the LTR

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1045 - Refine/control ltr spec energy bounds

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1044 - Hopefully improved the calculation of uncertainties for the deproject…

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1043 - Removed the raise warn for issue #1042 - also improved the warning me…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1042 - Apparently introduced an error in a warning that an annular spectrum component wasn't properly generated

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#1041 - Refine/plotting improvements

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1040 - Add a project for the multi-telescoping of XGA

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: documentation

#1039 - The _cnt_bins function for setting up annular bins can sometimes remove the 0th radius?

Issue - State: closed - Opened by DavidT3 over 1 year ago - 2 comments
Labels: bug

#1038 - The Spectrum class should have a save_view method (and a get_view method)

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1037 - radial_brightness function actually seems to require a redshift

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#1036 - Hopefully have fixed issue #1028, I was appending a length of an arra…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1035 - Feat/met free ltr

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1034 - The get_count and get_rate (and maybe get_exp) methods cannot handle multiple coords

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#1033 - Re-running fits with different data will overwrite things

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#1032 - Observation can be excluded from a src silently

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#1031 - Overhaul the sample convenience functions for making scaling relations

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1030 - MHy calculations with radius errors return the wrong shape array

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#1029 - Introduced a bug where retrieving a hydrostatic mass will fail if it has already been run

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#1028 - generating spectra with 'point' region type results in negative x_wid value

Issue - State: closed - Opened by TobyWallage over 1 year ago - 3 comments
Labels: bug

#1027 - LoVoCCS Cluster with Negative Counts in Spectra

Issue - State: open - Opened by mckleichty over 1 year ago - 3 comments

#1026 - Don't think profile objects support non-symmetric uncertainties

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1025 - Add option to plot 'joined up' data points on profile view methods

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#1024 - Normalise the interface to XGA model methods, wrt marginalising over radius distributions

Issue - State: closed - Opened by DavidT3 over 1 year ago

#1023 - BaseAggregateProfile should have a get_view method

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1022 - Let profile objects take a cosmo object/redshift if the input radii are not in angular units

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1021 - Incorrect maths for the conversion of emissivity to density

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: bug

#1020 - Implement support for radius uncertainty in hydrostatic mass measurements

Issue - State: closed - Opened by DavidT3 over 1 year ago - 3 comments
Labels: refinement, breaking change

#1019 - Generation of profile realisations can go negative

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#1018 - Note to self - perhaps more PSF bins by default

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: review

#1017 - _interloper_regions vs _other_regions

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: review

#1016 - New regions are not saved to in the 'edit_regions' method of image when no regions existed initially.

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#1015 - Make ipympl a requirement otherwise matplotlib widget in notebooks doesn't work

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment

#1014 - How to uniquely identify sets of cross-arfs created with different detmap binning?

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1013 - Not dealing with radii properly in single_temp_apec_profile

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: bug

#1012 - Feat/cross arf generation and storage

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1011 - Implement adaptive detmap binning for cross-arf generation

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#1010 - Add view method for the cross-arfs to AnnularSpectra

Issue - State: closed - Opened by DavidT3 over 1 year ago - 2 comments
Labels: enhancement

#1009 - Deleted the old spectrum view method, and renamed new_view to view (a…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1008 - Refine/read the docs conf

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1007 - ReadTheDocs no longer building - add a configuration file for readthedocs and specify a version of urllib I guess

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: bug, documentation

#1006 - Refine/view spectra properly

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1005 - How are XSPEC normalised spectra normalised?

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: question, review

#1004 - Uncertainty on background subtracted counts for new spectrum view

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: question, review

#1003 - Bug/annspec none no attribute usable

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#1002 - Background responses in XSPEC

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement, review

#1001 - Let the user unload a particular data product type

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#1000 - Feat/multi temp plasma

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#999 - Some parts of XGA might not use the right NUM_CORES

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#998 - Very misleading warning given when a source in a sample is excluded due to the cleaning threshold

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#997 - Allow a set of scaling relations to be passed to the XGA LTR

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#996 - Bug/fix r2500 only cluster def

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#995 - LTR pipeline won't work with cleaning with anything but R500 measurements

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#994 - Need more informative error if the user has chosen a cleaning region that isn't available

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#993 - GalaxyCluster definition is broken when using LTR pipeline for non-R500 measurements

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#992 - The BaseSample info() method won't ever work because it can't know whether sources are detected or not

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#991 - Retain absorbed luminosities in XSPEC output

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#990 - The LTR pipeline should now save the peak coordinates into the result…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#989 - I somehow wrote the LTR pipeline so that it saved original coordinates in place of the peaks I actually wanted

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#988 - Turned off autosave in the general XSPEC template. Should close issue…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#987 - Time for a new XSPEC model - multi-temperature plasma!

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: enhancement

#986 - Refine/add relation diagnostic view

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#985 - Bug/uncaught sas error ltr pipeline

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#984 - LT can SAS gen fail and have a failure inside that because its parsing one of the error messages wrong

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#983 - Allow scaling relation data points to be coloured by some third dimension of information

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#982 - Add a diagnostic option to scaling relation view

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#981 - Disable XSPEC autosave/caching

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: refinement

#980 - Make sure you can set custom x-axis and y-axis labels on the AggregateScalingRelation view method

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#979 - I think I way overcomplicated how the LT worked if spectral generatio…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#978 - Broken the LT again - getting an index error presumably linked to spectral generation failure

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: bug

#977 - Combine the common setup steps for spectra/light curves

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: refinement

#976 - Decide what to do about barycentric correction for light curve

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: review

#975 - Refine/resilient spec gen lt

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#974 - Make sure that the XGA LT pipeline is resilient to failed generation of spectra

Issue - State: closed - Opened by DavidT3 over 1 year ago - 3 comments
Labels: refinement

#973 - Added the entropy sourcetools submodule into the sourcetools.rst file…

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#972 - Add an aggregate light curve product

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: enhancement

#971 - Add a light curve XGA product

Issue - State: open - Opened by DavidT3 over 1 year ago - 1 comment
Labels: enhancement

#970 - Implement SAS light-curve creation task

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: enhancement

#969 - Feat/add entropy profile

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#968 - Add mention of the entropy profiles to the docs tutorials

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: documentation

#967 - If profiles directory is deleted, and prior fits have been loaded, the existing annular spectra will not regenerate it

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#966 - Image regions property setter can't handle None entries elegantly

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug

#965 - Feat/first xga tool lt pipeline

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#964 - I appear to have broken 'on_xmm_match'

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#963 - Check that ClusterSample doesn't need its own delete method

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: review

#962 - Add a get_radii method to ClusterSample - make it easier to programatically retrieve named radii

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#961 - Double check implemented scaling relations in XGA

Issue - State: open - Opened by DavidT3 over 1 year ago - 1 comment
Labels: review

#960 - Check that the E(z) indices in the relation convenience functions for ClusterSample are self-similar predictions

Issue - State: open - Opened by DavidT3 over 1 year ago - 1 comment
Labels: review

#959 - Make ScalingRelation objects aware of whether they have an E(z) factor in there

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#958 - Add an EntropyProfile class to XGA

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: enhancement

#957 - My WCS 'fix' introduced a problem where if no image (or regions) exist for a particular ObsID then source declaration fails

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#956 - Accidentally made XGA compatible only with astropy 5

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug, documentation

#955 - Change the default cosmology from Planck15 to concordance, and set it with one parameter declared in utils

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#954 - Implement the LT pipeline in XGA tools

Issue - State: closed - Opened by DavidT3 over 1 year ago - 5 comments
Labels: enhancement

#953 - Create a section of XGA for 'tools' - essentially pipeline implementations

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: refinement

#952 - eexpmap cifbuild call does not pass the num_cores argument

Issue - State: closed - Opened by DavidT3 over 1 year ago
Labels: bug

#951 - The BaseSample obs_ids property returns names

Issue - State: closed - Opened by DavidT3 over 1 year ago - 1 comment
Labels: bug

#950 - Bug/wcs required for regions

Pull Request - State: closed - Opened by DavidT3 over 1 year ago

#949 - Property setters are not included in sphinx autodoc

Issue - State: open - Opened by DavidT3 over 1 year ago
Labels: bug, documentation

GitHub / DavidT3/XGA issues and pull requests