DavidT3/XGA issues and pull requests

#1148 - Added SDSSRM Giles et al. core-excised scaling relations

Pull Request - State: closed - Opened by DavidT3 6 months ago

#1147 - Review ClusterSample name checking and why I'm doing it

Issue - State: open - Opened by DavidT3 6 months ago
Labels: review

#1146 - Hopefully will catch incomplete annular spectra being read in - with …

Pull Request - State: closed - Opened by DavidT3 6 months ago

#1145 - Implement the LoVoCCS centroid measurements actually in XGA (rather than in a notebook) when I'm happy they are as automated as possible

Issue - State: open - Opened by DavidT3 6 months ago
Labels: documentation, refinement

#1144 - Used Euclidean rather than Haversine distance in the offset calculation in 'offset' method of BaseSource

Issue - State: closed - Opened by DavidT3 6 months ago
Labels: bug

#1143 - Why have a separate _shape attribute in Image - just dynamically get it from _data??

Issue - State: open - Opened by DavidT3 6 months ago
Labels: refinement

#1142 - BaseSample nHs calls np.Quantity for some reason

Issue - State: closed - Opened by DavidT3 6 months ago
Labels: bug

#1141 - Timeout warnings for XSPEC fits should be lumped together and given at the end

Issue - State: open - Opened by DavidT3 6 months ago
Labels: refinement

#1140 - Tx and Lx get methods should except any product not available errors

Issue - State: open - Opened by DavidT3 6 months ago
Labels: refinement

#1139 - Refine/more informative non sas error messages

Pull Request - State: closed - Opened by DavidT3 6 months ago

#1138 - Instrument not associated error being raised when assigning spec results to spectra

Issue - State: closed - Opened by DavidT3 6 months ago - 2 comments
Labels: bug

#1137 - Overdensity radius measurement system (a la hydrostatic mass profile method) for the gas mass profiles

Issue - State: open - Opened by DavidT3 7 months ago - 3 comments
Labels: enhancement

#1136 - Getting an argument list too long error from spectrum generation

Issue - State: closed - Opened by DavidT3 7 months ago - 4 comments
Labels: bug, refinement

#1135 - An XMM + eROSITA sample is assigning an XMM image to the wrong source (it doesn't have that ObsID)

Issue - State: closed - Opened by DavidT3 7 months ago - 8 comments
Labels: bug

#1134 - Bug/interactive region altering not working

Pull Request - State: closed - Opened by DavidT3 8 months ago

#1133 - Added XCS SDSSRM R2500 scaling relations for LT

Pull Request - State: closed - Opened by DavidT3 8 months ago

#1132 - Add an inverted power law model to enable simple flipping of scaling relations

Issue - State: open - Opened by DavidT3 8 months ago
Labels: refinement

#1131 - Maybe add a nice way for model instances to show their fitted parameters

Issue - State: open - Opened by DavidT3 9 months ago
Labels: refinement

#1130 - Brightness profiles still have stupid radius values and errors

Issue - State: open - Opened by DavidT3 9 months ago
Labels: bug

#1129 - Refine/update giles lt relations

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1128 - y offset in point labelling should now work properly

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1127 - Think I should have fixed the bug where relation plots get angry with…

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1126 - Refine/make relation error propagation work

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1125 - Could save the debug images as pngs rather than fits

Issue - State: open - Opened by DavidT3 9 months ago
Labels: refinement

#1124 - Check I didn't make XGA get stuck in ObsID specific directories in the existing products read method

Issue - State: closed - Opened by DavidT3 9 months ago - 1 comment
Labels: bug

#1123 - Let GalaxyCluster instances store/use an overdensity radius error

Issue - State: open - Opened by DavidT3 9 months ago
Labels: refinement

#1122 - Added the ability to set a custom title in the view method of image

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1121 - LoLSS analysis threw up an odd problem where the spectral read in gets the name of the spectrum for a coordinate

Issue - State: open - Opened by DavidT3 9 months ago
Labels: bug

#1120 - Feat/limit value range image view

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1119 - Bug/ann spec none no usable take two

Pull Request - State: closed - Opened by DavidT3 9 months ago

#1118 - None has no attribute usable can still pop up with AnnularSpectra definition

Issue - State: open - Opened by DavidT3 9 months ago - 2 comments
Labels: bug

#1117 - Need to do some proper profiling to see what improvements can be made to source/sample declaration efficiency

Issue - State: open - Opened by DavidT3 9 months ago

#1116 - Review how best to return a single peak coordinate

Issue - State: open - Opened by DavidT3 9 months ago
Labels: refinement, review

#1115 - Review the catch-all size for eROSITA CalPV fields that aren't eFEDS

Issue - State: open - Opened by DavidT3 9 months ago
Labels: review

#1114 - Make sure no XGA-spawned command line process copies any core.xxxxxx files out of the temporary directories

Issue - State: open - Opened by DavidT3 9 months ago
Labels: refinement

#1113 - Allow the user to control the timestep for eROSITA spectrum generation - and include it as a retrieval criteria (i.e. along with min_counts)

Issue - State: open - Opened by DavidT3 9 months ago
Labels: refinement

#1112 - EventList should be able to generate XGA Image instances

Issue - State: open - Opened by DavidT3 9 months ago
Labels: enhancement

#1111 - EventList should support the reading in of event tables

Issue - State: closed - Opened by DavidT3 9 months ago - 1 comment
Labels: refinement

#1110 - XGA-LTR has a logical flaw

Issue - State: open - Opened by DavidT3 9 months ago
Labels: bug

#1109 - Stacked spectra don't necessarily seem to be loaded in on redeclaration for eROSITA

Issue - State: open - Opened by DavidT3 9 months ago
Labels: bug, review

#1108 - eROSITA default image boundaries decision

Issue - State: closed - Opened by DavidT3 9 months ago
Labels: refinement

#1107 - MPE-IKE border regions in eRASS are going to cause problems

Issue - State: closed - Opened by DavidT3 9 months ago - 4 comments
Labels: bug

#1106 - Python setup.py install instructions in docs are outdated

Issue - State: closed - Opened by DavidT3 9 months ago
Labels: documentation

#1105 - Different energies of eROSITA image can generate with different sizes

Issue - State: closed - Opened by DavidT3 9 months ago - 1 comment

#1104 - XGA-LTR pipeline should include nH in output dataframes and files

Issue - State: closed - Opened by DavidT3 10 months ago - 1 comment
Labels: refinement

#1103 - Add more stacking capabilities for low SN cluster analysis

Issue - State: open - Opened by DavidT3 10 months ago

#1102 - Can lightcurves be corrected so that different instruments agree?

Issue - State: open - Opened by DavidT3 10 months ago
Labels: review

#1101 - BaseAggregateProduct could do with a re-write

Issue - State: open - Opened by DavidT3 10 months ago

#1100 - Combine the two execute_cmd functions that currently exist (they don't need to be separate)

Issue - State: closed - Opened by DavidT3 10 months ago - 1 comment

#1099 - Do we ever allow ObsID spectra to be stacked?

Issue - State: open - Opened by DavidT3 10 months ago
Labels: review

#1098 - Allow stacked spectra (combined within one ObsID) for annular spectra generation

Issue - State: open - Opened by DavidT3 10 months ago

#1097 - Go through the SAS file imports and normalise them

Issue - State: open - Opened by DavidT3 10 months ago
Labels: cleanup

#1096 - Part load data in Image class

Issue - State: open - Opened by DavidT3 10 months ago
Labels: enhancement

#1095 - Add an 'unload' method to the Image class - so that data can be removed from memory on demand

Issue - State: closed - Opened by DavidT3 10 months ago - 1 comment
Labels: refinement

#1094 - Could the _dist_from_source method be made more efficient?

Issue - State: open - Opened by DavidT3 10 months ago - 1 comment
Labels: refinement

#1093 - Allow individual instrument images to be generated for eROSITA

Issue - State: closed - Opened by DavidT3 10 months ago - 1 comment
Labels: refinement

#1092 - Decide if single ObsID merged images/expmaps belong in the ObsID directory, or the combined directory

Issue - State: open - Opened by DavidT3 10 months ago
Labels: review

#1091 - Add 'extended' property to source classes

Issue - State: open - Opened by DavidT3 10 months ago - 1 comment
Labels: refinement

#1090 - ReadTheDocs will now no longer build the XGA docs

Issue - State: closed - Opened by DavidT3 10 months ago - 1 comment
Labels: bug

#1089 - Assign products to sources in the same obs

Issue - State: open - Opened by jessicapilling 10 months ago
Labels: refinement

#1088 - erosita exposure map headers raise error with fitsio

Issue - State: closed - Opened by jessicapilling 10 months ago - 1 comment
Labels: refinement, cleanup

#1087 - Bug/disass error when loading back in after lc gen

Pull Request - State: closed - Opened by DavidT3 11 months ago

#1086 - Feat/e rosita images exp maps

Pull Request - State: closed - Opened by jessicapilling 11 months ago

#1085 - All SAS processes should not copy up cif files from temporary folder

Issue - State: open - Opened by DavidT3 11 months ago - 2 comments
Labels: refinement

#1084 - Error pops up when disassociating an obs after generating light curves

Issue - State: open - Opened by DavidT3 11 months ago - 1 comment
Labels: bug

#1083 - Should have fixed the bug where the aggregate profile view method wit…

Pull Request - State: closed - Opened by DavidT3 11 months ago

#1082 - The XGA-LTR should write out the nH used to the output results dataframe

Issue - State: closed - Opened by DavidT3 11 months ago
Labels: refinement

#1081 - Refine/fix fixed tx lx pipeline

Pull Request - State: closed - Opened by DavidT3 12 months ago

#1080 - Add a default T-L relation to luminosity_temperature_pipeline

Issue - State: open - Opened by DavidT3 12 months ago

#1079 - Warn the user if the value passed for 'point radius' is small enough that it might cause a problem

Issue - State: open - Opened by DavidT3 12 months ago
Labels: refinement

#1078 - Added a 'freeze_temp' argument to single_temp_apec, though it doesn't…

Pull Request - State: closed - Opened by DavidT3 12 months ago

#1077 - Hopefully fixed the possible bug where reading in lightcurves will fa…

Pull Request - State: closed - Opened by DavidT3 12 months ago

#1076 - Add spectrum checking with XSPEC photon index values of greater than -10 to less than 10 being the legal range

Issue - State: open - Opened by DavidT3 12 months ago
Labels: refinement

#1075 - Should have fixed the unpacking error that showed up in on_xmm_match

Pull Request - State: closed - Opened by DavidT3 12 months ago

#1074 - Changed the default value of 'pattern' for the get methods for lightc…

Pull Request - State: closed - Opened by DavidT3 12 months ago

#1073 - Automatic creation of AggregateLightCurves

Issue - State: open - Opened by DavidT3 12 months ago
Labels: refinement

#1072 - Feat/light curve sas generation

Pull Request - State: closed - Opened by DavidT3 12 months ago

#1071 - Normalise all the arguments (and argument orders) for accessing spectral fit values

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: refinement, review

#1070 - I should rethink how samples work in terms of declaring base sources first

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: refinement

#1069 - XGA for galaxy clusters

Issue - State: open - Opened by gabriel-fontinele about 1 year ago - 1 comment

#1068 - eROSITA (eFEDS) exposure maps seem to cause FITSIO bugs

Issue - State: closed - Opened by DavidT3 about 1 year ago - 3 comments
Labels: bug, refinement, cleanup

#1067 - Add rescale on zoom feature to view method of Image class

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: refinement

#1066 - What do we use as the peak coordinate for multi-mission analyses?

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: review

#1065 - The LT pipeline could identify and disassociate observations that have had failed spec generation

Issue - State: closed - Opened by DavidT3 about 1 year ago - 1 comment

#1064 - The _existing_xga_products method just needs to work fundamentally differently

Issue - State: closed - Opened by DavidT3 about 1 year ago - 1 comment
Labels: refinement

#1063 - Update requirements.txt

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1062 - Will re-organising existing output directories to the new (multi-telescope) structure break spectra/fits?

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: bug, review, breaking change

#1061 - Rewrite on_xmm_match and xmm_region_match to support multiple telescopes

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: refinement

#1060 - Matching functions return blacklists only for fully blacklisted ObsIDs

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: refinement, review

#1059 - Need to make images of specific regions of eventlist for eROSITA

Issue - State: closed - Opened by jessicapilling about 1 year ago
Labels: enhancement

#1058 - Look into spectral rebinning for eROSITA spectra

Issue - State: closed - Opened by jessicapilling about 1 year ago
Labels: enhancement

#1057 - AttributeError: 'NoneType' object has no attribute 'usable' - AnnularSpectra definition AGAIN

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: bug

#1056 - Bug/requirements before release

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1055 - Bug/publish workflow os version

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1054 - Grid problem with ScalingRelation view method

Issue - State: closed - Opened by DavidT3 about 1 year ago
Labels: bug

#1053 - LTR ObsID not associated error

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: bug

#1052 - Problem where XSPEC fits are failing because they can't retrieve spectra

Issue - State: closed - Opened by DavidT3 about 1 year ago - 1 comment
Labels: bug

#1051 - Fixed a bug where wdem was checking if kT existed if there had been a…

Pull Request - State: closed - Opened by DavidT3 about 1 year ago

#1050 - Detector map checking of spectrum region coverage prior to generation

Issue - State: open - Opened by DavidT3 about 1 year ago
Labels: refinement

#1049 - Exploring hashing ObsID base data directories for the census

Issue - State: open - Opened by DavidT3 about 1 year ago - 1 comment
Labels: refinement

GitHub / DavidT3/XGA issues and pull requests